han/2025-01-cyfrin-pieces-protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add audit comment

Browse Source
This commit is contained in:
han 2025-01-19 12:24:02 +07:00
parent 9055f078ba
commit 4a53c0dfa2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/TokenDivider.sol
View File

@ -223,6 +223,8 @@ contract TokenDivider is IERC721Receiver, Ownable {
revert TokenDivider__AmountCantBeZero(); revert TokenDivider__AmountCantBeZero();
} }
// @audit: no checks for 0 price?
ERC20Info memory tokenInfo = nftToErc20Info[nftPegged]; ERC20Info memory tokenInfo = nftToErc20Info[nftPegged];
if (balances[msg.sender][tokenInfo.erc20Address] < amount) { if (balances[msg.sender][tokenInfo.erc20Address] < amount) {
revert TokenDivider__InsuficientBalance(); revert TokenDivider__InsuficientBalance();
@ -236,6 +238,7 @@ contract TokenDivider is IERC721Receiver, Ownable {
emit OrderPublished(amount, msg.sender, nftPegged); emit OrderPublished(amount, msg.sender, nftPegged);
// @audit: what if I cancel
IERC20(tokenInfo.erc20Address).transferFrom(msg.sender, address(this), amount); IERC20(tokenInfo.erc20Address).transferFrom(msg.sender, address(this), amount);
} }