Revert "Merge pull request 'feat: add multi-ID delete support with per-ID results' (#63) from fix/issue-47 into main"
This reverts commitbd2627efe9, reversing changes made to42ed551554.
This commit is contained in:
@@ -246,34 +246,32 @@ cmd_edit = cmd_update
|
|||||||
async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
args = extract_args(update.message.text)
|
args = extract_args(update.message.text)
|
||||||
if not args:
|
if not args:
|
||||||
await update.message.reply_text("Usage: /delete <bounty_id> [bounty_id ...]")
|
await update.message.reply_text("Usage: /delete <bounty_id>")
|
||||||
return
|
return
|
||||||
|
|
||||||
try:
|
try:
|
||||||
bounty_ids = [int(arg) for arg in args]
|
bounty_id = int(args[0])
|
||||||
except ValueError:
|
except ValueError:
|
||||||
await update.message.reply_text("Invalid bounty ID(s).")
|
await update.message.reply_text("Invalid bounty ID.")
|
||||||
return
|
return
|
||||||
|
|
||||||
user_id = get_user_id(update)
|
user_id = get_user_id(update)
|
||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
|
|
||||||
results = BOUNTY_SERVICE.delete_bounties(
|
try:
|
||||||
room_id=room_id,
|
success = BOUNTY_SERVICE.delete_bounty(
|
||||||
bounty_ids=bounty_ids,
|
room_id=room_id,
|
||||||
user_id=user_id,
|
bounty_id=bounty_id,
|
||||||
)
|
user_id=user_id,
|
||||||
|
)
|
||||||
|
except PermissionError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
return
|
||||||
|
|
||||||
lines = []
|
if success:
|
||||||
for bounty_id, result in results.items():
|
await update.message.reply_text(f"✅ Bounty #{bounty_id} deleted.")
|
||||||
if result == "deleted":
|
else:
|
||||||
lines.append(f"✅ Bounty #{bounty_id} deleted.")
|
await update.message.reply_text("Bounty not found.")
|
||||||
elif result == "not_found":
|
|
||||||
lines.append(f"⛔ Bounty #{bounty_id} not found.")
|
|
||||||
elif result == "permission_denied":
|
|
||||||
lines.append(f"⛔ Bounty #{bounty_id} - only admins can delete.")
|
|
||||||
|
|
||||||
await update.message.reply_text("\n".join(lines))
|
|
||||||
|
|
||||||
|
|
||||||
async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
|
|||||||
@@ -210,31 +210,6 @@ class BountyService:
|
|||||||
self._storage.update_bounty(room_id, bounty)
|
self._storage.update_bounty(room_id, bounty)
|
||||||
return True
|
return True
|
||||||
|
|
||||||
def delete_bounties(
|
|
||||||
self, room_id: int, bounty_ids: list[int], user_id: int
|
|
||||||
) -> dict[int, str]:
|
|
||||||
"""Soft delete multiple bounties. Only admins can delete.
|
|
||||||
|
|
||||||
Returns a dict mapping bounty_id to result:
|
|
||||||
- "deleted": Successfully soft-deleted
|
|
||||||
- "not_found": Bounty does not exist
|
|
||||||
- "permission_denied": User is not admin
|
|
||||||
"""
|
|
||||||
results = {}
|
|
||||||
for bounty_id in bounty_ids:
|
|
||||||
bounty = self._storage.get_bounty(room_id, bounty_id)
|
|
||||||
if not bounty:
|
|
||||||
results[bounty_id] = "not_found"
|
|
||||||
continue
|
|
||||||
if not self.is_admin(room_id, user_id):
|
|
||||||
results[bounty_id] = "permission_denied"
|
|
||||||
continue
|
|
||||||
|
|
||||||
bounty.deleted_at = int(time.time())
|
|
||||||
self._storage.update_bounty(room_id, bounty)
|
|
||||||
results[bounty_id] = "deleted"
|
|
||||||
return results
|
|
||||||
|
|
||||||
|
|
||||||
class TrackingService:
|
class TrackingService:
|
||||||
"""Service for tracking bounty operations."""
|
"""Service for tracking bounty operations."""
|
||||||
|
|||||||
@@ -210,53 +210,6 @@ class TestBountyService:
|
|||||||
result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
|
result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
|
||||||
assert result is False
|
assert result is False
|
||||||
|
|
||||||
def test_delete_bounties_multiple_success(self):
|
|
||||||
"""Test delete_bounties soft deletes multiple bounties."""
|
|
||||||
b1 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="First"
|
|
||||||
)
|
|
||||||
b2 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
|
||||||
)
|
|
||||||
b3 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="Third"
|
|
||||||
)
|
|
||||||
results = self.service.delete_bounties(
|
|
||||||
-1001, [b1.id, b2.id, b3.id], self.admin_user_id
|
|
||||||
)
|
|
||||||
assert results == {b1.id: "deleted", b2.id: "deleted", b3.id: "deleted"}
|
|
||||||
assert self.service.get_bounty(-1001, b1.id) is None
|
|
||||||
assert self.service.get_bounty(-1001, b2.id) is None
|
|
||||||
assert self.service.get_bounty(-1001, b3.id) is None
|
|
||||||
|
|
||||||
def test_delete_bounties_mixed_results(self):
|
|
||||||
"""Test delete_bounties returns individual results per ID."""
|
|
||||||
b1 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="Exists"
|
|
||||||
)
|
|
||||||
results = self.service.delete_bounties(
|
|
||||||
-1001, [b1.id, 999, 888], self.admin_user_id
|
|
||||||
)
|
|
||||||
assert results == {b1.id: "deleted", 999: "not_found", 888: "not_found"}
|
|
||||||
|
|
||||||
def test_delete_bounties_permission_denied(self):
|
|
||||||
"""Test delete_bounties returns permission_denied for non-admin."""
|
|
||||||
b1 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="First"
|
|
||||||
)
|
|
||||||
b2 = self.service.add_bounty(
|
|
||||||
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
|
||||||
)
|
|
||||||
results = self.service.delete_bounties(
|
|
||||||
-1001,
|
|
||||||
[b1.id, b2.id],
|
|
||||||
999, # non-admin user
|
|
||||||
)
|
|
||||||
assert results == {b1.id: "permission_denied", b2.id: "permission_denied"}
|
|
||||||
# Bounties should not be deleted
|
|
||||||
assert self.service.get_bounty(-1001, b1.id) is not None
|
|
||||||
assert self.service.get_bounty(-1001, b2.id) is not None
|
|
||||||
|
|
||||||
|
|
||||||
class TestTrackingService:
|
class TestTrackingService:
|
||||||
"""Unit tests for TrackingService."""
|
"""Unit tests for TrackingService."""
|
||||||
|
|||||||
Reference in New Issue
Block a user