jigaido

shoko/jigaido

Fork 0

Commit Graph

Author	SHA1	Message	Date
shokollm	330203e6ef	Address PR #19 review feedback round 2: - Bounty.created_by_user_id is now non-optional (always required) - Removed is_group from RoomData (negative room_id is self-documenting) - Added room_id to TrackedBounty to track which room bounty was tracked from - Added clarifying docstrings explaining TrackingData vs TrackedBounty - Updated tests to match new model structure	2026-04-02 22:24:12 +00:00
shokollm	f1ef33451c	Address PR #19 review feedback: simplify models - Remove GroupBounty/PersonalBounty subclasses, use Bounty with optional created_by_user_id - Combine UserData/GroupData into RoomData with room_id and is_group fields - Add group_id field to TrackingData (supports negative Telegram group IDs) - Add test_bounty_comparison_not_equal for verifying different bounties are not equal - Update core/__init__.py exports	2026-04-02 21:47:26 +00:00
shokollm	db09a518d1	feat(core): implement domain dataclasses for issue #5 - Create core/__init__.py - Create core/models.py with all domain dataclasses: - Bounty (base class) - GroupBounty (extends Bounty) - PersonalBounty (extends Bounty) - TrackedBounty - GroupData - TrackingData - UserData - Create tests/test_models.py with 15 passing tests Fixes #5	2026-04-02 20:15:41 +00:00

Author

SHA1

Message

Date

shokollm

330203e6ef

Address PR #19 review feedback round 2:

- Bounty.created_by_user_id is now non-optional (always required)
- Removed is_group from RoomData (negative room_id is self-documenting)
- Added room_id to TrackedBounty to track which room bounty was tracked from
- Added clarifying docstrings explaining TrackingData vs TrackedBounty
- Updated tests to match new model structure

2026-04-02 22:24:12 +00:00

shokollm

f1ef33451c

Address PR #19 review feedback: simplify models

- Remove GroupBounty/PersonalBounty subclasses, use Bounty with optional created_by_user_id
- Combine UserData/GroupData into RoomData with room_id and is_group fields
- Add group_id field to TrackingData (supports negative Telegram group IDs)
- Add test_bounty_comparison_not_equal for verifying different bounties are not equal
- Update core/__init__.py exports

2026-04-02 21:47:26 +00:00

shokollm

db09a518d1

feat(core): implement domain dataclasses for issue #5

- Create core/__init__.py
- Create core/models.py with all domain dataclasses:
  - Bounty (base class)
  - GroupBounty (extends Bounty)
  - PersonalBounty (extends Bounty)
  - TrackedBounty
  - GroupData
  - TrackingData
  - UserData
- Create tests/test_models.py with 15 passing tests

Fixes #5

2026-04-02 20:15:41 +00:00

3 Commits