Compare commits
1 Commits
6fb4b38c66
...
fix/issue-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6312d94c0b |
@@ -32,52 +32,22 @@ def parse_args(args: list[str]) -> tuple[Optional[str], Optional[str], Optional[
|
|||||||
due_date_ts = None
|
due_date_ts = None
|
||||||
|
|
||||||
remaining = []
|
remaining = []
|
||||||
i = 0
|
for arg in args:
|
||||||
while i < len(args):
|
|
||||||
arg = args[i]
|
|
||||||
if not link and (arg.startswith("http://") or arg.startswith("https://")):
|
if not link and (arg.startswith("http://") or arg.startswith("https://")):
|
||||||
link = arg
|
link = arg
|
||||||
elif due_date_ts is None:
|
elif due_date_ts is None:
|
||||||
parsed = dateparser.parse(arg)
|
parsed = dateparser.parse(arg)
|
||||||
if parsed:
|
if parsed:
|
||||||
due_date_ts = int(parsed.timestamp())
|
due_date_ts = int(parsed.timestamp())
|
||||||
if i + 1 < len(args) and _is_time_format(args[i + 1]):
|
|
||||||
time_str = args[i + 1]
|
|
||||||
hour, minute = map(int, time_str.split(":"))
|
|
||||||
due_date_ts = _set_time_on_timestamp(due_date_ts, hour, minute)
|
|
||||||
i += 1
|
|
||||||
else:
|
else:
|
||||||
remaining.append(arg)
|
remaining.append(arg)
|
||||||
else:
|
else:
|
||||||
remaining.append(arg)
|
remaining.append(arg)
|
||||||
i += 1
|
|
||||||
|
|
||||||
text = " ".join(remaining) if remaining else None
|
text = " ".join(remaining) if remaining else None
|
||||||
return text, link, due_date_ts
|
return text, link, due_date_ts
|
||||||
|
|
||||||
|
|
||||||
def _is_time_format(s: str) -> bool:
|
|
||||||
"""Check if string matches HH:MM format."""
|
|
||||||
if not s or len(s) != 5:
|
|
||||||
return False
|
|
||||||
if s[2] != ":":
|
|
||||||
return False
|
|
||||||
try:
|
|
||||||
h, m = map(int, s.split(":"))
|
|
||||||
return 0 <= h <= 23 and 0 <= m <= 59
|
|
||||||
except ValueError:
|
|
||||||
return False
|
|
||||||
|
|
||||||
|
|
||||||
def _set_time_on_timestamp(ts: int, hour: int, minute: int) -> int:
|
|
||||||
"""Set time (hour:minute) on a Unix timestamp, keeping the date."""
|
|
||||||
import datetime
|
|
||||||
|
|
||||||
dt = datetime.datetime.fromtimestamp(ts)
|
|
||||||
dt = dt.replace(hour=hour, minute=minute, second=0, microsecond=0)
|
|
||||||
return int(dt.timestamp())
|
|
||||||
|
|
||||||
|
|
||||||
def format_bounty(b, show_id: bool = True) -> str:
|
def format_bounty(b, show_id: bool = True) -> str:
|
||||||
parts = []
|
parts = []
|
||||||
if show_id:
|
if show_id:
|
||||||
@@ -162,8 +132,8 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
args = extract_args(update.message.text)
|
args = extract_args(update.message.text)
|
||||||
if not args:
|
if not args:
|
||||||
await update.message.reply_text(
|
await update.message.reply_text(
|
||||||
"Usage: /add <text> [link] [date] [time]\n"
|
"Usage: /add <text> [link] [due_date]\n"
|
||||||
"Example: /add Fix bug https://github.com/foo/bar april 15 14:30"
|
"Example: /add Fix the bug https://github.com/foo/bar tomorrow"
|
||||||
)
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
@@ -175,7 +145,6 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
user_id = get_user_id(update)
|
user_id = get_user_id(update)
|
||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
|
|
||||||
try:
|
|
||||||
bounty = BOUNTY_SERVICE.add_bounty(
|
bounty = BOUNTY_SERVICE.add_bounty(
|
||||||
room_id=room_id,
|
room_id=room_id,
|
||||||
user_id=user_id,
|
user_id=user_id,
|
||||||
@@ -183,12 +152,6 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
link=link,
|
link=link,
|
||||||
due_date_ts=due_date_ts,
|
due_date_ts=due_date_ts,
|
||||||
)
|
)
|
||||||
except PermissionError as e:
|
|
||||||
await update.message.reply_text(f"⛔ {e}")
|
|
||||||
return
|
|
||||||
except ValueError as e:
|
|
||||||
await update.message.reply_text(f"⛔ {e}")
|
|
||||||
return
|
|
||||||
|
|
||||||
due_str = ""
|
due_str = ""
|
||||||
if due_date_ts:
|
if due_date_ts:
|
||||||
@@ -353,9 +316,9 @@ async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
"👻 JIGAIDO Commands:\n\n"
|
"👻 JIGAIDO Commands:\n\n"
|
||||||
"/bounty — list all bounties\n"
|
"/bounty — list all bounties\n"
|
||||||
"/my — bounties you're tracking\n"
|
"/my — bounties you're tracking\n"
|
||||||
"/add <text> [link] [date] [time] — add bounty (admin only)\n"
|
"/add <text> [link] [due] — add bounty\n"
|
||||||
"/update <id> [text] [link] [due] — update bounty (admin only)\n"
|
"/update <id> [text> [link] [due] — update bounty\n"
|
||||||
"/delete <id> — delete bounty (admin only)\n"
|
"/delete <id> — delete bounty\n"
|
||||||
"/track <id> — track a bounty (groups only)\n"
|
"/track <id> — track a bounty (groups only)\n"
|
||||||
"/untrack <id> — stop tracking (groups only)\n"
|
"/untrack <id> — stop tracking (groups only)\n"
|
||||||
"/start — re-initialize\n"
|
"/start — re-initialize\n"
|
||||||
|
|||||||
41
cli/main.py
41
cli/main.py
@@ -127,6 +127,40 @@ def cmd_delete(args):
|
|||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
|
|
||||||
|
|
||||||
|
def cmd_recover(args):
|
||||||
|
"""List or recover soft-deleted bounties."""
|
||||||
|
bounty_service, _ = create_services()
|
||||||
|
room_id = args.group_id or args.user_id
|
||||||
|
user_id = args.user_id or 0
|
||||||
|
|
||||||
|
if not args.bounty_ids:
|
||||||
|
deleted = bounty_service.list_deleted_bounties(room_id)
|
||||||
|
if not deleted:
|
||||||
|
print("No recoverable bounties")
|
||||||
|
return
|
||||||
|
print("Recoverable bounties:")
|
||||||
|
for b in deleted:
|
||||||
|
from datetime import datetime
|
||||||
|
|
||||||
|
deleted_str = datetime.fromtimestamp(b.deleted_at).strftime("%d %b %Y")
|
||||||
|
print(f" [#{b.id}] {b.text or '(no text)'} | Deleted {deleted_str}")
|
||||||
|
return
|
||||||
|
|
||||||
|
if not bounty_service.is_admin(room_id, user_id):
|
||||||
|
print("Error: Only admins can recover bounties.", file=sys.stderr)
|
||||||
|
sys.exit(1)
|
||||||
|
|
||||||
|
for bounty_id in args.bounty_ids:
|
||||||
|
try:
|
||||||
|
success, msg = bounty_service.recover_bounty(
|
||||||
|
room_id=room_id, bounty_id=bounty_id, user_id=user_id
|
||||||
|
)
|
||||||
|
print(msg)
|
||||||
|
except PermissionError as e:
|
||||||
|
print(f"Error: {e}", file=sys.stderr)
|
||||||
|
sys.exit(1)
|
||||||
|
|
||||||
|
|
||||||
def cmd_track(args):
|
def cmd_track(args):
|
||||||
"""Track a bounty."""
|
"""Track a bounty."""
|
||||||
_, tracking_service = create_services()
|
_, tracking_service = create_services()
|
||||||
@@ -196,6 +230,9 @@ def main():
|
|||||||
parser_untrack = subparsers.add_parser("untrack", help="Untrack a bounty")
|
parser_untrack = subparsers.add_parser("untrack", help="Untrack a bounty")
|
||||||
parser_untrack.add_argument("bounty_id", type=int, help="Bounty ID to untrack")
|
parser_untrack.add_argument("bounty_id", type=int, help="Bounty ID to untrack")
|
||||||
|
|
||||||
|
parser_recover = subparsers.add_parser("recover", help="List or recover soft-deleted bounties")
|
||||||
|
parser_recover.add_argument("bounty_ids", nargs="*", type=int, help="Bounty ID(s) to recover (optional)")
|
||||||
|
|
||||||
for sp in [
|
for sp in [
|
||||||
parser_add,
|
parser_add,
|
||||||
parser_list,
|
parser_list,
|
||||||
@@ -204,6 +241,7 @@ def main():
|
|||||||
parser_delete,
|
parser_delete,
|
||||||
parser_track,
|
parser_track,
|
||||||
parser_untrack,
|
parser_untrack,
|
||||||
|
parser_recover,
|
||||||
]:
|
]:
|
||||||
sp.add_argument(
|
sp.add_argument(
|
||||||
"--group-id", type=int, help="Group context (use group room ID)"
|
"--group-id", type=int, help="Group context (use group room ID)"
|
||||||
@@ -222,7 +260,7 @@ def main():
|
|||||||
print("Error: either --group-id or --user-id is required", file=sys.stderr)
|
print("Error: either --group-id or --user-id is required", file=sys.stderr)
|
||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
|
|
||||||
if args.command in ("add", "list", "my", "update", "delete"):
|
if args.command in ("add", "list", "my", "update", "delete", "recover"):
|
||||||
if not (args.group_id or args.user_id):
|
if not (args.group_id or args.user_id):
|
||||||
print("Error: --group-id or --user-id required", file=sys.stderr)
|
print("Error: --group-id or --user-id required", file=sys.stderr)
|
||||||
sys.exit(1)
|
sys.exit(1)
|
||||||
@@ -238,6 +276,7 @@ def main():
|
|||||||
"delete": cmd_delete,
|
"delete": cmd_delete,
|
||||||
"track": cmd_track,
|
"track": cmd_track,
|
||||||
"untrack": cmd_untrack,
|
"untrack": cmd_untrack,
|
||||||
|
"recover": cmd_recover,
|
||||||
}
|
}
|
||||||
|
|
||||||
if args.command in command_map:
|
if args.command in command_map:
|
||||||
|
|||||||
@@ -96,24 +96,21 @@ class BountyService:
|
|||||||
|
|
||||||
def check_link_unique(
|
def check_link_unique(
|
||||||
self, room_id: int, link: str | None, exclude_bounty_id: int | None = None
|
self, room_id: int, link: str | None, exclude_bounty_id: int | None = None
|
||||||
) -> int | None:
|
) -> bool:
|
||||||
"""Check if a link is unique within a room (not used by another bounty).
|
"""Check if a link is unique within a room (not used by another bounty)."""
|
||||||
|
|
||||||
Returns the conflicting bounty ID if found, or None if unique/allowed.
|
|
||||||
"""
|
|
||||||
if not link:
|
if not link:
|
||||||
return None
|
return True
|
||||||
|
|
||||||
room_data = self._storage.load(room_id)
|
room_data = self._storage.load(room_id)
|
||||||
if room_data is None:
|
if room_data is None:
|
||||||
return None
|
return True
|
||||||
|
|
||||||
for bounty in room_data.bounties:
|
for bounty in room_data.bounties:
|
||||||
if bounty.deleted_at is not None:
|
if bounty.deleted_at is not None:
|
||||||
continue
|
continue
|
||||||
if bounty.link == link and bounty.id != exclude_bounty_id:
|
if bounty.link == link and bounty.id != exclude_bounty_id:
|
||||||
return bounty.id
|
return False
|
||||||
return None
|
return True
|
||||||
|
|
||||||
def add_bounty(
|
def add_bounty(
|
||||||
self,
|
self,
|
||||||
@@ -127,11 +124,8 @@ class BountyService:
|
|||||||
if not self.is_admin(room_id, user_id):
|
if not self.is_admin(room_id, user_id):
|
||||||
raise PermissionError("Only admins can add bounties.")
|
raise PermissionError("Only admins can add bounties.")
|
||||||
|
|
||||||
conflicting_id = self.check_link_unique(room_id, link)
|
if not self.check_link_unique(room_id, link):
|
||||||
if conflicting_id is not None:
|
raise ValueError("A bounty with this link already exists in this room.")
|
||||||
raise ValueError(
|
|
||||||
f"A bounty with this link already exists: #{conflicting_id}"
|
|
||||||
)
|
|
||||||
|
|
||||||
room_data = self._storage.load(room_id)
|
room_data = self._storage.load(room_id)
|
||||||
if room_data is None:
|
if room_data is None:
|
||||||
@@ -184,10 +178,8 @@ class BountyService:
|
|||||||
if not self.is_admin(room_id, user_id):
|
if not self.is_admin(room_id, user_id):
|
||||||
raise PermissionError("Only admins can edit bounties.")
|
raise PermissionError("Only admins can edit bounties.")
|
||||||
|
|
||||||
if (
|
if link and not self.check_link_unique(
|
||||||
link
|
room_id, link, exclude_bounty_id=bounty_id
|
||||||
and self.check_link_unique(room_id, link, exclude_bounty_id=bounty_id)
|
|
||||||
is not None
|
|
||||||
):
|
):
|
||||||
raise ValueError("A bounty with this link already exists in this room.")
|
raise ValueError("A bounty with this link already exists in this room.")
|
||||||
|
|
||||||
@@ -218,6 +210,33 @@ class BountyService:
|
|||||||
self._storage.update_bounty(room_id, bounty)
|
self._storage.update_bounty(room_id, bounty)
|
||||||
return True
|
return True
|
||||||
|
|
||||||
|
def recover_bounty(
|
||||||
|
self, room_id: int, bounty_id: int, user_id: int
|
||||||
|
) -> tuple[bool, str]:
|
||||||
|
"""Recover a soft-deleted bounty. Only admins can recover.
|
||||||
|
|
||||||
|
Returns (success, message) tuple.
|
||||||
|
"""
|
||||||
|
all_bounties = self._storage.list_all_bounties(room_id, include_deleted=True)
|
||||||
|
bounty = None
|
||||||
|
for b in all_bounties:
|
||||||
|
if b.id == bounty_id:
|
||||||
|
bounty = b
|
||||||
|
break
|
||||||
|
|
||||||
|
if not bounty:
|
||||||
|
return False, f"Bounty #{bounty_id} not found."
|
||||||
|
|
||||||
|
if bounty.deleted_at is None:
|
||||||
|
return False, f"Bounty #{bounty_id} is not deleted."
|
||||||
|
|
||||||
|
if not self.is_admin(room_id, user_id):
|
||||||
|
raise PermissionError("Only admins can recover bounties.")
|
||||||
|
|
||||||
|
bounty.deleted_at = None
|
||||||
|
self._storage.update_bounty(room_id, bounty)
|
||||||
|
return True, f"Recovered bounty #{bounty_id}."
|
||||||
|
|
||||||
|
|
||||||
class TrackingService:
|
class TrackingService:
|
||||||
"""Service for tracking bounty operations."""
|
"""Service for tracking bounty operations."""
|
||||||
|
|||||||
Reference in New Issue
Block a user