Merge main into fix/issue-45-add-command-update: resolve conflict with room_id param

- Add time parsing (HH:MM format) after date
  Example: /add Fix bug https://github.com/foo/bar april 15 14:30
- Update check_link_unique to return conflicting bounty ID
- Add_bounty now includes bounty ID in duplicate link error
- cmd_add now catches PermissionError and displays admin-only message
- Update usage text and help message
- Fixes #45

apps/telegram-bot/bot.py

@@ -13,7 +13,6 @@ from commands import (
     cmd_edit,
     cmd_help,
     cmd_my,
-    cmd_show,
     cmd_start,
     cmd_timezone,
     cmd_track,
@@ -44,7 +43,6 @@ def build_app() -> Application:
     app.add_handler(CommandHandler("track", cmd_track))
     app.add_handler(CommandHandler("untrack", cmd_untrack))
     app.add_handler(CommandHandler("timezone", cmd_timezone))
-    app.add_handler(CommandHandler("show", cmd_show))
 
     app.add_handler(MessageHandler(filters.COMMAND, cmd_help))
 
@@ -61,7 +59,6 @@ async def post_init(app: Application) -> None:
             ("track", "Track a bounty"),
             ("untrack", "Stop tracking"),
             ("timezone", "Get/set room timezone"),
-            ("show", "Show bounty details"),
             ("help", "Show help"),
         ]
     )

apps/telegram-bot/commands.py

@@ -56,62 +56,56 @@ def extract_args(text: str) -> list[str]:
     return tokens[1:] if len(tokens) > 1 else []
 
 
-def parse_args(
+def parse_args(args: list[str]) -> tuple[Optional[str], Optional[str], Optional[int]]:
-    args: list[str],
-) -> tuple[Optional[str], Optional[str], Optional[int], bool, bool]:
     text = None
     link = None
     due_date_ts = None
-    clear_link = False
-    clear_date = False
 
+    remaining = []
     i = 0
     while i < len(args):
         arg = args[i]
-
+        if not link and (arg.startswith("http://") or arg.startswith("https://")):
-        if arg == "-link":
-            if i + 1 < len(args) and (
-                args[i + 1].startswith("http://") or args[i + 1].startswith("https://")
-            ):
-                link = args[i + 1]
-                i += 2
-            else:
-                clear_link = True
-                i += 1
-        elif arg == "-date":
-            if i + 1 < len(args):
-                parsed = dateparser.parse(args[i + 1])
-                if parsed:
-                    due_date_ts = int(parsed.timestamp())
-                    i += 2
-                else:
-                    clear_date = True
-                    i += 1
-            else:
-                clear_date = True
-                i += 1
-        elif not link and (arg.startswith("http://") or arg.startswith("https://")):
             link = arg
-            i += 1
         elif due_date_ts is None:
             parsed = dateparser.parse(arg)
             if parsed:
                 due_date_ts = int(parsed.timestamp())
-                i += 1
+                if i + 1 < len(args) and _is_time_format(args[i + 1]):
+                    time_str = args[i + 1]
+                    hour, minute = map(int, time_str.split(":"))
+                    due_date_ts = _set_time_on_timestamp(due_date_ts, hour, minute)
+                    i += 1
             else:
-                i += 1
+                remaining.append(arg)
-                if text is None:
-                    text = arg
-                else:
-                    text = text + " " + arg
         else:
-            i += 1
+            remaining.append(arg)
-            if text is None:
+        i += 1
-                text = arg
-            else:
-                text = text + " " + arg
 
-    return text, link, due_date_ts, clear_link, clear_date
+    text = " ".join(remaining) if remaining else None
+    return text, link, due_date_ts
+
+
+def _is_time_format(s: str) -> bool:
+    """Check if string matches HH:MM format."""
+    if not s or len(s) != 5:
+        return False
+    if s[2] != ":":
+        return False
+    try:
+        h, m = map(int, s.split(":"))
+        return 0 <= h <= 23 and 0 <= m <= 59
+    except ValueError:
+        return False
+
+
+def _set_time_on_timestamp(ts: int, hour: int, minute: int) -> int:
+    """Set time (hour:minute) on a Unix timestamp, keeping the date."""
+    import datetime
+
+    dt = datetime.datetime.fromtimestamp(ts)
+    dt = dt.replace(hour=hour, minute=minute, second=0, microsecond=0)
+    return int(dt.timestamp())
 
 
 def format_bounty(b, show_id: bool = True, room_id: int | None = None) -> str:
@@ -203,12 +197,12 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     args = extract_args(update.message.text)
     if not args:
         await update.message.reply_text(
-            "Usage: /add <text> [link] [due_date]\n"
+            "Usage: /add <text> [link] [date] [time]\n"
-            "Example: /add Fix the bug https://github.com/foo/bar tomorrow"
+            "Example: /add Fix bug https://github.com/foo/bar april 15 14:30"
         )
         return
 
-    text, link, due_date_ts, _, _ = parse_args(args)
+    text, link, due_date_ts = parse_args(args)
     if not text and not link:
         await update.message.reply_text("A bounty needs at least text or a link.")
         return
@@ -216,13 +210,20 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     user_id = get_user_id(update)
     room_id = get_room_id(update)
 
-    bounty = BOUNTY_SERVICE.add_bounty(
+    try:
-        room_id=room_id,
+        bounty = BOUNTY_SERVICE.add_bounty(
-        user_id=user_id,
+            room_id=room_id,
-        text=text,
+            user_id=user_id,
-        link=link,
+            text=text,
-        due_date_ts=due_date_ts,
+            link=link,
-    )
+            due_date_ts=due_date_ts,
+        )
+    except PermissionError as e:
+        await update.message.reply_text(f"⛔ {e}")
+        return
+    except ValueError as e:
+        await update.message.reply_text(f"⛔ {e}")
+        return
 
     due_str = ""
     if due_date_ts:
@@ -239,14 +240,7 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     args = extract_args(update.message.text)
     if len(args) < 1:
         await update.message.reply_text(
-            "Usage: /update <bounty_id> [text] [link] [due_date]\n"
+            "Usage: /update <bounty_id> [text] [link] [due_date]"
-            "       /update <bounty_id> -link [<url>]   - clear or set link\n"
-            "       /update <bounty_id> -date [<date>]   - clear or set date\n"
-            "Examples:\n"
-            "  /update 1 new text           - update text only\n"
-            "  /update 1 -link              - clear link\n"
-            "  /update 1 -link https://...  - set link\n"
-            "  /update 1 -link -date        - clear both link and date"
         )
         return
 
@@ -256,14 +250,8 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
         await update.message.reply_text("Invalid bounty ID.")
         return
 
-    text, link, due_date_ts, clear_link, clear_date = parse_args(args[1:])
+    text, link, due_date_ts = parse_args(args[1:])
-    if (
+    if not text and not link and due_date_ts is None:
-        not text
-        and not link
-        and due_date_ts is None
-        and not clear_link
-        and not clear_date
-    ):
         await update.message.reply_text("Nothing to update.")
         return
 
@@ -278,15 +266,10 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
             text=text,
             link=link,
             due_date_ts=due_date_ts,
-            clear_link=clear_link,
-            clear_due=clear_date,
         )
     except PermissionError as e:
         await update.message.reply_text(f"⛔ {e}")
         return
-    except ValueError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
 
     if success:
         await update.message.reply_text(f"✅ Bounty #{bounty_id} updated.")
@@ -401,64 +384,17 @@ async def cmd_start(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
         )
 
 
-async def cmd_show(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
-    args = extract_args(update.message.text)
-    if not args:
-        await update.message.reply_text("Usage: /show <bounty_id>")
-        return
-
-    try:
-        bounty_id = int(args[0])
-    except ValueError:
-        await update.message.reply_text("Invalid bounty ID.")
-        return
-
-    room_id = get_room_id(update)
-    bounty = BOUNTY_SERVICE.get_bounty(room_id, bounty_id)
-
-    if not bounty:
-        await update.message.reply_text("Bounty not found.")
-        return
-
-    timezone = BOUNTY_SERVICE.get_timezone(room_id)
-
-    lines = []
-
-    title = bounty.text or "(no text)"
-    lines.append(f"[#{bounty.id}] {title}")
-
-    due_parts = []
-    if bounty.due_date_ts:
-        due_str = time.strftime("%d %B %Y %H:%M", time.localtime(bounty.due_date_ts))
-        due_parts.append(f"Due: {due_str} ({timezone})")
-
-    username = bounty.created_by_username or f"user#{bounty.created_by_user_id}"
-    if bounty.link:
-        due_parts.append(f"{bounty.link} by @{username}")
-    else:
-        due_parts.append(f"by @{username}")
-
-    if due_parts:
-        lines.extend(due_parts)
-
-    await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
-
-
 async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     await update.message.reply_text(
         "👻 JIGAIDO Commands:\n\n"
         "/bounty — list all bounties\n"
         "/my — bounties you're tracking\n"
-        "/add <text> [link] [due] — add bounty\n"
+        "/add <text> [link] [date] [time] — add bounty (admin only)\n"
-        "/update <id> [text] [link] [due] — update bounty\n"
+        "/update <id> [text] [link] [due] — update bounty (admin only)\n"
-        "/edit <id> [text] [link] [due] — edit bounty (same as update)\n"
-        "  /edit <id> -link [<url>]  — clear or set link\n"
-        "  /edit <id> -date [<date>] — clear or set date\n"
         "/delete <id> — delete bounty (admin only)\n"
         "/track <id> — track a bounty (groups only)\n"
         "/untrack <id> — stop tracking (groups only)\n"
         "/timezone [tz] — get/set room timezone (admin only)\n"
-        "/show <id> — show bounty details\n"
         "/start — re-initialize\n"
         "/help — this message",
         disable_web_page_preview=True,

core/services.py

@@ -96,21 +96,24 @@ class BountyService:
 
     def check_link_unique(
         self, room_id: int, link: str | None, exclude_bounty_id: int | None = None
-    ) -> bool:
+    ) -> int | None:
-        """Check if a link is unique within a room (not used by another bounty)."""
+        """Check if a link is unique within a room (not used by another bounty).
+
+        Returns the conflicting bounty ID if found, or None if unique/allowed.
+        """
         if not link:
-            return True
+            return None
 
         room_data = self._storage.load(room_id)
         if room_data is None:
-            return True
+            return None
 
         for bounty in room_data.bounties:
             if bounty.deleted_at is not None:
                 continue
             if bounty.link == link and bounty.id != exclude_bounty_id:
-                return False
+                return bounty.id
-        return True
+        return None
 
     def add_bounty(
         self,
@@ -124,8 +127,11 @@ class BountyService:
         if not self.is_admin(room_id, user_id):
             raise PermissionError("Only admins can add bounties.")
 
-        if not self.check_link_unique(room_id, link):
+        conflicting_id = self.check_link_unique(room_id, link)
-            raise ValueError("A bounty with this link already exists in this room.")
+        if conflicting_id is not None:
+            raise ValueError(
+                f"A bounty with this link already exists: #{conflicting_id}"
+            )
 
         room_data = self._storage.load(room_id)
         if room_data is None:
@@ -178,8 +184,10 @@ class BountyService:
         if not self.is_admin(room_id, user_id):
             raise PermissionError("Only admins can edit bounties.")
 
-        if link and not self.check_link_unique(
+        if (
-            room_id, link, exclude_bounty_id=bounty_id
+            link
+            and self.check_link_unique(room_id, link, exclude_bounty_id=bounty_id)
+            is not None
         ):
             raise ValueError("A bounty with this link already exists in this room.")