Revert "Merge pull request 'feat: implement /timezone command to get/set room timezone' (#67) from feat/issue-53-timezone into main"

This reverts commit 015df15bd5, reversing
changes made to bd2627efe9.

apps/telegram-bot/bot.py

@@ -14,7 +14,6 @@ from commands import (
     cmd_help,
     cmd_my,
     cmd_start,
-    cmd_timezone,
     cmd_track,
     cmd_untrack,
     cmd_update,
@@ -42,7 +41,6 @@ def build_app() -> Application:
     app.add_handler(CommandHandler("delete", cmd_delete))
     app.add_handler(CommandHandler("track", cmd_track))
     app.add_handler(CommandHandler("untrack", cmd_untrack))
-    app.add_handler(CommandHandler("timezone", cmd_timezone))
 
     app.add_handler(MessageHandler(filters.COMMAND, cmd_help))
 
@@ -58,7 +56,6 @@ async def post_init(app: Application) -> None:
             ("edit", "Edit a bounty"),
             ("track", "Track a bounty"),
             ("untrack", "Stop tracking"),
-            ("timezone", "Get/set room timezone"),
             ("help", "Show help"),
         ]
     )

apps/telegram-bot/commands.py

@@ -4,7 +4,6 @@ import time
 from datetime import datetime
 from functools import wraps
 from typing import Optional
-from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
 
 import dateparser
 from telegram import Update
@@ -62,52 +61,22 @@ def parse_args(args: list[str]) -> tuple[Optional[str], Optional[str], Optional[
     due_date_ts = None
 
     remaining = []
-    i = 0
-    while i < len(args):
-        arg = args[i]
+    for arg in args:
         if not link and (arg.startswith("http://") or arg.startswith("https://")):
             link = arg
         elif due_date_ts is None:
             parsed = dateparser.parse(arg)
             if parsed:
                 due_date_ts = int(parsed.timestamp())
-                if i + 1 < len(args) and _is_time_format(args[i + 1]):
-                    time_str = args[i + 1]
-                    hour, minute = map(int, time_str.split(":"))
-                    due_date_ts = _set_time_on_timestamp(due_date_ts, hour, minute)
-                    i += 1
             else:
                 remaining.append(arg)
         else:
             remaining.append(arg)
-        i += 1
 
     text = " ".join(remaining) if remaining else None
     return text, link, due_date_ts
 
 
-def _is_time_format(s: str) -> bool:
-    """Check if string matches HH:MM format."""
-    if not s or len(s) != 5:
-        return False
-    if s[2] != ":":
-        return False
-    try:
-        h, m = map(int, s.split(":"))
-        return 0 <= h <= 23 and 0 <= m <= 59
-    except ValueError:
-        return False
-
-
-def _set_time_on_timestamp(ts: int, hour: int, minute: int) -> int:
-    """Set time (hour:minute) on a Unix timestamp, keeping the date."""
-    import datetime
-
-    dt = datetime.datetime.fromtimestamp(ts)
-    dt = dt.replace(hour=hour, minute=minute, second=0, microsecond=0)
-    return int(dt.timestamp())
-
-
 def format_bounty(b, show_id: bool = True, room_id: int | None = None) -> str:
     parts = []
     if show_id:
@@ -197,8 +166,8 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     args = extract_args(update.message.text)
     if not args:
         await update.message.reply_text(
-            "Usage: /add <text> [link] [date] [time]\n"
-            "Example: /add Fix bug https://github.com/foo/bar april 15 14:30"
+            "Usage: /add <text> [link] [due_date]\n"
+            "Example: /add Fix the bug https://github.com/foo/bar tomorrow"
         )
         return
 
@@ -210,20 +179,13 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     user_id = get_user_id(update)
     room_id = get_room_id(update)
 
-    try:
-        bounty = BOUNTY_SERVICE.add_bounty(
-            room_id=room_id,
-            user_id=user_id,
-            text=text,
-            link=link,
-            due_date_ts=due_date_ts,
-        )
-    except PermissionError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
-    except ValueError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
+    bounty = BOUNTY_SERVICE.add_bounty(
+        room_id=room_id,
+        user_id=user_id,
+        text=text,
+        link=link,
+        due_date_ts=due_date_ts,
+    )
 
     due_str = ""
     if due_date_ts:
@@ -283,32 +245,34 @@ cmd_edit = cmd_update
 async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     args = extract_args(update.message.text)
     if not args:
-        await update.message.reply_text("Usage: /delete <bounty_id>")
+        await update.message.reply_text("Usage: /delete <bounty_id> [bounty_id ...]")
         return
 
     try:
-        bounty_id = int(args[0])
+        bounty_ids = [int(arg) for arg in args]
     except ValueError:
-        await update.message.reply_text("Invalid bounty ID.")
+        await update.message.reply_text("Invalid bounty ID(s).")
         return
 
     user_id = get_user_id(update)
     room_id = get_room_id(update)
 
-    try:
-        success = BOUNTY_SERVICE.delete_bounty(
-            room_id=room_id,
-            bounty_id=bounty_id,
-            user_id=user_id,
-        )
-    except PermissionError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
+    results = BOUNTY_SERVICE.delete_bounties(
+        room_id=room_id,
+        bounty_ids=bounty_ids,
+        user_id=user_id,
+    )
 
-    if success:
-        await update.message.reply_text(f"✅ Bounty #{bounty_id} deleted.")
-    else:
-        await update.message.reply_text("Bounty not found.")
+    lines = []
+    for bounty_id, result in results.items():
+        if result == "deleted":
+            lines.append(f"✅ Bounty #{bounty_id} deleted.")
+        elif result == "not_found":
+            lines.append(f"⛔ Bounty #{bounty_id} not found.")
+        elif result == "permission_denied":
+            lines.append(f"⛔ Bounty #{bounty_id} - only admins can delete.")
+
+    await update.message.reply_text("\n".join(lines))
 
 
 async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
@@ -389,42 +353,12 @@ async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
         "👻 JIGAIDO Commands:\n\n"
         "/bounty — list all bounties\n"
         "/my — bounties you're tracking\n"
-        "/add <text> [link] [date] [time] — add bounty (admin only)\n"
-        "/update <id> [text] [link] [due] — update bounty (admin only)\n"
-        "/delete <id> — delete bounty (admin only)\n"
+        "/add <text> [link] [due] — add bounty\n"
+        "/update <id> [text> [link] [due] — update bounty\n"
+        "/delete <id> — delete bounty\n"
         "/track <id> — track a bounty (groups only)\n"
         "/untrack <id> — stop tracking (groups only)\n"
-        "/timezone [tz] — get/set room timezone (admin only)\n"
         "/start — re-initialize\n"
         "/help — this message",
         disable_web_page_preview=True,
     )
-
-
-async def cmd_timezone(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
-    args = extract_args(update.message.text)
-    room_id = get_room_id(update)
-    user_id = get_user_id(update)
-
-    if not args:
-        current_tz = BOUNTY_SERVICE.get_timezone(room_id)
-        await update.message.reply_text(f"Current timezone: {current_tz}")
-        return
-
-    timezone_str = args[0]
-
-    try:
-        ZoneInfo(timezone_str)
-    except (KeyError, ZoneInfoNotFoundError):
-        await update.message.reply_text(
-            "⛔ Invalid timezone. Use IANA format (e.g., Asia/Jakarta)"
-        )
-        return
-
-    try:
-        BOUNTY_SERVICE.set_timezone(room_id, timezone_str, user_id)
-    except PermissionError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
-
-    await update.message.reply_text(f"✅ Timezone set to {timezone_str}.")

core/services.py

@@ -96,24 +96,21 @@ class BountyService:
 
     def check_link_unique(
         self, room_id: int, link: str | None, exclude_bounty_id: int | None = None
-    ) -> int | None:
-        """Check if a link is unique within a room (not used by another bounty).
-
-        Returns the conflicting bounty ID if found, or None if unique/allowed.
-        """
+    ) -> bool:
+        """Check if a link is unique within a room (not used by another bounty)."""
         if not link:
-            return None
+            return True
 
         room_data = self._storage.load(room_id)
         if room_data is None:
-            return None
+            return True
 
         for bounty in room_data.bounties:
             if bounty.deleted_at is not None:
                 continue
             if bounty.link == link and bounty.id != exclude_bounty_id:
-                return bounty.id
-        return None
+                return False
+        return True
 
     def add_bounty(
         self,
@@ -127,11 +124,8 @@ class BountyService:
         if not self.is_admin(room_id, user_id):
             raise PermissionError("Only admins can add bounties.")
 
-        conflicting_id = self.check_link_unique(room_id, link)
-        if conflicting_id is not None:
-            raise ValueError(
-                f"A bounty with this link already exists: #{conflicting_id}"
-            )
+        if not self.check_link_unique(room_id, link):
+            raise ValueError("A bounty with this link already exists in this room.")
 
         room_data = self._storage.load(room_id)
         if room_data is None:
@@ -184,10 +178,8 @@ class BountyService:
         if not self.is_admin(room_id, user_id):
             raise PermissionError("Only admins can edit bounties.")
 
-        if (
-            link
-            and self.check_link_unique(room_id, link, exclude_bounty_id=bounty_id)
-            is not None
+        if link and not self.check_link_unique(
+            room_id, link, exclude_bounty_id=bounty_id
         ):
             raise ValueError("A bounty with this link already exists in this room.")
 
@@ -218,6 +210,31 @@ class BountyService:
         self._storage.update_bounty(room_id, bounty)
         return True
 
+    def delete_bounties(
+        self, room_id: int, bounty_ids: list[int], user_id: int
+    ) -> dict[int, str]:
+        """Soft delete multiple bounties. Only admins can delete.
+
+        Returns a dict mapping bounty_id to result:
+        - "deleted": Successfully soft-deleted
+        - "not_found": Bounty does not exist
+        - "permission_denied": User is not admin
+        """
+        results = {}
+        for bounty_id in bounty_ids:
+            bounty = self._storage.get_bounty(room_id, bounty_id)
+            if not bounty:
+                results[bounty_id] = "not_found"
+                continue
+            if not self.is_admin(room_id, user_id):
+                results[bounty_id] = "permission_denied"
+                continue
+
+            bounty.deleted_at = int(time.time())
+            self._storage.update_bounty(room_id, bounty)
+            results[bounty_id] = "deleted"
+        return results
+
 
 class TrackingService:
     """Service for tracking bounty operations."""

tests/test_services.py

@@ -210,6 +210,53 @@ class TestBountyService:
         result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
         assert result is False
 
+    def test_delete_bounties_multiple_success(self):
+        """Test delete_bounties soft deletes multiple bounties."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="First"
+        )
+        b2 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Second"
+        )
+        b3 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Third"
+        )
+        results = self.service.delete_bounties(
+            -1001, [b1.id, b2.id, b3.id], self.admin_user_id
+        )
+        assert results == {b1.id: "deleted", b2.id: "deleted", b3.id: "deleted"}
+        assert self.service.get_bounty(-1001, b1.id) is None
+        assert self.service.get_bounty(-1001, b2.id) is None
+        assert self.service.get_bounty(-1001, b3.id) is None
+
+    def test_delete_bounties_mixed_results(self):
+        """Test delete_bounties returns individual results per ID."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Exists"
+        )
+        results = self.service.delete_bounties(
+            -1001, [b1.id, 999, 888], self.admin_user_id
+        )
+        assert results == {b1.id: "deleted", 999: "not_found", 888: "not_found"}
+
+    def test_delete_bounties_permission_denied(self):
+        """Test delete_bounties returns permission_denied for non-admin."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="First"
+        )
+        b2 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Second"
+        )
+        results = self.service.delete_bounties(
+            -1001,
+            [b1.id, b2.id],
+            999,  # non-admin user
+        )
+        assert results == {b1.id: "permission_denied", b2.id: "permission_denied"}
+        # Bounties should not be deleted
+        assert self.service.get_bounty(-1001, b1.id) is not None
+        assert self.service.get_bounty(-1001, b2.id) is not None
+
 
 class TestTrackingService:
     """Unit tests for TrackingService."""