Clarifying Questions — Pre-implementation Review #1

New Issue

shoko · 2026-04-01T11:46:55+02:00

shoko commented

2026-04-01 11:46:55 +02:00

Context

Pre-implementation review of JIGAIDO Telegram bounty bot. Questions below need answers before proceeding.

Questions

1. `init.py` is empty

File apps/telegram-bot/__init__.py is 0 bytes — Python package marker. Can we remove it?

2. `jigaido-bot.service` as a template

Hardcoded User, Group, WorkingDirectory. Make it a template where setup.sh generates the real file?

3. Logging separation

jigaido.log (INFO) and jigaido-error.log (ERROR)
Path outside git-tracked directory
Questions: preferred log dir? Rotation needed? Python RotatingFileHandler or shell redirect?

4. What does `/start` do?

Group: ensure_group() upserts group + adds creator as admin
DM: ensure_user() upserts user
Should it re-trigger admin assignment if called again? (Currently safe — add_group_admin is idempotent.)

5. `db.init_db()` safe to run multiple times?

CREATE TABLE IF NOT EXISTS — confirmed safe. Add schema version table for migrations?

6. `TELEGRAM_BOT_USERNAME` hardcoded

commands.py:13 — placeholder string, never used. Remove or set from env var?

7. `REMAINDER_WINDOW_DAYS` duplicated

In both commands.py and cron.py as 7. User said drop cron. Remove cron.py entirely?

8. Can we clear a link/due_date?

update_bounty uses COALESCE(?, link) — passing None does NOT clear. Intentional?

9. Git as update mechanism

Where do generated files (.service, env) live — outside git dir or gitignored inside repo?

10. Cron dropped

Remove cron.py entirely? Keep reminder_log table?

Priority

| # | Question | Priority |
|---|---|
| 1 | Git as update mechanism | High |
| 2 | .service as template | Medium |
| 3 | Logging separation | Medium |
| 4 | /start behavior | Medium |
| 5 | Can we clear link/due_date? | Medium |
| 6 | Cron dropped — remove cron.py? | Medium |
| 7 | __init__.py remove? | Low |
| 8 | TELEGRAM_BOT_USERNAME | Low |
| 9 | REMINDER_WINDOW_DAYS duplication | Low |
| 10 | Schema version for migrations? | Low |

## Context Pre-implementation review of JIGAIDO Telegram bounty bot. Questions below need answers before proceeding. ## Questions ### 1. `__init__.py` is empty File `apps/telegram-bot/__init__.py` is 0 bytes — Python package marker. Can we remove it? ### 2. `jigaido-bot.service` as a template Hardcoded `User`, `Group`, `WorkingDirectory`. Make it a template where `setup.sh` generates the real file? ### 3. Logging separation - `jigaido.log` (INFO) and `jigaido-error.log` (ERROR) - Path outside git-tracked directory - Questions: preferred log dir? Rotation needed? Python `RotatingFileHandler` or shell redirect? ### 4. What does `/start` do? - Group: `ensure_group()` upserts group + adds creator as admin - DM: `ensure_user()` upserts user - Should it re-trigger admin assignment if called again? (Currently safe — `add_group_admin` is idempotent.) ### 5. `db.init_db()` safe to run multiple times? `CREATE TABLE IF NOT EXISTS` — confirmed safe. Add schema version table for migrations? ### 6. `TELEGRAM_BOT_USERNAME` hardcoded `commands.py:13` — placeholder string, never used. Remove or set from env var? ### 7. `REMAINDER_WINDOW_DAYS` duplicated In both `commands.py` and `cron.py` as `7`. User said **drop cron**. Remove `cron.py` entirely? ### 8. Can we clear a link/due_date? `update_bounty` uses `COALESCE(?, link)` — passing `None` does NOT clear. Intentional? ### 9. Git as update mechanism Where do generated files (`.service`, env) live — outside git dir or gitignored inside repo? ### 10. Cron dropped Remove `cron.py` entirely? Keep `reminder_log` table? ## Priority | # | Question | Priority | |---|---| | 1 | Git as update mechanism | High | | 2 | `.service` as template | Medium | | 3 | Logging separation | Medium | | 4 | `/start` behavior | Medium | | 5 | Can we clear link/due_date? | Medium | | 6 | Cron dropped — remove `cron.py`? | Medium | | 7 | `__init__.py` remove? | Low | | 8 | `TELEGRAM_BOT_USERNAME` | Low | | 9 | `REMINDER_WINDOW_DAYS` duplication | Low | | 10 | Schema version for migrations? | Low |

shoko closed this issue

2026-04-03 09:03:54 +02:00

shoko referenced this issue from a commit

2026-04-04 08:39:14 +02:00

feat: add multi-ID delete support with per-ID results

shoko referenced this issue from a commit

2026-04-04 15:06:59 +02:00

feat: add multi-ID delete support with per-ID results

shoko referenced this issue from a commit

2026-04-04 15:12:17 +02:00

feat: implement /recover command for listing and recovering soft-deleted bounties

Sign in to join this conversation.