shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

[Phase 1] Task 9: Write tests for new architecture #15

New Issue
Closed
opened 2026-04-02 18:32:16 +02:00 by shoko · 0 comments
shoko commented 2026-04-02 18:32:16 +02:00
Owner
Copy Link

Task 9: Write tests

Labels: phase-1, tests
Dependency: Tasks 5 (#9), 6 (#11), 7 (#13), 8 (#14)

Goal

Write comprehensive tests for the new architecture.

Tests to create

  1. tests/test_models.py

    • Test dataclass instantiation
    • Test field access and types

  2. tests/test_services.py

    • Test BountyService with mocked storage
    • Test BountyService with mocked storage
    • Test TrackingService with mocked storage
    • Test PermissionError on unauthorized edit/delete
    • Test ValueError on bounty not found

  3. tests/test_json_adapter.py

    • Test JsonFileGroupStorage with temp directory
    • Test JsonFilePersonalStorage with temp directory
    • Test JsonFileTrackingStorage with temp directory
    • Test atomic writes
    • Test missing files return empty data

  4. tests/test_cli.py

    • Test CLI argument parsing
    • Test CLI commands with mocked services

Fix existing tests

  • Fix tests/conftest.py to remove broken db import
  • Current tests/test_commands.py tests should continue to work

Acceptance Criteria

  • All new tests pass
  • Existing tests pass
  • pytest runs without errors
## Task 9: Write tests **Labels:** phase-1, tests **Dependency:** Tasks 5 (#9), 6 (#11), 7 (#13), 8 (#14) ### Goal Write comprehensive tests for the new architecture. ### Tests to create 1. tests/test_models.py - Test dataclass instantiation - Test field access and types 2. tests/test_services.py - Test BountyService with mocked storage - Test BountyService with mocked storage - Test TrackingService with mocked storage - Test PermissionError on unauthorized edit/delete - Test ValueError on bounty not found 3. tests/test_json_adapter.py - Test JsonFileGroupStorage with temp directory - Test JsonFilePersonalStorage with temp directory - Test JsonFileTrackingStorage with temp directory - Test atomic writes - Test missing files return empty data 4. tests/test_cli.py - Test CLI argument parsing - Test CLI commands with mocked services ### Fix existing tests - Fix tests/conftest.py to remove broken db import - Current tests/test_commands.py tests should continue to work ### Acceptance Criteria - All new tests pass - Existing tests pass - pytest runs without errors
shoko added the phase-1tests labels 2026-04-02 18:34:44 +02:00
shoko closed this issue 2026-04-03 21:10:27 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label phase-1 tests
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?