shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Code review fix for PR #26 #28

New Issue
Closed
opened 2026-04-03 13:29:25 +02:00 by shoko · 0 comments
shoko commented 2026-04-03 13:29:25 +02:00
Owner
Copy Link

Review Feedback from han

PR #26: feat(core): implement services for issue #8

Requested Changes

Unit tests for services

The PR implements BountyService and TrackingService in core/services.py, but han requested unit tests to ensure the services work correctly even with faulty input.

Required:

  • Create tests/test_services.py with unit tests for:
    • BountyService: test add_bounty, list_bounties, get_bounty, update_bounty, delete_bounty
    • TrackingService: test track_bounty, untrack_bounty, get_tracked_bounties
  • Test edge cases and error handling (invalid input, permission errors, etc.)

Approved: lgtm (han), but requested changes before merge.

## Review Feedback from han **PR #26**: feat(core): implement services for issue #8 ### Requested Changes **Unit tests for services** The PR implements BountyService and TrackingService in `core/services.py`, but han requested unit tests to ensure the services work correctly even with faulty input. **Required:** - Create `tests/test_services.py` with unit tests for: - `BountyService`: test add_bounty, list_bounties, get_bounty, update_bounty, delete_bounty - `TrackingService`: test track_bounty, untrack_bounty, get_tracked_bounties - Test edge cases and error handling (invalid input, permission errors, etc.) **Approved:** lgtm (han), but requested changes before merge.
shoko added the need-user-approval label 2026-04-03 13:29:25 +02:00
shoko closed this issue 2026-04-03 14:25:45 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label need-user-approval
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#28
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?