shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Code review fix for PR #27 #31

New Issue
Closed
opened 2026-04-03 13:29:39 +02:00 by shoko · 0 comments
shoko commented 2026-04-03 13:29:39 +02:00
Owner
Copy Link

Review Feedback from han

PR #27: feat(adapter): implement JSON file storage adapter for issue #9

Requested Changes

1. Unit tests for adapter

Add unit tests to verify the JSON file storage adapter works correctly.

2. Duplicate tracking check

Investigate if the same bounty can be tracked multiple times. If yes, determine where the deduplication logic should be handled (in the adapter, service layer, or elsewhere).

3. Data directory reorganization

Store both rooms and tracking data under the data folder instead of separate directories:

  • Rooms: ~/.jigaido/data/room/<room_id>.json
  • Tracking: ~/.jigaido/data/tracking/<room_id>_<user_id>.json

This makes migration easier and keeps data organized together.

## Review Feedback from han **PR #27**: feat(adapter): implement JSON file storage adapter for issue #9 ### Requested Changes **1. Unit tests for adapter** Add unit tests to verify the JSON file storage adapter works correctly. **2. Duplicate tracking check** Investigate if the same bounty can be tracked multiple times. If yes, determine where the deduplication logic should be handled (in the adapter, service layer, or elsewhere). **3. Data directory reorganization** Store both rooms and tracking data under the `data` folder instead of separate directories: - Rooms: `~/.jigaido/data/room/<room_id>.json` - Tracking: `~/.jigaido/data/tracking/<room_id>_<user_id>.json` This makes migration easier and keeps data organized together.
shoko added the need-user-approval label 2026-04-03 13:29:39 +02:00
shoko closed this issue 2026-04-03 14:25:45 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label need-user-approval
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#31
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?