shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Storage adapter: handle new fields, filtering #42

New Issue
Closed
opened 2026-04-04 06:44:54 +02:00 by shoko · 0 comments
shoko commented 2026-04-04 06:44:54 +02:00
Owner
Copy Link

Objective

Update JSON file storage adapter to handle new fields and filtering logic.

Changes Required

JsonFileRoomStorage

  • Load/save deleted_at field for Bounty
  • Load/save timezone and admin_user_ids fields for RoomData
  • When loading bounties for normal queries, exclude soft-deleted (where deleted_at is not None)
  • Provide method to load ALL bounties including soft-deleted (for /recover)

JsonFileTrackingStorage

  • No changes needed for Phase 2 features

Implementation Notes

  • Filtering happens at storage level - service layer receives only active bounties by default
  • list_bounties() returns only non-deleted
  • Need new list_all_bounties(include_deleted=True) for recover list

Dependencies

  • #41 (model updates must be done first)
## Objective Update JSON file storage adapter to handle new fields and filtering logic. ## Changes Required ### JsonFileRoomStorage - Load/save `deleted_at` field for Bounty - Load/save `timezone` and `admin_user_ids` fields for RoomData - When loading bounties for normal queries, exclude soft-deleted (where deleted_at is not None) - Provide method to load ALL bounties including soft-deleted (for /recover) ### JsonFileTrackingStorage - No changes needed for Phase 2 features ## Implementation Notes - Filtering happens at storage level - service layer receives only active bounties by default - `list_bounties()` returns only non-deleted - Need new `list_all_bounties(include_deleted=True)` for recover list ## Dependencies - #41 (model updates must be done first)
shoko added this to the Phase 2 milestone 2026-04-04 06:44:54 +02:00
shoko added the adapterphase-2 labels 2026-04-04 06:44:54 +02:00
han was assigned by shoko 2026-04-04 06:44:54 +02:00
shoko closed this issue 2026-04-04 07:17:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label adapter phase-2
Milestone
No items
No Milestone Phase 2
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees han
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#42
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?