4885be0752
Phase 1: Ruff lint fixes - Remove unused imports across all files - Remove unused variables (now_utc, tz, ctx) - Fix f-string without placeholders - Fix E402 import order with noqa comments Phase 2: Remove confusing hard delete from storage - Removed delete_bounty() from RoomStorage Protocol (never used by app) - Removed delete_bounty() from JsonFileRoomStorage (was hard delete) - Removed corresponding tests (hard delete was never used) Phase 3: Sync SPEC.md with actual code behavior - Updated overview: admins can add/edit/delete (not 'anyone' + 'creator') - Updated command table: /add, /edit, /delete are admin only - Updated error handling messages Test results: 96 passed (2 hard delete tests removed)
81 lines
2.5 KiB
Python
81 lines
2.5 KiB
Python
"""Abstract storage interfaces (Ports) for JIGAIDO storage adapters."""
|
|
|
|
from typing import Protocol, runtime_checkable
|
|
|
|
from core.models import Bounty, RoomData, TrackingData, TrackedBounty
|
|
|
|
|
|
@runtime_checkable
|
|
class RoomStorage(Protocol):
|
|
"""Storage port for room bounties.
|
|
|
|
A room is identified by room_id:
|
|
- Negative room_id: Telegram group (e.g., -1001)
|
|
- Positive room_id: DM/personal context (user's Telegram ID)
|
|
|
|
This single port handles both group and personal bounties.
|
|
"""
|
|
|
|
def load(self, room_id: int) -> RoomData | None:
|
|
"""Load all data for a room. Returns None if room doesn't exist."""
|
|
...
|
|
|
|
def save(self, room_data: RoomData) -> None:
|
|
"""Save all data for a room."""
|
|
...
|
|
|
|
def add_bounty(self, room_id: int, bounty: Bounty) -> None:
|
|
"""Add a new bounty to a room. Creates room if it doesn't exist."""
|
|
...
|
|
|
|
def update_bounty(self, room_id: int, bounty: Bounty) -> None:
|
|
"""Update an existing bounty in a room."""
|
|
...
|
|
|
|
def get_bounty(self, room_id: int, bounty_id: int) -> Bounty | None:
|
|
"""Get a specific bounty from a room by ID."""
|
|
...
|
|
|
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
|
"""List all non-deleted bounties in a room.
|
|
|
|
Soft-deleted bounties (where deleted_at is not None) are excluded.
|
|
"""
|
|
...
|
|
|
|
def list_all_bounties(
|
|
self, room_id: int, include_deleted: bool = True
|
|
) -> list[Bounty]:
|
|
"""List all bounties including or excluding soft-deleted.
|
|
|
|
Args:
|
|
room_id: The room ID
|
|
include_deleted: If True, return all bounties including soft-deleted.
|
|
If False, return only non-deleted bounties.
|
|
"""
|
|
...
|
|
|
|
|
|
@runtime_checkable
|
|
class TrackingStorage(Protocol):
|
|
"""Storage port for tracking data.
|
|
|
|
Tracks which bounties a user is tracking in a specific room.
|
|
"""
|
|
|
|
def load(self, room_id: int, user_id: int) -> TrackingData | None:
|
|
"""Load tracking data for a user in a room. Returns None if not tracking anything."""
|
|
...
|
|
|
|
def save(self, tracking_data: TrackingData) -> None:
|
|
"""Save tracking data."""
|
|
...
|
|
|
|
def track_bounty(self, room_id: int, user_id: int, tracked: TrackedBounty) -> None:
|
|
"""Add a bounty to a user's tracking list. Creates tracking entry if needed."""
|
|
...
|
|
|
|
def untrack_bounty(self, room_id: int, user_id: int, bounty_id: int) -> None:
|
|
"""Remove a bounty from a user's tracking list."""
|
|
...
|