shoko/jujutsu-skills
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

[Design Discussion] Redesign --detail to use event ID instead of list index #39

New Issue
Open
opened 2026-03-27 02:24:42 +01:00 by shoko · 0 comments
shoko commented 2026-03-27 02:24:42 +01:00
Owner
Copy Link

Problem

Current --detail N design uses list position index (1-indexed) to show detail for a market. This is problematic:

  1. Position changes between queries - Market at position 3 might be at position 7 in the next query
  2. No one wants detail for 10 markets - Why would you want --detail 1 through --detail 10?
  3. Wrong API endpoint - Uses public-search which is for discovery, not event details

Current Behavior

polymarket-browse --detail 3  # Shows detail for 3rd market in list

Proposed Approaches (for discussion)

Option A: Separate CLI argument

polymarket-browse --detail-by-id <event_id>

Option B: Separate command/script

polymarket-detail --id <event_id>

Option C: Change --detail to accept ID instead of index

polymarket-browse --detail <event_id>

Questions

  1. Should detail viewing be in the same command or separate?
  2. Should we use Polymarket event ID or create our own?
  3. What API endpoint should be used for detail view?

References

  • Related PR #33 (fixes out-of-range error but does not address design flaw)
## Problem Current `--detail N` design uses list position index (1-indexed) to show detail for a market. This is problematic: 1. **Position changes between queries** - Market at position 3 might be at position 7 in the next query 2. **No one wants detail for 10 markets** - Why would you want `--detail 1` through `--detail 10`? 3. **Wrong API endpoint** - Uses `public-search` which is for discovery, not event details ## Current Behavior ```bash polymarket-browse --detail 3 # Shows detail for 3rd market in list ``` ## Proposed Approaches (for discussion) ### Option A: Separate CLI argument ```bash polymarket-browse --detail-by-id <event_id> ``` ### Option B: Separate command/script ```bash polymarket-detail --id <event_id> ``` ### Option C: Change --detail to accept ID instead of index ```bash polymarket-browse --detail <event_id> ``` ## Questions 1. Should detail viewing be in the same command or separate? 2. Should we use Polymarket event ID or create our own? 3. What API endpoint should be used for detail view? ## References - Related PR #33 (fixes out-of-range error but does not address design flaw)
shoko added the need clarification label 2026-03-27 02:26:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
bug
Bug fix
 critical
Critical severity - stop using until fixed
 enhancement
Enhancement or feature
 high
High severity - fix ASAP
 in review
low
Low severity
 medium
Medium severity
 need adjustment
need clarification
need review
security
Security-related issues
No Label need clarification
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jujutsu-skills#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?