Merge pull request 'fix(kugetsu): call fix_session_permissions before forking' (#109) from fix/prefork-permissions into main

- Call fix_session_permissions in cmd_start before forking to ensure
  base session has correct permissions for external_directory access
- Add debug logging to show forked session's directory and permissions
  after creation to help diagnose permission inheritance issues

skills/kugetsu/scripts/kugetsu

@@ -1243,44 +1243,96 @@ cmd_start() {
         exit 1
     fi
     
+    local fork_log="$SESSIONS_DIR/$session_file.fork.log"
+    local opencode_db="${OPENCODE_DB:-$HOME/.local/share/opencode/opencode.db}"
+    
+    fix_session_permissions
+    
     if [ "$DEBUG_MODE" = true ]; then
-        (cd "$worktree_path" && opencode run "$message" --fork --session "$base_session_id" 2>&1) | tee "$SESSIONS_DIR/$session_file.debug.log" &
+        (cd "$worktree_path" && opencode run "$message" --fork --session "$base_session_id" 2>&1) | tee "$fork_log" &
     else
-        (cd "$worktree_path" && opencode run "$message" --fork --session "$base_session_id" 2>&1) &
+        (cd "$worktree_path" && opencode run "$message" --fork --session "$base_session_id" 2>&1) >> "$fork_log" &
     fi
 
-    # Wait briefly for session to be created
+    local fork_pid=$!
-    sleep 1
+    
-
+    local max_attempts=10
-    # Find the new session by comparing before/after lists
+    local attempt=1
-    # Skip any session that existed before the fork and skip base/pm-agent
     local new_session_id=""
-    while IFS= read -r sess; do
+    local fork_log_output=""
-        # Skip base and pm-agent
+    
-        [ "$sess" = "$base_session_id" ] && continue
+    while [ $attempt -le $max_attempts ]; do
-        [ "$sess" = "$pm_agent_session_id" ] && continue
+        sleep 1
         
-        # Check if this session existed before
+        while IFS= read -r sess; do
-        local existed_before=false
+            [ "$sess" = "$base_session_id" ] && continue
-        for before_sess in "${before_sessions[@]}"; do
+            [ "$sess" = "$pm_agent_session_id" ] && continue
-            if [ "$sess" = "$before_sess" ]; then
+            
-                existed_before=true
+            local existed_before=false
+            for before_sess in "${before_sessions[@]}"; do
+                if [ "$sess" = "$before_sess" ]; then
+                    existed_before=true
+                    break
+                fi
+            done
+            
+            if [ "$existed_before" = false ]; then
+                new_session_id="$sess"
                 break
             fi
-        done
+        done < <(opencode session list 2>/dev/null | grep -oP '^ses_\w+')
         
-        if [ "$existed_before" = false ]; then
+        if [ -n "$new_session_id" ]; then
-            new_session_id="$sess"
             break
         fi
-    done < <(opencode session list 2>/dev/null | grep -oP '^ses_\w+')
+        
+        if ! kill -0 $fork_pid 2>/dev/null; then
+            fork_log_output=$(tail -20 "$fork_log" 2>/dev/null || echo "(log empty or unavailable)")
+            break
+        fi
+        
+        attempt=$((attempt + 1))
+    done
 
     if [ -z "$new_session_id" ]; then
-        echo "Error: Could not find newly created session" >&2
+        if [ -f "$opencode_db" ]; then
+            local db_sessions=$(python3 -c "
+import sqlite3
+conn = sqlite3.connect('$opencode_db')
+cursor = conn.cursor()
+cursor.execute(\"SELECT id FROM session WHERE parent_id IS NOT NULL ORDER BY time_created DESC LIMIT 5\")
+for row in cursor.fetchall():
+    print(row[0])
+" 2>/dev/null || echo "")
+            if [ -n "$db_sessions" ]; then
+                echo "Recent forked sessions in DB:" >&2
+                echo "$db_sessions" >&2
+            fi
+        fi
+        
+        echo "Error: Could not find newly created session after ${max_attempts}s" >&2
+        if [ -n "$fork_log_output" ]; then
+            echo "Fork log output:" >&2
+            echo "$fork_log_output" >&2
+        fi
         remove_worktree_for_issue "$issue_ref"
         exit 1
     fi
 
+    if [ "$DEBUG_MODE" = true ]; then
+        echo "[DEBUG] Forked session permissions check:"
+        python3 -c "
+import sqlite3
+conn = sqlite3.connect('$opencode_db')
+cursor = conn.cursor()
+cursor.execute(\"SELECT id, directory, permission FROM session WHERE id = '$new_session_id'\")
+for row in cursor.fetchall():
+    print('  ID:', row[0])
+    print('  Directory:', row[1])
+    print('  Permission:', row[2])
+" 2>/dev/null || echo "  (failed to query DB)"
+    fi
+
     printf '{"type": "forked", "issue_ref": "%s", "opencode_session_id": "%s", "worktree_path": "%s", "created_at": "%s", "state": "idle"}\n' \
         "$issue_ref" "$new_session_id" "$worktree_path" "$(date -Iseconds)" > "$SESSIONS_DIR/$session_file"