Code Quality - Shellcheck & Error Handling #121

Closed
opened 2026-04-03 11:14:11 +02:00 by shoko · 0 comments
Owner

Summary

Fix shellcheck warnings and standardize error handling.

Depends On

  • #116 (Foundation - Modularize Shell Script)

Details

  • Run shellcheck on all shell scripts
  • Fix all warnings/errors reported
  • Standardize error handling:
    • Decide per-function: either set -e exit on error OR log+continue
    • No mixing within same function
  • Add retry logic for network operations (git clone, opencode calls)

Backport Compatible

Internal cleanup with stricter validation.

Acceptance Criteria

  • Zero shellcheck errors/warnings
  • Consistent error handling across modules
  • Network operations have retry logic (configurable attempts)
## Summary Fix shellcheck warnings and standardize error handling. ## Depends On - #116 (Foundation - Modularize Shell Script) ## Details - Run `shellcheck` on all shell scripts - Fix all warnings/errors reported - Standardize error handling: - Decide per-function: either `set -e` exit on error OR log+continue - No mixing within same function - Add retry logic for network operations (git clone, opencode calls) ## Backport Compatible Internal cleanup with stricter validation. ## Acceptance Criteria - [ ] Zero shellcheck errors/warnings - [ ] Consistent error handling across modules - [ ] Network operations have retry logic (configurable attempts)
shoko added the backportfoundation labels 2026-04-03 11:18:19 +02:00
shoko added this to the v0.2.x milestone 2026-04-03 11:18:20 +02:00
shoko added the ready label 2026-04-07 08:55:27 +02:00
shoko closed this issue 2026-04-08 07:04:27 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#121