[BUG] delegate command issue ref parser does not support gitserver/owner/repo#number format #144
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug: delegate command issue ref parser does not support gitserver/owner/repo#number format
Severity: Low - minor ergonomics issue, workaround exists
Description:
The parse_issue_ref_from_message function in kugetsu has two working patterns:
Full URL format:
gitserver/owner/repo/(issues|pull)/numberExample:
https://git.fbrns.co/shoko/kugetsu/issues/116Short format without domain:
owner/repo#numberExample:
shoko/kugetsu#116However, it fails to parse the mixed format
gitserver/owner/repo#number:Example:
git.fbrns.co/shoko/kugetsu#116Example:
github.com/shoko/kugetsu#116The regex for the full URL format specifically requires
/issues/or/pull/in the path, so the short format with a domain prefix doesn't match.Location: parse_issue_ref_from_message() function, around lines 1128-1157
Current patterns:
What doesn't work:
Workaround: Use full URL format instead:
Suggested fix:
Add a third pattern to handle
gitserver/owner/repo#numberformat:Labels: backport, foundation