[BUG] delegate command parser rejects gitserver/owner/repo#number format #145
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug: The
parse_issue_ref_from_messagefunction rejects thegitserver/owner/repo#numberformat which is kugetsu's native issue ref format.Severity: Low - minor ergonomics issue, workaround exists
Description:
The parser in
parse_issue_ref_from_message()accepts two formats:gitserver/owner/repo/(issues|pull)/number- e.g.github.com/shoko/kugetsu/issues/116owner/repo#number- e.g.shoko/kugetsu#116But it rejects the
gitserver/owner/repo#numberformat which is kugetsu's own native issue ref format (used bykugetsu list,kugetsu start, etc.).Example rejection:
Workaround: Use full URL format:
https://git.fbrns.co/shoko/kugetsu/issues/116Fix: Add a third pattern to match
gitserver/owner/repo#numberformat. The existing regex on line ~1138 already handlesgitserver/owner/repo/(issues|pull)/numberbut is missing the#numbervariant.Labels: [14]