shoko/kugetsu
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Queue daemon: hardcoded origin/main..HEAD for commit detection #165

New Issue
Closed
opened 2026-04-06 02:07:43 +02:00 by shoko · 2 comments
shoko commented 2026-04-06 02:07:43 +02:00
Owner
Copy Link

Problem

The queue daemon's check_task_completion() uses hardcoded 'origin/main..HEAD' to detect if a task has commits:

This assumes all worktrees track 'origin/main', which may not be correct for:

  • Forks with different remotes (e.g., upstream/main)
  • Worktrees created from different branches
  • Users with custom branch naming conventions

Expected Fix

Make the base branch configurable via:

  1. Environment variable (e.g., KUGETSU_BASE_BRANCH)
  2. Or store the base branch per-session in the session JSON file

Severity

Medium - works for most users but breaks for forks/custom setups

## Problem The queue daemon's check_task_completion() uses hardcoded 'origin/main..HEAD' to detect if a task has commits: This assumes all worktrees track 'origin/main', which may not be correct for: - Forks with different remotes (e.g., upstream/main) - Worktrees created from different branches - Users with custom branch naming conventions ## Expected Fix Make the base branch configurable via: 1. Environment variable (e.g., KUGETSU_BASE_BRANCH) 2. Or store the base branch per-session in the session JSON file ## Severity Medium - works for most users but breaks for forks/custom setups
han commented 2026-04-06 02:55:19 +02:00
Copy Link

I am thinking of the config should be in each repository. but we can always have default config that applicable to every repository as long as not being override. what do you think?

I am thinking of the config should be in each repository. but we can always have default config that applicable to every repository as long as not being override. what do you think?
shoko added the ready label 2026-04-07 08:55:25 +02:00
shoko commented 2026-04-08 08:13:56 +02:00
Author
Owner
Copy Link

Implemented in PR #257: #257

Implemented in PR #257: https://git.fbrns.co/shoko/kugetsu/pulls/257
shoko closed this issue 2026-04-08 08:22:10 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.2.x-only
Available only in 0.2.x, not backportable
 0.3.x-only
Available only in 0.3.x, not backportable
 backport
Backport compatible - can merge to 0.1.x
 blocked
Issue needs clarification/discussion before it can be worked on
 bug
Bug report
 critical
Critical - blocking parallel work
 feature
New feature
 foundation
Foundation work for 0.2.x
 high
High priority - workflow improvements
 meta
Meta issue tracking multiple issues
 need-review
PR needs review before merge
 parallelization
Issues related to parallelization
 ready
Issue is clear and ready to be implemented/delegated
 ready-to-merge
PR approved and ready to merge
 task-delegation
Issues related to task-delegation
No Label ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?