shoko/kugetsu
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix(queue-daemon): call kugetsu_add_notification from bash instead of os.system() #167

New Issue
Closed
opened 2026-04-06 02:31:34 +02:00 by shoko · 0 comments
shoko commented 2026-04-06 02:31:34 +02:00
Owner
Copy Link

Problem

When update_queue_item_state() sets state to 'completed' or 'error' in kugetsu-index.sh, it tries to call kugetsu_add_notification via os.system():

This fails silently because os.system() spawns a NEW subprocess, and bash functions are not visible to child processes. kugetsu_add_notification is a bash function, not an executable command.

Impact

  • task_completed notification never fires
  • task_error notification never fires
  • task_queued works fine (called directly from bash)

Root Cause

os.system() creates a new shell subprocess that cannot access bash functions defined in the parent shell.

Expected Fix

Call kugetsu_add_notification directly from bash in update_queue_item_state(), not via os.system(). The function is available since kugetsu-index.sh is sourced before update_queue_item_state is called.

Alternative: Make notification a standalone script that can be called via PATH.

Severity

High - Notifications broken for completed/error states

## Problem When update_queue_item_state() sets state to 'completed' or 'error' in kugetsu-index.sh, it tries to call kugetsu_add_notification via os.system(): This fails silently because os.system() spawns a NEW subprocess, and bash functions are not visible to child processes. kugetsu_add_notification is a bash function, not an executable command. ## Impact - task_completed notification never fires - task_error notification never fires - task_queued works fine (called directly from bash) ## Root Cause os.system() creates a new shell subprocess that cannot access bash functions defined in the parent shell. ## Expected Fix Call kugetsu_add_notification directly from bash in update_queue_item_state(), not via os.system(). The function is available since kugetsu-index.sh is sourced before update_queue_item_state is called. Alternative: Make notification a standalone script that can be called via PATH. ## Severity High - Notifications broken for completed/error states
shoko closed this issue 2026-04-06 02:35:37 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.2.x-only
Available only in 0.2.x, not backportable
 0.3.x-only
Available only in 0.3.x, not backportable
 backport
Backport compatible - can merge to 0.1.x
 blocked
Issue needs clarification/discussion before it can be worked on
 bug
Bug report
 critical
Critical - blocking parallel work
 feature
New feature
 foundation
Foundation work for 0.2.x
 high
High priority - workflow improvements
 meta
Meta issue tracking multiple issues
 need-review
PR needs review before merge
 parallelization
Issues related to parallelization
 ready
Issue is clear and ready to be implemented/delegated
 ready-to-merge
PR approved and ready to merge
 task-delegation
Issues related to task-delegation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?