extract_issue_ref_from_message misparses /issues/ URLs — drops instance #177

New Issue

shoko · 2026-04-06T04:39:53+02:00

shoko commented

2026-04-06 04:39:53 +02:00

Summary

extract_issue_ref_from_message() in kugetsu-session.sh incorrectly parses full URLs containing /issues/. The instance prefix is dropped and /issues/ becomes the repo field.

Affected Code

File: kugetsu-session.sh, extract_issue_ref_from_message() (lines 159-167)

The sed pipeline drops the instance when cutting from field 2:

local path=$(echo "$url" | sed 's|https\?://||' | cut -d'/' -f2-)
local instance=$(echo "$path" | cut -d'/' -f1)  # WRONG
local owner=$(echo "$path" | cut -d'/' -f2)    # WRONG
local repo=$(echo "$path" | cut -d'/' -f3)       # WRONG

For URL https://git.fbrns.co/shoko/kugetsu/issues/158:

After sed: git.fbrns.co/shoko/kugetsu/issues/158
After cut -f2-: shoko/kugetsu/issues/158 (4 fields — instance dropped)

Then:

instance = shoko (should be git.fbrns.co)
owner = kugetsu (should be shoko)
repo = issues (should be kugetsu)
num = 158 (correct)

Result: shoko/kugetsu/issues#158 — invalid format, 4 segments before #.

Expected

Input: https://git.fbrns.co/shoko/kugetsu/issues/158
Output: git.fbrns.co/shoko/kugetsu#158

Fix

Count from the end since URL structure after instance is always owner/repo/issues/NUMBER:

local path="${url#http://}"
path="${path#https://}"
local instance=$(echo "$path" | cut -d'/' -f1)
local owner=$(echo "$path" | cut -d'/' -f2)
local repo=$(echo "$path" | cut -d'/' -f3)
local num=$(echo "$path" | grep -oE '[0-9]+$')

Reproduction

bash -c '
source kugetsu-session.sh
msg="https://git.fbrns.co/shoko/kugetsu/issues/158 — test"
result=$(extract_issue_ref_from_message "$msg")
echo "$result"
'
# Output: shoko/kugetsu/issues#158
# Expected: git.fbrns.co/shoko/kugetsu#158

Impact

Every delegated task fails immediately. Malformed issue_ref reaches cmd_start where validate_issue_ref rejects it (expects 3 segments, gets 4) and task is marked error. This is the only remaining blocker for queue-based delegation working.

## Summary `extract_issue_ref_from_message()` in `kugetsu-session.sh` incorrectly parses full URLs containing `/issues/`. The instance prefix is dropped and `/issues/` becomes the repo field. ## Affected Code **File:** `kugetsu-session.sh`, `extract_issue_ref_from_message()` (lines 159-167) The sed pipeline drops the instance when cutting from field 2: ```bash local path=$(echo "$url" | sed 's|https\?://||' | cut -d'/' -f2-) local instance=$(echo "$path" | cut -d'/' -f1) # WRONG local owner=$(echo "$path" | cut -d'/' -f2) # WRONG local repo=$(echo "$path" | cut -d'/' -f3) # WRONG ``` For URL `https://git.fbrns.co/shoko/kugetsu/issues/158`: After sed: `git.fbrns.co/shoko/kugetsu/issues/158` After cut -f2-: `shoko/kugetsu/issues/158` (4 fields — instance dropped) Then: - instance = `shoko` (should be `git.fbrns.co`) - owner = `kugetsu` (should be `shoko`) - repo = `issues` (should be `kugetsu`) - num = `158` (correct) Result: `shoko/kugetsu/issues#158` — invalid format, 4 segments before #. ## Expected Input: `https://git.fbrns.co/shoko/kugetsu/issues/158` Output: `git.fbrns.co/shoko/kugetsu#158` ## Fix Count from the end since URL structure after instance is always owner/repo/issues/NUMBER: ```bash local path="${url#http://}" path="${path#https://}" local instance=$(echo "$path" | cut -d'/' -f1) local owner=$(echo "$path" | cut -d'/' -f2) local repo=$(echo "$path" | cut -d'/' -f3) local num=$(echo "$path" | grep -oE '[0-9]+$') ``` ## Reproduction ``` bash -c ' source kugetsu-session.sh msg="https://git.fbrns.co/shoko/kugetsu/issues/158 — test" result=$(extract_issue_ref_from_message "$msg") echo "$result" ' # Output: shoko/kugetsu/issues#158 # Expected: git.fbrns.co/shoko/kugetsu#158 ``` ## Impact Every delegated task fails immediately. Malformed issue_ref reaches cmd_start where validate_issue_ref rejects it (expects 3 segments, gets 4) and task is marked error. This is the only remaining blocker for queue-based delegation working.

shoko closed this issue

2026-04-06 07:16:28 +02:00

Sign in to join this conversation.

Branches Tags

main

fix/issue-254

fix/issue-252

fix/issue-248

fix/issue-246

fix/issue-165

fix/issue-158

fix/issue-244

fix/issue-121

fix/issue-119

fix/issue-166

fix/issue-229-pr-conflict-check

fix/issue-212

fix/issue-229-user-message-with-base-workflow

fix/issue-229-ensure-session-worktree-bug

fix/issue-168

fix/issue-225-cmd-continue-message-truncation

fix/issue-223-pr-creation-instructions

fix/issue-220-pm-context-enhancement

fix/issue-210-msg-file-race-condition

fix/issue-207-queue-daemon-set-debug-mode

fix/issue-message-encoding

fix/issue-118

fix/issue-daemon-worktree-session-handling

fix/issue-write-index-quoting

fix/issue-cmd-destroy-unbound-var

fix/issue-daemon-worktree-path-fix

fix/issue-syntax-error-372

fix/issue-187-start-forks-agent

fix/issue-185-worktree-wrong-directory

fix/issue-183-destroy-base-requires-target

fix/issue-181-get-repo-url-strips-user-org

fix/issue-179-worktree-path-doubled

fix/issue-176-extract-issue-ref

fix/issue-174-queue-daemon-crashes

fix/issue-172-init-script-wrong-session-ids

fix/issue-170-duplicate-update-queue

fix/issue-167-notification-bash

fix/issue-156-queue-fixes

fix/issue-155-queue-list-json

fix/issue-160-gitea-token-from-pm-agent

fix/issue-156

fix/issue-150

fix/issue-116-modularize-script

fix/issue-120

fix/issue-144-parse-issue-ref-format-v2

fix/issue-queue-daemon-excess-agents

fix/issue-142-process-queue-missing-parens

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shoko/kugetsu#177