shoko/kugetsu
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix: session ID collision in cmd_start + delegate issue ref extraction #82

Closed
shoko wants to merge 0 commits from fix/issue-81-session-id-collision into main
pull from: fix/issue-81-session-id-collision
merge into: shoko:main
Conversation 1 Commits - Files Changed -
shoko commented 2026-04-02 01:04:39 +02:00
Owner
Copy Link

Summary

Fixes two bugs in issue #81:

  1. Session ID collision: When cmd_start detects newly created sessions after forking, it now excludes both base_session_id AND pm_agent_session_id from detection.

  2. Delegate issue ref extraction: cmd_delegate now extracts issue refs from messages and calls cmd_start directly when an issue ref is found.

  3. GITEA_TOKEN pass-through: Passes GITEA_TOKEN environment variable to opencode run.

Changes

  • extract_issue_ref_from_message(): New function to parse issue refs
  • cmd_delegate(): Now calls cmd_start when issue ref is found
  • cmd_start(): Session detection now excludes pm_agent_session_id

Fixes #81

## Summary Fixes two bugs in issue #81: 1. **Session ID collision**: When `cmd_start` detects newly created sessions after forking, it now excludes both `base_session_id` AND `pm_agent_session_id` from detection. 2. **Delegate issue ref extraction**: `cmd_delegate` now extracts issue refs from messages and calls `cmd_start` directly when an issue ref is found. 3. **GITEA_TOKEN pass-through**: Passes `GITEA_TOKEN` environment variable to `opencode run`. ## Changes - `extract_issue_ref_from_message()`: New function to parse issue refs - `cmd_delegate()`: Now calls `cmd_start` when issue ref is found - `cmd_start()`: Session detection now excludes pm_agent_session_id Fixes #81
shoko added 1 commit 2026-04-02 01:04:40 +02:00
fix: session ID collision in cmd_start + delegate issue ref extraction 0a2baf99d5 
- Fix session ID detection in cmd_start to exclude pm_agent_session_id
  (prevents forked sessions from getting same ID as pm-agent)
- Add extract_issue_ref_from_message function for parsing issue refs
  from short format (git.fbrns.co/user/repo#123) or URLs
- Update cmd_delegate to call cmd_start when issue ref is found
- Pass GITEA_TOKEN to opencode run for API access
- Fixes #81
shoko force-pushed fix/issue-81-session-id-collision from 0a2baf99d5 to ae99f86f9d 2026-04-02 01:36:00 +02:00 Compare
shoko added 1 commit 2026-04-02 01:43:19 +02:00
fix: use array-based session detection for robust concurrent fork handling 3df99d571f 
Replace string-based session comparison with array-based approach:

- Store before_sessions in an array instead of pipe-delimited string
- This is more robust against word-splitting issues in bash
- Skip base_session_id and pm_agent_session_id explicitly
- Compare each after-session against the before array

This approach is more reliable when multiple agents fork concurrently
because it properly compares each session ID individually rather than
relying on regex matching in a string.

Fixes #81
shoko added 1 commit 2026-04-02 02:07:21 +02:00
docs: add opencode session internals documentation 1f001fd057 
Document findings from database investigation:
- Session table schema with all fields explained
- Session ID format and generation (unique, no duplicates)
- Parent-child relationships for forked sessions
- Session detection logic used by kugetsu
- Permission structure and common issues
- SQL queries for debugging session problems
- Known issues and solutions (from #81, #36)

This document helps future debugging of session-related issues
without having to investigate opencode internals directly.
han approved these changes 2026-04-02 02:12:59 +02:00
han left a comment
First-time contributor
Copy Link

lgtm

lgtm
shoko closed this pull request 2026-04-02 02:14:01 +02:00
shoko deleted branch fix/issue-81-session-id-collision 2026-04-02 02:14:01 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
0.2.x-only
Available only in 0.2.x, not backportable
 0.3.x-only
Available only in 0.3.x, not backportable
 backport
Backport compatible - can merge to 0.1.x
 blocked
Issue needs clarification/discussion before it can be worked on
 bug
Bug report
 critical
Critical - blocking parallel work
 feature
New feature
 foundation
Foundation work for 0.2.x
 high
High priority - workflow improvements
 meta
Meta issue tracking multiple issues
 need-review
PR needs review before merge
 parallelization
Issues related to parallelization
 ready
Issue is clear and ready to be implemented/delegated
 ready-to-merge
PR approved and ready to merge
 task-delegation
Issues related to task-delegation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#82
Delete Branch "fix/issue-81-session-id-collision"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?