shoko/randebu
1
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

P2: Duplicate AveCloudClient implementations #29

New Issue
Closed
opened 2026-04-09 07:12:05 +02:00 by shoko · 0 comments
shoko commented 2026-04-09 07:12:05 +02:00
Owner
Copy Link

Problem

Two different AveCloudClient classes exist with different methods:

File Methods
services/ave/client.py Full: get_tokens, get_batch_prices, get_token_details, get_klines, get_trending_tokens, get_token_risk, get_chain_quote, get_chain_swap
services/backtest/ave_client.py Limited: get_klines, get_token_price, get_batch_prices

The simulate engine imports from the wrong (limited) location:

from ..backtest.ave_client import AveCloudClient  # Limited version!

Solution

Consolidate into a single AveCloudClient class in services/ave/client.py.

Changes Required

  1. Review services/ave/client.py - ensure it has all needed methods
  2. Update services/simulate/engine.py - import from correct location
  3. Delete services/backtest/ave_client.py

Acceptance Criteria

  • Single AveCloudClient class exists in services/ave/client.py
  • All methods needed by backtest and simulate engines are available
  • Simulate engine imports from correct location
  • services/backtest/ave_client.py is deleted
## Problem Two different `AveCloudClient` classes exist with different methods: | File | Methods | |------|---------| | `services/ave/client.py` | Full: get_tokens, get_batch_prices, get_token_details, get_klines, get_trending_tokens, get_token_risk, get_chain_quote, get_chain_swap | | `services/backtest/ave_client.py` | Limited: get_klines, get_token_price, get_batch_prices | The simulate engine imports from the **wrong** (limited) location: ```python from ..backtest.ave_client import AveCloudClient # Limited version! ``` ## Solution Consolidate into a single AveCloudClient class in `services/ave/client.py`. ### Changes Required 1. Review `services/ave/client.py` - ensure it has all needed methods 2. Update `services/simulate/engine.py` - import from correct location 3. Delete `services/backtest/ave_client.py` ## Acceptance Criteria - [ ] Single AveCloudClient class exists in `services/ave/client.py` - [ ] All methods needed by backtest and simulate engines are available - [ ] Simulate engine imports from correct location - [ ] `services/backtest/ave_client.py` is deleted
shoko closed this issue 2026-04-09 12:11:59 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI/ML
AI or ML related tasks
 backend
Backend related tasks
 enhancement
Feature or enhancement
 frontend
Frontend related tasks
 infrastructure
Infrastructure or deployment
 meta
Meta issue for tracking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/randebu#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?