Merge pull request 'feat: add multi-ID delete support with per-ID results' (#63) from fix/issue-47 into main

- Add delete_bounties method to BountyService that returns individual
  results per bounty ID (deleted, not_found, permission_denied)
- Update cmd_delete to accept multiple IDs and show per-ID messages
- Add tests for delete_bounties

Example output:
/delete 1 2 3
✅ Bounty #1 deleted.
✅ Bounty #2 deleted.
⛔ Bounty #3 not found.

Fixes #47

apps/telegram-bot/commands.py

@@ -210,32 +210,34 @@ cmd_edit = cmd_update
 async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
     args = extract_args(update.message.text)
     if not args:
-        await update.message.reply_text("Usage: /delete <bounty_id>")
+        await update.message.reply_text("Usage: /delete <bounty_id> [bounty_id ...]")
         return
 
     try:
-        bounty_id = int(args[0])
+        bounty_ids = [int(arg) for arg in args]
     except ValueError:
-        await update.message.reply_text("Invalid bounty ID.")
+        await update.message.reply_text("Invalid bounty ID(s).")
         return
 
     user_id = get_user_id(update)
     room_id = get_room_id(update)
 
-    try:
+    results = BOUNTY_SERVICE.delete_bounties(
-        success = BOUNTY_SERVICE.delete_bounty(
+        room_id=room_id,
-            room_id=room_id,
+        bounty_ids=bounty_ids,
-            bounty_id=bounty_id,
+        user_id=user_id,
-            user_id=user_id,
+    )
-        )
-    except PermissionError as e:
-        await update.message.reply_text(f"⛔ {e}")
-        return
 
-    if success:
+    lines = []
-        await update.message.reply_text(f"✅ Bounty #{bounty_id} deleted.")
+    for bounty_id, result in results.items():
-    else:
+        if result == "deleted":
-        await update.message.reply_text("Bounty not found.")
+            lines.append(f"✅ Bounty #{bounty_id} deleted.")
+        elif result == "not_found":
+            lines.append(f"⛔ Bounty #{bounty_id} not found.")
+        elif result == "permission_denied":
+            lines.append(f"⛔ Bounty #{bounty_id} - only admins can delete.")
+
+    await update.message.reply_text("\n".join(lines))
 
 
 async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:

cli/main.py

@@ -127,40 +127,6 @@ def cmd_delete(args):
         sys.exit(1)
 
 
-def cmd_recover(args):
-    """List or recover soft-deleted bounties."""
-    bounty_service, _ = create_services()
-    room_id = args.group_id or args.user_id
-    user_id = args.user_id or 0
-
-    if not args.bounty_ids:
-        deleted = bounty_service.list_deleted_bounties(room_id)
-        if not deleted:
-            print("No recoverable bounties")
-            return
-        print("Recoverable bounties:")
-        for b in deleted:
-            from datetime import datetime
-
-            deleted_str = datetime.fromtimestamp(b.deleted_at).strftime("%d %b %Y")
-            print(f"  [#{b.id}] {b.text or '(no text)'} | Deleted {deleted_str}")
-        return
-
-    if not bounty_service.is_admin(room_id, user_id):
-        print("Error: Only admins can recover bounties.", file=sys.stderr)
-        sys.exit(1)
-
-    for bounty_id in args.bounty_ids:
-        try:
-            success, msg = bounty_service.recover_bounty(
-                room_id=room_id, bounty_id=bounty_id, user_id=user_id
-            )
-            print(msg)
-        except PermissionError as e:
-            print(f"Error: {e}", file=sys.stderr)
-            sys.exit(1)
-
-
 def cmd_track(args):
     """Track a bounty."""
     _, tracking_service = create_services()
@@ -230,9 +196,6 @@ def main():
     parser_untrack = subparsers.add_parser("untrack", help="Untrack a bounty")
     parser_untrack.add_argument("bounty_id", type=int, help="Bounty ID to untrack")
 
-    parser_recover = subparsers.add_parser("recover", help="List or recover soft-deleted bounties")
-    parser_recover.add_argument("bounty_ids", nargs="*", type=int, help="Bounty ID(s) to recover (optional)")
-
     for sp in [
         parser_add,
         parser_list,
@@ -241,7 +204,6 @@ def main():
         parser_delete,
         parser_track,
         parser_untrack,
-        parser_recover,
     ]:
         sp.add_argument(
             "--group-id", type=int, help="Group context (use group room ID)"
@@ -260,7 +222,7 @@ def main():
         print("Error: either --group-id or --user-id is required", file=sys.stderr)
         sys.exit(1)
 
-    if args.command in ("add", "list", "my", "update", "delete", "recover"):
+    if args.command in ("add", "list", "my", "update", "delete"):
         if not (args.group_id or args.user_id):
             print("Error: --group-id or --user-id required", file=sys.stderr)
             sys.exit(1)
@@ -276,7 +238,6 @@ def main():
         "delete": cmd_delete,
         "track": cmd_track,
         "untrack": cmd_untrack,
-        "recover": cmd_recover,
     }
 
     if args.command in command_map:

core/services.py

@@ -210,32 +210,30 @@ class BountyService:
         self._storage.update_bounty(room_id, bounty)
         return True
 
-    def recover_bounty(
+    def delete_bounties(
-        self, room_id: int, bounty_id: int, user_id: int
+        self, room_id: int, bounty_ids: list[int], user_id: int
-    ) -> tuple[bool, str]:
+    ) -> dict[int, str]:
-        """Recover a soft-deleted bounty. Only admins can recover.
+        """Soft delete multiple bounties. Only admins can delete.
 
-        Returns (success, message) tuple.
+        Returns a dict mapping bounty_id to result:
+        - "deleted": Successfully soft-deleted
+        - "not_found": Bounty does not exist
+        - "permission_denied": User is not admin
         """
-        all_bounties = self._storage.list_all_bounties(room_id, include_deleted=True)
+        results = {}
-        bounty = None
+        for bounty_id in bounty_ids:
-        for b in all_bounties:
+            bounty = self._storage.get_bounty(room_id, bounty_id)
-            if b.id == bounty_id:
+            if not bounty:
-                bounty = b
+                results[bounty_id] = "not_found"
-                break
+                continue
+            if not self.is_admin(room_id, user_id):
+                results[bounty_id] = "permission_denied"
+                continue
 
-        if not bounty:
+            bounty.deleted_at = int(time.time())
-            return False, f"Bounty #{bounty_id} not found."
+            self._storage.update_bounty(room_id, bounty)
-
+            results[bounty_id] = "deleted"
-        if bounty.deleted_at is None:
+        return results
-            return False, f"Bounty #{bounty_id} is not deleted."
-
-        if not self.is_admin(room_id, user_id):
-            raise PermissionError("Only admins can recover bounties.")
-
-        bounty.deleted_at = None
-        self._storage.update_bounty(room_id, bounty)
-        return True, f"Recovered bounty #{bounty_id}."
 
 
 class TrackingService:

tests/test_services.py

@@ -210,6 +210,53 @@ class TestBountyService:
         result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
         assert result is False
 
+    def test_delete_bounties_multiple_success(self):
+        """Test delete_bounties soft deletes multiple bounties."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="First"
+        )
+        b2 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Second"
+        )
+        b3 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Third"
+        )
+        results = self.service.delete_bounties(
+            -1001, [b1.id, b2.id, b3.id], self.admin_user_id
+        )
+        assert results == {b1.id: "deleted", b2.id: "deleted", b3.id: "deleted"}
+        assert self.service.get_bounty(-1001, b1.id) is None
+        assert self.service.get_bounty(-1001, b2.id) is None
+        assert self.service.get_bounty(-1001, b3.id) is None
+
+    def test_delete_bounties_mixed_results(self):
+        """Test delete_bounties returns individual results per ID."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Exists"
+        )
+        results = self.service.delete_bounties(
+            -1001, [b1.id, 999, 888], self.admin_user_id
+        )
+        assert results == {b1.id: "deleted", 999: "not_found", 888: "not_found"}
+
+    def test_delete_bounties_permission_denied(self):
+        """Test delete_bounties returns permission_denied for non-admin."""
+        b1 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="First"
+        )
+        b2 = self.service.add_bounty(
+            room_id=-1001, user_id=self.admin_user_id, text="Second"
+        )
+        results = self.service.delete_bounties(
+            -1001,
+            [b1.id, b2.id],
+            999,  # non-admin user
+        )
+        assert results == {b1.id: "permission_denied", b2.id: "permission_denied"}
+        # Bounties should not be deleted
+        assert self.service.get_bounty(-1001, b1.id) is not None
+        assert self.service.get_bounty(-1001, b2.id) is not None
+
 
 class TestTrackingService:
     """Unit tests for TrackingService."""