Compare commits
5 Commits
fix/issue-
...
fix/issue-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f521a682c5 | ||
| 015df15bd5 | |||
|
|
eed3ab33ae | ||
| bd2627efe9 | |||
|
|
8069ed6465 |
@@ -14,6 +14,7 @@ from commands import (
|
||||
cmd_help,
|
||||
cmd_my,
|
||||
cmd_start,
|
||||
cmd_timezone,
|
||||
cmd_track,
|
||||
cmd_untrack,
|
||||
cmd_update,
|
||||
@@ -41,6 +42,7 @@ def build_app() -> Application:
|
||||
app.add_handler(CommandHandler("delete", cmd_delete))
|
||||
app.add_handler(CommandHandler("track", cmd_track))
|
||||
app.add_handler(CommandHandler("untrack", cmd_untrack))
|
||||
app.add_handler(CommandHandler("timezone", cmd_timezone))
|
||||
|
||||
app.add_handler(MessageHandler(filters.COMMAND, cmd_help))
|
||||
|
||||
@@ -56,6 +58,7 @@ async def post_init(app: Application) -> None:
|
||||
("edit", "Edit a bounty"),
|
||||
("track", "Track a bounty"),
|
||||
("untrack", "Stop tracking"),
|
||||
("timezone", "Get/set room timezone"),
|
||||
("help", "Show help"),
|
||||
]
|
||||
)
|
||||
|
||||
@@ -1,8 +1,10 @@
|
||||
"""Telegram command handlers for JIGAIDO - Thin wrappers around core services."""
|
||||
|
||||
import time
|
||||
from datetime import datetime
|
||||
from functools import wraps
|
||||
from typing import Optional
|
||||
from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
|
||||
|
||||
import dateparser
|
||||
from telegram import Update
|
||||
@@ -19,6 +21,34 @@ TRACKING_SERVICE = TrackingService(TRACKING_STORAGE, ROOM_STORAGE)
|
||||
TELEGRAM_BOT_USERNAME = "your_bot_username"
|
||||
|
||||
|
||||
def format_due_date(due_date_ts: int | None, timezone_str: str) -> str:
|
||||
"""Format due date as human-readable with timezone.
|
||||
|
||||
Examples:
|
||||
No due date: (none shown)
|
||||
Date only: 4 April 2026
|
||||
Date + time: 4 April 2026 14:30
|
||||
With timezone: 4 April 2026 14:30 (Asia/Jakarta)
|
||||
"""
|
||||
if not due_date_ts:
|
||||
return ""
|
||||
|
||||
try:
|
||||
tz = ZoneInfo(timezone_str)
|
||||
except (KeyError, ZoneInfoNotFoundError):
|
||||
tz = ZoneInfo("UTC")
|
||||
|
||||
dt = datetime.fromtimestamp(due_date_ts, tz=tz)
|
||||
|
||||
date_str = dt.strftime("%-d %B %Y")
|
||||
|
||||
if dt.hour != 0 or dt.minute != 0:
|
||||
date_str += f" {dt.strftime('%H:%M')}"
|
||||
date_str += f" ({timezone_str})"
|
||||
|
||||
return date_str
|
||||
|
||||
|
||||
def extract_args(text: str) -> list[str]:
|
||||
if not text:
|
||||
return []
|
||||
@@ -48,7 +78,7 @@ def parse_args(args: list[str]) -> tuple[Optional[str], Optional[str], Optional[
|
||||
return text, link, due_date_ts
|
||||
|
||||
|
||||
def format_bounty(b, show_id: bool = True) -> str:
|
||||
def format_bounty(b, show_id: bool = True, room_id: int | None = None) -> str:
|
||||
parts = []
|
||||
if show_id:
|
||||
parts.append(f"[#{b.id}]")
|
||||
@@ -57,7 +87,11 @@ def format_bounty(b, show_id: bool = True) -> str:
|
||||
if b.link:
|
||||
parts.append(f"🔗 {b.link}")
|
||||
if b.due_date_ts:
|
||||
due_str = time.strftime("%Y-%m-%d", time.localtime(b.due_date_ts))
|
||||
timezone_str = "UTC"
|
||||
if room_id is not None:
|
||||
timezone_str = BOUNTY_SERVICE.get_timezone(room_id)
|
||||
|
||||
due_str = format_due_date(b.due_date_ts, timezone_str)
|
||||
days_left = (b.due_date_ts - int(time.time())) // 86400
|
||||
if days_left < 0:
|
||||
parts.append(f"⏰ {due_str} (OVERDUE)")
|
||||
@@ -101,7 +135,7 @@ async def cmd_bounty(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
await update.message.reply_text("No bounties yet.")
|
||||
return
|
||||
|
||||
lines = [format_bounty(b, show_id=True) for b in bounties]
|
||||
lines = [format_bounty(b, show_id=True, room_id=room_id) for b in bounties]
|
||||
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
||||
|
||||
|
||||
@@ -111,6 +145,7 @@ async def cmd_my(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
if is_group(update):
|
||||
group_id = get_group_id(update)
|
||||
bounties = TRACKING_SERVICE.get_tracked_bounties(group_id, user_id)
|
||||
room_id = group_id
|
||||
else:
|
||||
room_id = get_room_id(update)
|
||||
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
||||
@@ -124,7 +159,7 @@ async def cmd_my(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
await update.message.reply_text(msg)
|
||||
return
|
||||
|
||||
lines = [format_bounty(b, show_id=True) for b in bounties]
|
||||
lines = [format_bounty(b, show_id=True, room_id=room_id) for b in bounties]
|
||||
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
||||
|
||||
|
||||
@@ -155,7 +190,8 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
|
||||
due_str = ""
|
||||
if due_date_ts:
|
||||
due_str = f" | Due: {time.strftime('%Y-%m-%d', time.localtime(due_date_ts))}"
|
||||
timezone_str = BOUNTY_SERVICE.get_timezone(room_id)
|
||||
due_str = f" | Due: {format_due_date(due_date_ts, timezone_str)}"
|
||||
|
||||
await update.message.reply_text(
|
||||
f"✅ Bounty added (#{bounty.id}){due_str}",
|
||||
@@ -210,32 +246,34 @@ cmd_edit = cmd_update
|
||||
async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
args = extract_args(update.message.text)
|
||||
if not args:
|
||||
await update.message.reply_text("Usage: /delete <bounty_id>")
|
||||
await update.message.reply_text("Usage: /delete <bounty_id> [bounty_id ...]")
|
||||
return
|
||||
|
||||
try:
|
||||
bounty_id = int(args[0])
|
||||
bounty_ids = [int(arg) for arg in args]
|
||||
except ValueError:
|
||||
await update.message.reply_text("Invalid bounty ID.")
|
||||
await update.message.reply_text("Invalid bounty ID(s).")
|
||||
return
|
||||
|
||||
user_id = get_user_id(update)
|
||||
room_id = get_room_id(update)
|
||||
|
||||
try:
|
||||
success = BOUNTY_SERVICE.delete_bounty(
|
||||
results = BOUNTY_SERVICE.delete_bounties(
|
||||
room_id=room_id,
|
||||
bounty_id=bounty_id,
|
||||
bounty_ids=bounty_ids,
|
||||
user_id=user_id,
|
||||
)
|
||||
except PermissionError as e:
|
||||
await update.message.reply_text(f"⛔ {e}")
|
||||
return
|
||||
|
||||
if success:
|
||||
await update.message.reply_text(f"✅ Bounty #{bounty_id} deleted.")
|
||||
else:
|
||||
await update.message.reply_text("Bounty not found.")
|
||||
lines = []
|
||||
for bounty_id, result in results.items():
|
||||
if result == "deleted":
|
||||
lines.append(f"✅ Bounty #{bounty_id} deleted.")
|
||||
elif result == "not_found":
|
||||
lines.append(f"⛔ Bounty #{bounty_id} not found.")
|
||||
elif result == "permission_denied":
|
||||
lines.append(f"⛔ Bounty #{bounty_id} - only admins can delete.")
|
||||
|
||||
await update.message.reply_text("\n".join(lines))
|
||||
|
||||
|
||||
async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
@@ -321,7 +359,37 @@ async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
"/delete <id> — delete bounty\n"
|
||||
"/track <id> — track a bounty (groups only)\n"
|
||||
"/untrack <id> — stop tracking (groups only)\n"
|
||||
"/timezone [tz] — get/set room timezone (admin only)\n"
|
||||
"/start — re-initialize\n"
|
||||
"/help — this message",
|
||||
disable_web_page_preview=True,
|
||||
)
|
||||
|
||||
|
||||
async def cmd_timezone(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||
args = extract_args(update.message.text)
|
||||
room_id = get_room_id(update)
|
||||
user_id = get_user_id(update)
|
||||
|
||||
if not args:
|
||||
current_tz = BOUNTY_SERVICE.get_timezone(room_id)
|
||||
await update.message.reply_text(f"Current timezone: {current_tz}")
|
||||
return
|
||||
|
||||
timezone_str = args[0]
|
||||
|
||||
try:
|
||||
ZoneInfo(timezone_str)
|
||||
except (KeyError, ZoneInfoNotFoundError):
|
||||
await update.message.reply_text(
|
||||
"⛔ Invalid timezone. Use IANA format (e.g., Asia/Jakarta)"
|
||||
)
|
||||
return
|
||||
|
||||
try:
|
||||
BOUNTY_SERVICE.set_timezone(room_id, timezone_str, user_id)
|
||||
except PermissionError as e:
|
||||
await update.message.reply_text(f"⛔ {e}")
|
||||
return
|
||||
|
||||
await update.message.reply_text(f"✅ Timezone set to {timezone_str}.")
|
||||
|
||||
41
cli/main.py
41
cli/main.py
@@ -127,40 +127,6 @@ def cmd_delete(args):
|
||||
sys.exit(1)
|
||||
|
||||
|
||||
def cmd_recover(args):
|
||||
"""List or recover soft-deleted bounties."""
|
||||
bounty_service, _ = create_services()
|
||||
room_id = args.group_id or args.user_id
|
||||
user_id = args.user_id or 0
|
||||
|
||||
if not args.bounty_ids:
|
||||
deleted = bounty_service.list_deleted_bounties(room_id)
|
||||
if not deleted:
|
||||
print("No recoverable bounties")
|
||||
return
|
||||
print("Recoverable bounties:")
|
||||
for b in deleted:
|
||||
from datetime import datetime
|
||||
|
||||
deleted_str = datetime.fromtimestamp(b.deleted_at).strftime("%d %b %Y")
|
||||
print(f" [#{b.id}] {b.text or '(no text)'} | Deleted {deleted_str}")
|
||||
return
|
||||
|
||||
if not bounty_service.is_admin(room_id, user_id):
|
||||
print("Error: Only admins can recover bounties.", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
|
||||
for bounty_id in args.bounty_ids:
|
||||
try:
|
||||
success, msg = bounty_service.recover_bounty(
|
||||
room_id=room_id, bounty_id=bounty_id, user_id=user_id
|
||||
)
|
||||
print(msg)
|
||||
except PermissionError as e:
|
||||
print(f"Error: {e}", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
|
||||
|
||||
def cmd_track(args):
|
||||
"""Track a bounty."""
|
||||
_, tracking_service = create_services()
|
||||
@@ -230,9 +196,6 @@ def main():
|
||||
parser_untrack = subparsers.add_parser("untrack", help="Untrack a bounty")
|
||||
parser_untrack.add_argument("bounty_id", type=int, help="Bounty ID to untrack")
|
||||
|
||||
parser_recover = subparsers.add_parser("recover", help="List or recover soft-deleted bounties")
|
||||
parser_recover.add_argument("bounty_ids", nargs="*", type=int, help="Bounty ID(s) to recover (optional)")
|
||||
|
||||
for sp in [
|
||||
parser_add,
|
||||
parser_list,
|
||||
@@ -241,7 +204,6 @@ def main():
|
||||
parser_delete,
|
||||
parser_track,
|
||||
parser_untrack,
|
||||
parser_recover,
|
||||
]:
|
||||
sp.add_argument(
|
||||
"--group-id", type=int, help="Group context (use group room ID)"
|
||||
@@ -260,7 +222,7 @@ def main():
|
||||
print("Error: either --group-id or --user-id is required", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
|
||||
if args.command in ("add", "list", "my", "update", "delete", "recover"):
|
||||
if args.command in ("add", "list", "my", "update", "delete"):
|
||||
if not (args.group_id or args.user_id):
|
||||
print("Error: --group-id or --user-id required", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
@@ -276,7 +238,6 @@ def main():
|
||||
"delete": cmd_delete,
|
||||
"track": cmd_track,
|
||||
"untrack": cmd_untrack,
|
||||
"recover": cmd_recover,
|
||||
}
|
||||
|
||||
if args.command in command_map:
|
||||
|
||||
@@ -210,32 +210,30 @@ class BountyService:
|
||||
self._storage.update_bounty(room_id, bounty)
|
||||
return True
|
||||
|
||||
def recover_bounty(
|
||||
self, room_id: int, bounty_id: int, user_id: int
|
||||
) -> tuple[bool, str]:
|
||||
"""Recover a soft-deleted bounty. Only admins can recover.
|
||||
def delete_bounties(
|
||||
self, room_id: int, bounty_ids: list[int], user_id: int
|
||||
) -> dict[int, str]:
|
||||
"""Soft delete multiple bounties. Only admins can delete.
|
||||
|
||||
Returns (success, message) tuple.
|
||||
Returns a dict mapping bounty_id to result:
|
||||
- "deleted": Successfully soft-deleted
|
||||
- "not_found": Bounty does not exist
|
||||
- "permission_denied": User is not admin
|
||||
"""
|
||||
all_bounties = self._storage.list_all_bounties(room_id, include_deleted=True)
|
||||
bounty = None
|
||||
for b in all_bounties:
|
||||
if b.id == bounty_id:
|
||||
bounty = b
|
||||
break
|
||||
|
||||
results = {}
|
||||
for bounty_id in bounty_ids:
|
||||
bounty = self._storage.get_bounty(room_id, bounty_id)
|
||||
if not bounty:
|
||||
return False, f"Bounty #{bounty_id} not found."
|
||||
|
||||
if bounty.deleted_at is None:
|
||||
return False, f"Bounty #{bounty_id} is not deleted."
|
||||
|
||||
results[bounty_id] = "not_found"
|
||||
continue
|
||||
if not self.is_admin(room_id, user_id):
|
||||
raise PermissionError("Only admins can recover bounties.")
|
||||
results[bounty_id] = "permission_denied"
|
||||
continue
|
||||
|
||||
bounty.deleted_at = None
|
||||
bounty.deleted_at = int(time.time())
|
||||
self._storage.update_bounty(room_id, bounty)
|
||||
return True, f"Recovered bounty #{bounty_id}."
|
||||
results[bounty_id] = "deleted"
|
||||
return results
|
||||
|
||||
|
||||
class TrackingService:
|
||||
|
||||
@@ -210,6 +210,53 @@ class TestBountyService:
|
||||
result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
|
||||
assert result is False
|
||||
|
||||
def test_delete_bounties_multiple_success(self):
|
||||
"""Test delete_bounties soft deletes multiple bounties."""
|
||||
b1 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="First"
|
||||
)
|
||||
b2 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
||||
)
|
||||
b3 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="Third"
|
||||
)
|
||||
results = self.service.delete_bounties(
|
||||
-1001, [b1.id, b2.id, b3.id], self.admin_user_id
|
||||
)
|
||||
assert results == {b1.id: "deleted", b2.id: "deleted", b3.id: "deleted"}
|
||||
assert self.service.get_bounty(-1001, b1.id) is None
|
||||
assert self.service.get_bounty(-1001, b2.id) is None
|
||||
assert self.service.get_bounty(-1001, b3.id) is None
|
||||
|
||||
def test_delete_bounties_mixed_results(self):
|
||||
"""Test delete_bounties returns individual results per ID."""
|
||||
b1 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="Exists"
|
||||
)
|
||||
results = self.service.delete_bounties(
|
||||
-1001, [b1.id, 999, 888], self.admin_user_id
|
||||
)
|
||||
assert results == {b1.id: "deleted", 999: "not_found", 888: "not_found"}
|
||||
|
||||
def test_delete_bounties_permission_denied(self):
|
||||
"""Test delete_bounties returns permission_denied for non-admin."""
|
||||
b1 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="First"
|
||||
)
|
||||
b2 = self.service.add_bounty(
|
||||
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
||||
)
|
||||
results = self.service.delete_bounties(
|
||||
-1001,
|
||||
[b1.id, b2.id],
|
||||
999, # non-admin user
|
||||
)
|
||||
assert results == {b1.id: "permission_denied", b2.id: "permission_denied"}
|
||||
# Bounties should not be deleted
|
||||
assert self.service.get_bounty(-1001, b1.id) is not None
|
||||
assert self.service.get_bounty(-1001, b2.id) is not None
|
||||
|
||||
|
||||
class TestTrackingService:
|
||||
"""Unit tests for TrackingService."""
|
||||
|
||||
Reference in New Issue
Block a user