shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

[Phase 1] Task 10: Cleanup — Remove old/dead code #16

New Issue
Closed
opened 2026-04-02 18:32:30 +02:00 by shoko · 0 comments
shoko commented 2026-04-02 18:32:30 +02:00
Owner
Copy Link

Task 10: Cleanup

Labels: phase-1, cleanup
Dependency: Tasks 7 (#13), 8 (#14)

Goal

Remove old and dead code now that the new architecture is in place.

Tasks

  1. Delete old storage.py

    • File: apps/telegram-bot/storage.py
    • Reason: Replaced by adapters/storage/json_file.py

  2. Delete empty init.py

    • File: apps/telegram-bot/init.py (0 bytes)
    • Reason: Not needed

  3. Delete requirements-dev.txt

    • File: apps/telegram-bot/requirements-dev.txt
    • Reason: Dev deps already in pyproject.toml

  4. Update SPEC.md

    • Reflect the new architecture (core, adapters, CLI)
    • Update command reference to show /edit instead of /update

  5. Update README.md

    • Update project structure to reflect new layout
    • Document CLI usage

  6. Update CONTRIBUTING.md

    • Update development setup if needed

Acceptance Criteria

  • No old storage.py remains
  • No empty init.py in telegram-bot
  • No requirements-dev.txt
  • SPEC.md and README.md are up to date
## Task 10: Cleanup **Labels:** phase-1, cleanup **Dependency:** Tasks 7 (#13), 8 (#14) ### Goal Remove old and dead code now that the new architecture is in place. ### Tasks 1. Delete old storage.py - File: apps/telegram-bot/storage.py - Reason: Replaced by adapters/storage/json_file.py 2. Delete empty __init__.py - File: apps/telegram-bot/__init__.py (0 bytes) - Reason: Not needed 3. Delete requirements-dev.txt - File: apps/telegram-bot/requirements-dev.txt - Reason: Dev deps already in pyproject.toml 4. Update SPEC.md - Reflect the new architecture (core, adapters, CLI) - Update command reference to show /edit instead of /update 5. Update README.md - Update project structure to reflect new layout - Document CLI usage 6. Update CONTRIBUTING.md - Update development setup if needed ### Acceptance Criteria - No old storage.py remains - No empty __init__.py in telegram-bot - No requirements-dev.txt - SPEC.md and README.md are up to date
shoko added the cleanupphase-1 labels 2026-04-02 18:34:45 +02:00
han added a new dependency 2026-04-03 00:33:02 +02:00
#19 feat(core): implement domain dataclasses for issue #5
han removed a dependency 2026-04-03 00:33:06 +02:00
#19 feat(core): implement domain dataclasses for issue #5
shoko closed this issue 2026-04-03 21:09:59 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label cleanup phase-1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#16
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?