shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

fix #16: cleanup - remove old/dead code and update docs #35

Merged
shoko merged 1 commits from fix/issue-16-cleanup into main 2026-04-03 21:09:59 +02:00
Conversation 1 Commits 1 Files Changed 6 +87 -252
shoko commented 2026-04-03 17:13:09 +02:00
Owner
Copy Link

Summary

Cleanup task for issue #16 - removes old/dead code and updates documentation to reflect new hexagonal architecture.

Deleted Files

  • apps/telegram-bot/storage.py - Replaced by adapters/storage/json_file.py
  • apps/telegram-bot/__init__.py - Empty file, not needed
  • apps/telegram-bot/requirements-dev.txt - Dev deps already in pyproject.toml

Documentation Updates

SPEC.md:

  • Reflect new hexagonal architecture (core, adapters, apps)
  • Update directory structure
  • Change /update command to /edit
  • Update storage design section

README.md:

  • Update project structure to reflect new layout
  • Add quick start section

CONTRIBUTING.md:

  • Update development setup
  • Add architecture section
  • Add pytest to test workflow

Acceptance Criteria Met

  • No old storage.py remains
  • No empty init.py in telegram-bot
  • No requirements-dev.txt
  • SPEC.md and README.md are up to date

Closes #16

## Summary Cleanup task for issue #16 - removes old/dead code and updates documentation to reflect new hexagonal architecture. ### Deleted Files - `apps/telegram-bot/storage.py` - Replaced by `adapters/storage/json_file.py` - `apps/telegram-bot/__init__.py` - Empty file, not needed - `apps/telegram-bot/requirements-dev.txt` - Dev deps already in pyproject.toml ### Documentation Updates **SPEC.md:** - Reflect new hexagonal architecture (core, adapters, apps) - Update directory structure - Change `/update` command to `/edit` - Update storage design section **README.md:** - Update project structure to reflect new layout - Add quick start section **CONTRIBUTING.md:** - Update development setup - Add architecture section - Add `pytest` to test workflow ### Acceptance Criteria Met - [x] No old storage.py remains - [x] No empty __init__.py in telegram-bot - [x] No requirements-dev.txt - [x] SPEC.md and README.md are up to date Closes #16
shoko added 1 commit 2026-04-03 17:13:10 +02:00
fix #16: cleanup - remove old/dead code and update docs 99a80b0c62 
- Delete apps/telegram-bot/storage.py (replaced by adapters/storage/json_file.py)
- Delete apps/telegram-bot/__init__.py (empty file)
- Delete apps/telegram-bot/requirements-dev.txt (dev deps in pyproject.toml)
- Update SPEC.md with new hexagonal architecture (core, adapters, apps)
- Update SPEC.md command reference: /update -> /edit
- Update README.md with new project structure and quick start
- Update CONTRIBUTING.md with new architecture and dev setup
han approved these changes 2026-04-03 21:04:45 +02:00
han left a comment
Collaborator
Copy Link

lgtm

lgtm
shoko merged commit 6dc3307e23 into main 2026-04-03 21:09:59 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#35
Delete Branch "fix/issue-16-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?