shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Add core/ports.py - Storage interfaces #20

Merged
shoko merged 3 commits from feat/issue-6-storage-ports into main 2026-04-03 08:58:30 +02:00
Conversation 8 Commits 3 Files Changed 3 +339

3 Commits

Author SHA1 Message Date
shokollm
a237810dd2 Remove ensure_room/ensure_tracking from Protocol - tests prove not needed 
Tests with SimpleRoomStorage and SimpleTrackingStorage (without ensure_*)
show that add_bounty() and track_bounty() work fine without explicit
ensure methods - they create rooms/tracking internally.

This simplifies the Protocol to only essential methods.
 2026-04-03 06:48:52 +00:00
shokollm
43603659de Address PR #20 feedback: 
- Removed PersonalStorage (redundant - RoomStorage handles both via room_id)
- Added ensure_room() and ensure_tracking() methods for explicit creation
- Added @runtime_checkable to Protocols for isinstance checks
- Added tests/test_ports.py with 11 unit tests for storage protocols
 2026-04-02 23:57:49 +00:00
shokollm
5450d12400 Add core/ports.py - Storage interfaces 
Define abstract storage interfaces (Protocols):
- RoomStorage: for room/group bounties (load, save, add/update/delete/get_bounty)
- PersonalStorage: same operations for personal/DM bounties
- TrackingStorage: for tracking data (load, save, track/untrack_bounty)
 2026-04-02 22:40:11 +00:00