shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(core): implement services for issue #8 #25

Closed
shoko wants to merge 2 commits from feat/issue-8-services into main
pull from: feat/issue-8-services
merge into: shoko:main
Conversation 0 Commits 2 Files Changed 2 +358
shoko commented 2026-04-03 10:26:59 +02:00
Owner
Copy Link

Summary

Implement business logic services:

  • RoomBountyService: add_bounty, get_bounty, list_bounties, update_bounty, delete_bounty
  • TrackingService: track_bounty, untrack_bounty, list_tracked

All services orchestrate through storage ports (RoomStorage, TrackingStorage) with no implementation details.

Changes

  • core/services.py - RoomBountyService and TrackingService
  • Timestamps generated at service layer using time.time()
  • PermissionError raised when non-creator tries to edit/delete
  • ValueError raised when tracking non-existent bounty
  • clear_link and clear_due parameters for partial updates

Closes #8

## Summary Implement business logic services: - **RoomBountyService**: add_bounty, get_bounty, list_bounties, update_bounty, delete_bounty - **TrackingService**: track_bounty, untrack_bounty, list_tracked All services orchestrate through storage ports (RoomStorage, TrackingStorage) with no implementation details. ## Changes - `core/services.py` - RoomBountyService and TrackingService - Timestamps generated at service layer using `time.time()` - PermissionError raised when non-creator tries to edit/delete - ValueError raised when tracking non-existent bounty - `clear_link` and `clear_due` parameters for partial updates Closes #8
shoko added 2 commits 2026-04-03 10:27:00 +02:00
feat(core): implement services for issue #8 c3634c5edb
fix(core): update services to match issue #8 requirements 932bbc5b63 
- Set created_at timestamp at service layer using time.time()
- Add PermissionError when non-creator tries to edit/delete
- Add ValueError when tracking non-existent bounty
- Rename create_bounty to add_bounty (matches spec)
- Add clear_link and clear_due parameters for partial updates
- Track timestamps for tracked bounties too
shoko closed this pull request 2026-04-03 11:41:26 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#25
Delete Branch "feat/issue-8-services"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?