shoko/jigaido
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(/add): time parsing, link uniqueness, admin-only #60

Closed
shoko wants to merge 2 commits from fix/issue-45-add-command-update into main
pull from: fix/issue-45-add-command-update
merge into: shoko:main
Conversation 1 Commits 2 Files Changed 2 +68 -23
shoko commented 2026-04-04 07:44:42 +02:00
Owner
Copy Link

Summary

Updates /add command per issue #45:

  1. Time Parsing: Parse time in HH:MM format after date

    • Example: /add Fix bug https://github.com/foo/bar april 15 14:30
    • If last arg matches HH:MM and previous arg is a parsed date, treats as time

  2. Link Uniqueness: check_link_unique now returns conflicting bounty ID

    • Duplicate links rejected with error message including existing bounty ID
    • Example: ⛔ A bounty with this link already exists: #3

  3. Admin-Only: cmd_add now catches PermissionError

    • Non-admin users see: ⛔ Only admins can add bounties.

Changes

  • core/services.py:

    • check_link_unique() returns int | None (bounty ID or None)
    • add_bounty() includes bounty ID in duplicate error
    • update_bounty() updated to use new return type

  • apps/telegram-bot/commands.py:

    • Added _is_time_format() and _set_time_on_timestamp() helpers
    • Updated parse_args() to parse HH:MM time after date
    • cmd_add catches PermissionError and ValueError
    • Updated usage and help text

Testing

# Time parsing
/add Fix bug https://github.com/foo/bar april 15 14:30

# Admin-only (non-admin user gets)
⛔ Only admins can add bounties.

# Duplicate link
⛔ A bounty with this link already exists: #3

Fixes #45

## Summary Updates `/add` command per issue #45: 1. **Time Parsing**: Parse time in `HH:MM` format after date - Example: `/add Fix bug https://github.com/foo/bar april 15 14:30` - If last arg matches `HH:MM` and previous arg is a parsed date, treats as time 2. **Link Uniqueness**: `check_link_unique` now returns conflicting bounty ID - Duplicate links rejected with error message including existing bounty ID - Example: `⛔ A bounty with this link already exists: #3` 3. **Admin-Only**: `cmd_add` now catches `PermissionError` - Non-admin users see: `⛔ Only admins can add bounties.` ## Changes - `core/services.py`: - `check_link_unique()` returns `int | None` (bounty ID or None) - `add_bounty()` includes bounty ID in duplicate error - `update_bounty()` updated to use new return type - `apps/telegram-bot/commands.py`: - Added `_is_time_format()` and `_set_time_on_timestamp()` helpers - Updated `parse_args()` to parse HH:MM time after date - `cmd_add` catches PermissionError and ValueError - Updated usage and help text ## Testing ```bash # Time parsing /add Fix bug https://github.com/foo/bar april 15 14:30 # Admin-only (non-admin user gets) ⛔ Only admins can add bounties. # Duplicate link ⛔ A bounty with this link already exists: #3 ``` Fixes #45
shoko added 1 commit 2026-04-04 07:44:42 +02:00
feat(/add): time parsing, link uniqueness, admin-only 6fb4b38c66 
- Add time parsing (HH:MM format) after date
  Example: /add Fix bug https://github.com/foo/bar april 15 14:30
- Update check_link_unique to return conflicting bounty ID
- Add_bounty now includes bounty ID in duplicate link error
- cmd_add now catches PermissionError and displays admin-only message
- Update usage text and help message
- Fixes #45
han approved these changes 2026-04-04 09:33:51 +02:00
han left a comment
Collaborator
Copy Link

lgtm

lgtm
shoko added 1 commit 2026-04-04 09:39:51 +02:00
Merge main into fix/issue-45-add-command-update: resolve conflict with room_id param 2689ddfa8b
shoko closed this pull request 2026-04-04 12:59:49 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
adapter
Storage adapter
 architecture
Architecture/design
 cleanup
Cleanup task
 cli
CLI application
 core
Core domain layer
 enhancement
need-user-approval
phase-1
Phase 1 task
 phase-2
Phase 2 implementation task
 telegram-bot
Telegram bot app
 tests
Tests
 v2
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jigaido#60
Delete Branch "fix/issue-45-add-command-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?