shoko/jujutsu-skills
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Event happening exactly now shows LIVE instead of In 0m #28

Merged
shoko merged 2 commits from fix/live-time-display into master 2026-03-26 18:48:24 +01:00
Conversation 1 Commits 2 Files Changed 2 +12 -2
shoko commented 2026-03-26 18:43:48 +01:00
Owner
Copy Link

Summary

## Summary - Changed `total_sec < 0` to `total_sec <= 0` to catch the edge case where an event is happening right now (total_sec = 0) - All 69 tests pass - Issue: #27
shoko added 1 commit 2026-03-26 18:43:48 +01:00
Fix: Event happening exactly now shows 'LIVE' instead of 'In 0m' 7f3b885521 
Changed condition from total_sec < 0 to total_sec <= 0 to catch the edge case where an event is happening right now.
shoko added 1 commit 2026-03-26 18:47:07 +01:00
Add test for event happening exactly now shows LIVE 53c268511a 
Added test_get_time_data_live_exactly_now to prevent regression.
han approved these changes 2026-03-26 18:48:09 +01:00
han left a comment
Collaborator
Copy Link

lgtm

lgtm
shoko merged commit c0f008ab8b into master 2026-03-26 18:48:24 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
approved
bug
Bug fix
 critical
Critical severity - stop using until fixed
 enhancement
Enhancement or feature
 high
High severity - fix ASAP
 in review
low
Low severity
 medium
Medium severity
 need adjustment
need clarification
need review
security
Security-related issues
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jujutsu-skills#28
Delete Branch "fix/live-time-display"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?