shoko/jujutsu-skills
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(polymarket-browse): add --starts-before filter for match events #30

Closed
shoko wants to merge 0 commits from feat/starts-before-filter into master
pull from: feat/starts-before-filter
merge into: shoko:master
Conversation 3 Commits - Files Changed -
shoko commented 2026-03-26 19:38:53 +01:00
Owner
Copy Link

Summary

  • Add --starts-before CLI argument accepting Unix timestamp to filter match events
  • Events starting after the timestamp are filtered out
  • LIVE events are always included regardless of timestamp
  • Update SKILL.md documentation

Changes

  • browse.py: Added CLI argument and filter_by_starts_before() function
  • test_browse.py: Added TestStartsBeforeFilter with 3 unit tests
  • SKILL.md: Updated documentation

Testing

73/73 tests passing

Notes

  • LIVE events are determined by _is_live_event() which checks if event started within last 4 hours
  • Filter only applies to match events, not non-match events
## Summary - Add `--starts-before` CLI argument accepting Unix timestamp to filter match events - Events starting after the timestamp are filtered out - LIVE events are always included regardless of timestamp - Update SKILL.md documentation ## Changes - `browse.py`: Added CLI argument and `filter_by_starts_before()` function - `test_browse.py`: Added `TestStartsBeforeFilter` with 3 unit tests - `SKILL.md`: Updated documentation ## Testing 73/73 tests passing ## Notes - LIVE events are determined by `_is_live_event()` which checks if event started within last 4 hours - Filter only applies to match events, not non-match events
shoko added 1 commit 2026-03-26 19:38:53 +01:00
feat(polymarket-browse): add --starts-before filter for match events cc197b0c7e 
- Add --starts-before CLI argument accepting Unix timestamp
- Filter match events to only show those starting before timestamp
- LIVE events are always included regardless of timestamp
- Update SKILL.md documentation
- Add TestStartsBeforeFilter with 3 unit tests
han commented 2026-03-27 01:36:35 +01:00
Collaborator
Copy Link

closes #29

closes #29
han approved these changes 2026-03-27 01:45:30 +01:00
Dismissed
han left a comment
Collaborator
Copy Link

lgtm

lgtm
han added the approved label 2026-03-27 01:56:36 +01:00
han approved these changes 2026-03-27 02:06:55 +01:00
shoko closed this pull request 2026-03-27 04:09:31 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
approved
bug
Bug fix
 critical
Critical severity - stop using until fixed
 enhancement
Enhancement or feature
 high
High severity - fix ASAP
 in review
low
Low severity
 medium
Medium severity
 need adjustment
need clarification
need review
security
Security-related issues
No Label approved
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jujutsu-skills#30
Delete Branch "feat/starts-before-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?