shoko/jujutsu-skills
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(polymarket-browse): add --timezone CLI argument for display timezone #31

Closed
shoko wants to merge 0 commits from fix/16-timezone-config into master
pull from: fix/16-timezone-config
merge into: shoko:master
Conversation 5 Commits - Files Changed -
shoko commented 2026-03-26 20:08:31 +01:00
Owner
Copy Link

Summary

  • Add --timezone CLI argument (default: UTC+7)
  • Supports UTC+X and UTC-X format (e.g., UTC+7, UTC-5)
  • Module-level _DISPLAY_TZ controls all time display

Changes

  • parse_timezone() function for timezone parsing
  • --timezone argument in CLI
  • get_header_date() and _get_time_data() use _DISPLAY_TZ
  • TestTimezoneParsing unit tests (5 tests)
  • SKILL.md updated

Testing

75/75 tests passing

## Summary - Add `--timezone` CLI argument (default: UTC+7) - Supports UTC+X and UTC-X format (e.g., UTC+7, UTC-5) - Module-level _DISPLAY_TZ controls all time display ## Changes - `parse_timezone()` function for timezone parsing - `--timezone` argument in CLI - `get_header_date()` and `_get_time_data()` use _DISPLAY_TZ - `TestTimezoneParsing` unit tests (5 tests) - SKILL.md updated ## Testing 75/75 tests passing
shoko added 1 commit 2026-03-26 20:08:31 +01:00
fix(polymarket-browse): add --timezone CLI argument for display timezone 0a1aab7883 
- Add parse_timezone() function supporting UTC+X format
- Add --timezone argument (default: UTC+7)
- Module-level _DISPLAY_TZ controls all time display formatting
- get_header_date() and _get_time_data() use _DISPLAY_TZ
- Add TestTimezoneParsing unit tests
- Update SKILL.md documentation
shoko reviewed 2026-03-27 01:51:01 +01:00
shoko left a comment
Author
Owner
Copy Link

Review requested

Review requested
shoko added the need review label 2026-03-27 01:52:35 +01:00
han commented 2026-03-27 01:55:26 +01:00
Collaborator
Copy Link

I have a question, is it better to use UTC+7 format or is it better to use Asia/Jakarta format. what are the tradeoff?

I have a question, is it better to use UTC+7 format or is it better to use Asia/Jakarta format. what are the tradeoff?
han added need clarification and removed need review labels 2026-03-27 01:56:13 +01:00
shoko commented 2026-03-27 01:57:44 +01:00
Author
Owner
Copy Link

Tradeoffs: UTC+7 vs Asia/Jakarta

Aspect UTC+7 Asia/Jakarta
Clarity Shows offset, not location Shows location name
DST handling Fixed offset, no DST IANA handles DST automatically
Readability Familiar to developers More descriptive
Edge cases None DST changes twice/year
Implementation Simple arithmetic ZoneInfo parsing needed

Recommendation: UTC+7 (current approach)

Reasons:

  1. Simplicity - No external dependencies (ZoneInfo not available in Python 3.14)
  2. Polymarket uses UTC internally - Most APIs work in UTC, offsets are the common convention
  3. Users in different timezones - Will likely use UTC±X anyway, not region names
  4. Current code already supports - The current implementation handles UTC+X format

Options

  • (A) Keep UTC+7 format as is — simpler, no new dependencies
  • (B) Add support for IANA names like Asia/Jakarta — requires tzdata dependency or try/except fallback

Which do you prefer?

## Tradeoffs: UTC+7 vs Asia/Jakarta | Aspect | UTC+7 | Asia/Jakarta | |--------|-------|---------------| | **Clarity** | Shows offset, not location | Shows location name | | **DST handling** | Fixed offset, no DST | IANA handles DST automatically | | **Readability** | Familiar to developers | More descriptive | | **Edge cases** | None | DST changes twice/year | | **Implementation** | Simple arithmetic | ZoneInfo parsing needed | ## Recommendation: **UTC+7 (current approach)** **Reasons:** 1. **Simplicity** - No external dependencies (ZoneInfo not available in Python 3.14) 2. **Polymarket uses UTC internally** - Most APIs work in UTC, offsets are the common convention 3. **Users in different timezones** - Will likely use UTC±X anyway, not region names 4. **Current code already supports** - The current implementation handles UTC+X format ## Options - **(A)** Keep UTC+7 format as is — simpler, no new dependencies - **(B)** Add support for IANA names like Asia/Jakarta — requires tzdata dependency or try/except fallback Which do you prefer?
shoko added need review and removed need clarification labels 2026-03-27 01:59:14 +01:00
han commented 2026-03-27 02:00:27 +01:00
Collaborator
Copy Link

lets keep UTC+7 format

lets keep UTC+7 format
han approved these changes 2026-03-27 02:00:41 +01:00
han left a comment
Collaborator
Copy Link

lgtm

lgtm
han added approved and removed need review labels 2026-03-27 02:00:54 +01:00
shoko closed this pull request 2026-03-27 04:09:41 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
approved
bug
Bug fix
 critical
Critical severity - stop using until fixed
 enhancement
Enhancement or feature
 high
High severity - fix ASAP
 in review
low
Low severity
 medium
Medium severity
 need adjustment
need clarification
need review
security
Security-related issues
No Label approved
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jujutsu-skills#31
Delete Branch "fix/16-timezone-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?