shoko/jujutsu-skills
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

security(polymarket-browse): add token bucket rate limiter for API calls #36

Closed
shoko wants to merge 0 commits from security/10-rate-limiting into master
pull from: security/10-rate-limiting
merge into: shoko:master
Conversation 3 Commits - Files Changed -
shoko commented 2026-03-26 20:15:21 +01:00
Owner
Copy Link

Summary

Add token bucket rate limiter to prevent overwhelming the Polymarket API.

Changes

  • Add RateLimiter class using token bucket algorithm
  • Thread-safe for use with ThreadPoolExecutor
  • RATE_LIMIT_CALLS = 10 per RATE_LIMIT_WINDOW = 1.0 second
  • _rate_limiter.acquire() called before each API request
  • Also includes MAX_RESPONSE_SIZE check (10MB limit)

Design

  • Token bucket allows bursts up to 10 concurrent requests
  • Maintains average rate of 10 requests/second
  • Thread-safe via _lock

Testing

70/70 tests passing

## Summary Add token bucket rate limiter to prevent overwhelming the Polymarket API. ## Changes - Add `RateLimiter` class using token bucket algorithm - Thread-safe for use with `ThreadPoolExecutor` - `RATE_LIMIT_CALLS = 10` per `RATE_LIMIT_WINDOW = 1.0` second - `_rate_limiter.acquire()` called before each API request - Also includes `MAX_RESPONSE_SIZE` check (10MB limit) ## Design - Token bucket allows bursts up to 10 concurrent requests - Maintains average rate of 10 requests/second - Thread-safe via `_lock` ## Testing 70/70 tests passing
shoko added 1 commit 2026-03-26 20:15:22 +01:00
security(polymarket-browse): add token bucket rate limiter for API calls c0484ab340 
- Add RateLimiter class (token bucket algorithm)
- Thread-safe for use with ThreadPoolExecutor
- RATE_LIMIT_CALLS = 10 per RATE_LIMIT_WINDOW = 1 second
- _rate_limiter.acquire() called before each API request
- Also add MAX_RESPONSE_SIZE check in fetch_page
shoko reviewed 2026-03-27 01:51:04 +01:00
shoko left a comment
Author
Owner
Copy Link

Review requested

Review requested
shoko added the need review label 2026-03-27 01:52:47 +01:00
han commented 2026-03-27 02:34:22 +01:00
Collaborator
Copy Link

for the MAX_RESPONSE_SIZE I think you should wait the PR #35 to be merged first. the rest is ok we can merge them

for the MAX_RESPONSE_SIZE I think you should wait the PR #35 to be merged first. the rest is ok we can merge them
han added approvedneed adjustment and removed need review labels 2026-03-27 02:34:31 +01:00
han approved these changes 2026-03-27 02:34:39 +01:00
han left a comment
Collaborator
Copy Link

lgtm

lgtm
shoko closed this pull request 2026-03-27 04:09:45 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
approved
bug
Bug fix
 critical
Critical severity - stop using until fixed
 enhancement
Enhancement or feature
 high
High severity - fix ASAP
 in review
low
Low severity
 medium
Medium severity
 need adjustment
need clarification
need review
security
Security-related issues
No Label approved need adjustment
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/jujutsu-skills#36
Delete Branch "security/10-rate-limiting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?