Compare commits

..

21 Commits

Author SHA1 Message Date
shokollm
796e1fe454 fix(kugetsu-index): call kugetsu_add_notification from bash instead of os.system()
os.system() spawns a new subprocess that cannot access bash functions.
Now calling kugetsu_add_notification directly from bash after Python updates JSON.

Fixes #167
2026-04-06 00:33:35 +00:00
84c59a3b64 Merge pull request 'fix(kugetsu): queue daemon improvements - locking, error handling, cmd_delegate enqueue' (#164) from fix/issue-156-queue-fixes into main 2026-04-06 02:06:36 +02:00
shokollm
dc9d4d7327 Merge origin/main into fix/issue-156-queue-fixes 2026-04-06 00:02:47 +00:00
shokollm
bdcb7a476c fix(queue-daemon): add locking, proper state updates, and error handling
- Add acquire_lock/release_lock to prevent daemon vs manual conflicts
- Check cmd_start/cmd_continue success before updating state to 'notified'
- Set state to 'error' if command fails
- Track actual session_id from session file after cmd_start completes
- Release lock when task completes (success or error)
- Use load_agent_env 'pm-agent' for GITEA_TOKEN

Fixes critical race conditions and failure handling in queue processing
2026-04-06 00:01:41 +00:00
77cf817568 Merge pull request 'fix(kugetsu): return proper JSON array from get_pending_tasks()' (#163) from fix/issue-155-queue-list-json into main 2026-04-06 01:45:09 +02:00
shokollm
0f6a30f01c fix(kugetsu): return proper JSON array from get_pending_tasks() 2026-04-05 23:43:52 +00:00
77b0963fa4 Merge pull request 'fix(queue-daemon): source pm-agent.env for GITEA_TOKEN instead of default.env' (#162) from fix/issue-160-gitea-token-from-pm-agent into main 2026-04-06 01:42:04 +02:00
shokollm
f39e39156a fix(queue-daemon): source pm-agent.env for GITEA_TOKEN instead of default.env 2026-04-05 23:38:07 +00:00
shokollm
5a0a54898b fix(kugetsu): kugetsu-session.sh needs to source required modules
When daemon sources kugetsu-session.sh to call cmd_start/cmd_continue,
it needs access to functions from kugetsu-config.sh, kugetsu-index.sh,
kugetsu-worktree.sh, and kugetsu-log.sh. Add sourcing at top of
kugetsu-session.sh.
2026-04-05 22:20:49 +00:00
shokollm
b1028a6556 fix(kugetsu): move queue functions to kugetsu-index.sh for daemon access
The daemon (kugetsu-queue-daemon.sh) sources kugetsu-index.sh but not the main kugetsu script.
Move update_queue_item_state and kugetsu_add_notification to kugetsu-index.sh
so the daemon can use these functions when processing tasks.
2026-04-05 22:17:59 +00:00
shokollm
270219873f fix(kugetsu): cmd_delegate should enqueue instead of calling cmd_start
When cmd_delegate detects an issue ref with number (e.g. git.fbrns.co/shoko/kugetsu#158),
it was calling cmd_start directly which tries to create worktree and clone.
This breaks the queue-based workflow where daemon should handle task execution.

Now cmd_delegate calls enqueue_task to add to queue, and daemon processes
tasks by calling cmd_start/cmd_continue as appropriate.
2026-04-05 22:05:18 +00:00
deb18f1e32 Merge pull request 'fix(kugetsu): queue daemon runs PM agent in correct worktree with proper token' (#157) from fix/issue-156 into main 2026-04-05 23:39:35 +02:00
shokollm
cbfc8a0646 refactor(kugetsu): daemon uses cmd_start/cmd_continue instead of direct opencode calls
- Move issue_ref_to_filename and filename_to_issue_ref to kugetsu-index.sh
  (where they logically belong, instead of in main kugetsu script)
- Refactor queue daemon to use cmd_start/cmd_continue for session management
- Daemon now checks if worktree/session exists → cmd_continue, else → cmd_start
- Removes ~40 lines of direct opencode session forking logic from daemon
- cmd_start/cmd_continue handle worktree creation, session forking, and tracking

This simplifies the daemon significantly and centralizes session management
in kugetsu-session.sh where it belongs.
2026-04-05 21:29:34 +00:00
shokollm
7fa669b4c3 fix(kugetsu): queue daemon runs PM agent in correct worktree with proper token
- Load GITEA_TOKEN from ~/.kugetsu/env/default.env at daemon startup
- Use --fork --session --dir instead of --continue to run in correct directory
- Create worktree if it doesn't exist for the issue
- Track forked session ID (not parent pm_session) for completion detection
- Forked session ends when task completes, parent pm_session continues

Fixes #156
2026-04-05 20:57:51 +00:00
acb503471d Merge pull request 'fix(kugetsu): detect task completion and queue state updates' (#154) from fix/issue-150 into main 2026-04-05 15:10:48 +02:00
shokollm
1d4f190d97 fix(kugetsu): pass GITEA_TOKEN via env to subprocess instead of hardcoded value 2026-04-05 13:09:08 +00:00
shokollm
ab0c4e1448 fix: detect task completion by checking if session ended and has commits 2026-04-05 12:45:59 +00:00
shokollm
9bb8afe8c5 Merge origin/main into fix/issue-148-test-suite-index-corruption (fix CONTRIBUTING.md conflict) 2026-04-05 12:24:02 +00:00
shokollm
fd7a98b263 fix: validate sessions in cmd_status + use isolated test environment
1. cmd_status now validates session IDs against opencode session list
   - Reports 'error: base session X not found in opencode' if missing
   - Reports 'error: pm_agent session X not found in opencode' if missing

2. Test suite now uses isolated KUGETSU_DIR=/tmp/test-kugetsu-$$
   - All tests use separate test directory instead of ~/.kugetsu
   - Prevents test suite from corrupting real user data
   - Cleanup removes test directory entirely

Fixes #148
2026-04-05 12:10:55 +00:00
3942a915ff Merge pull request 'refactor: modularize kugetsu shell script' (#151) from fix/issue-116-modularize-script into main 2026-04-05 12:58:48 +02:00
shokollm
1886c4a9c5 Merge origin/main into fix/issue-116-modularize-script (fix leftover conflict markers) 2026-04-05 10:57:46 +00:00
5 changed files with 347 additions and 86 deletions

View File

@@ -99,17 +99,6 @@ ensure_worktree_dir() {
mkdir -p "$WORKTREES_DIR" mkdir -p "$WORKTREES_DIR"
} }
issue_ref_to_filename() {
local issue_ref="$1"
echo "$issue_ref" | sed 's/[\/:]/-/g' | sed 's/#/-/'
}
filename_to_issue_ref() {
local filename="$1"
local name="${filename%.json}"
echo "$name" | sed 's/-\([0-9]*\)$/#\1/' | sed 's/-/\//g'
}
issue_ref_to_context_file() { issue_ref_to_context_file() {
local issue_ref="$1" local issue_ref="$1"
local context_filename=$(issue_ref_to_filename "$issue_ref") local context_filename=$(issue_ref_to_filename "$issue_ref")
@@ -321,12 +310,31 @@ get_pending_tasks() {
return return
fi fi
find "$QUEUE_ITEMS_DIR" -name "*.json" -type f 2>/dev/null | while read -r file; do python3 -c "
local state=$(python3 -c "import json; print(json.load(open('$file')).get('state', ''))" 2>/dev/null || echo "") import json
if [ "$state" = "pending" ]; then import os
cat "$file" import sys
fi
done | head -"$limit" queue_dir = os.environ.get('QUEUE_ITEMS_DIR', '')
limit = int(sys.argv[1]) if len(sys.argv) > 1 else 10
items = []
if os.path.isdir(queue_dir):
for filename in os.listdir(queue_dir):
if filename.endswith('.json'):
filepath = os.path.join(queue_dir, filename)
try:
with open(filepath) as f:
data = json.load(f)
if data.get('state') == 'pending':
items.append(data)
if len(items) >= limit:
break
except:
pass
print(json.dumps(items))
" "$limit"
} }
get_queue_stats() { get_queue_stats() {
@@ -820,6 +828,18 @@ cmd_status() {
return return
fi fi
local opencode_sessions=$(opencode session list 2>/dev/null | grep -oP '^ses_\w+' || true)
if ! echo "$opencode_sessions" | grep -q "^${base}$"; then
echo "error: base session '$base' not found in opencode"
return
fi
if ! echo "$opencode_sessions" | grep -q "^${pm_agent}$"; then
echo "error: pm_agent session '$pm_agent' not found in opencode"
return
fi
echo "ok" echo "ok"
} }
@@ -974,7 +994,6 @@ find_sessions_by_issue_number() {
echo "$results" echo "$results"
} }
>>>>>>> origin/main
cmd_queue() { cmd_queue() {
local action="${1:-list}" local action="${1:-list}"
shift shift

View File

@@ -133,3 +133,111 @@ with open(session_path, 'w') as f:
print(f"Updated PR URL for $issue_ref: $pr_url") print(f"Updated PR URL for $issue_ref: $pr_url")
PYEOF PYEOF
} }
# Convert issue ref to session filename
issue_ref_to_filename() {
local issue_ref="$1"
echo "$issue_ref" | sed 's/[\/:]/-/g' | sed 's/#/-/'
}
# Convert session filename back to issue ref
filename_to_issue_ref() {
local filename="$1"
local name="${filename%.json}"
echo "$name" | sed 's-\([0-9]*\)$-#\1-' | sed 's/-/\//g'
}
# Add notification to notifications file
kugetsu_add_notification() {
local type="$1"
local message="$2"
local issue_ref="${3:-}"
local gitea_url="${4:-}"
mkdir -p "$(dirname "$NOTIFICATIONS_FILE")"
python3 << PYEOF
import json
import os
from datetime import datetime
notification = {
"type": "$type",
"message": "$message",
"issue_ref": "$issue_ref" if "$issue_ref" else None,
"gitea_url": "$gitea_url" if "$gitea_url" else None,
"timestamp": datetime.now().isoformat(),
"read": False
}
file_path = os.path.expanduser("$NOTIFICATIONS_FILE")
notifications = []
if os.path.exists(file_path):
try:
with open(file_path, 'r') as f:
notifications = json.load(f)
except:
notifications = []
notifications.append(notification)
with open(file_path, 'w') as f:
json.dump(notifications, f, indent=2)
print("Notification added")
PYEOF
}
# Update queue item state
update_queue_item_state() {
local queue_id="$1"
local new_state="$2"
local session_id="${3:-}"
local pid="${4:-}"
local item_file="$QUEUE_ITEMS_DIR/${queue_id}.json"
if [ ! -f "$item_file" ]; then
echo "Error: Queue item not found: $queue_id" >&2
return 1
fi
local issue_ref=$(python3 -c "import json; print(json.load(open('$item_file')).get('issue_ref', ''))" 2>/dev/null || echo "")
python3 << PYEOF
import json
from datetime import datetime
item_file = "$item_file"
new_state = "$new_state"
session_id = "$session_id"
pid = "$pid"
with open(item_file, 'r') as f:
item = json.load(f)
item['state'] = new_state
if new_state == "notified":
item['notified_at'] = datetime.now().isoformat() + "Z"
if session_id:
item['opencode_session_id'] = session_id
if pid:
item['pid'] = int(pid) if pid.isdigit() else None
elif new_state == "completed":
item['completed_at'] = datetime.now().isoformat() + "Z"
elif new_state == "error":
item['error'] = datetime.now().isoformat() + "Z"
with open(item_file, 'w') as f:
json.dump(item, f, indent=2)
print(f"Updated $queue_id to state: $new_state")
PYEOF
if [ "$new_state" = "completed" ]; then
kugetsu_add_notification "task_completed" "Task completed: $issue_ref" "$issue_ref"
elif [ "$new_state" = "error" ]; then
kugetsu_add_notification "task_error" "Task error: $issue_ref" "$issue_ref"
fi
}

145
skills/kugetsu/scripts/kugetsu-queue-daemon.sh Executable file → Normal file
View File

@@ -8,23 +8,146 @@ source "$SCRIPT_DIR/kugetsu-index.sh"
source "$SCRIPT_DIR/kugetsu-worktree.sh" source "$SCRIPT_DIR/kugetsu-worktree.sh"
source "$SCRIPT_DIR/kugetsu-log.sh" source "$SCRIPT_DIR/kugetsu-log.sh"
load_agent_env "pm-agent"
acquire_lock() {
local issue_ref="$1"
local lock_file="$QUEUE_DIR/locks/$(echo "$issue_ref" | sed 's/[\/:]/-/g' | sed 's/#/-/').lock"
mkdir -p "$(dirname "$lock_file")"
if [ -f "$lock_file" ]; then
local pid=$(cat "$lock_file" 2>/dev/null || echo "")
if [ -n "$pid" ] && kill -0 "$pid" 2>/dev/null; then
return 1
fi
rm -f "$lock_file"
fi
echo $$ > "$lock_file"
return 0
}
release_lock() {
local issue_ref="$1"
local lock_file="$QUEUE_DIR/locks/$(echo "$issue_ref" | sed 's/[\/:]/-/g' | sed 's/#/-/').lock"
rm -f "$lock_file"
}
check_task_completion() {
local item="$1"
local queue_id=$(basename "$item" .json)
local state=$(python3 -c "import json; print(json.load(open('$item')).get('state', ''))" 2>/dev/null)
[ "$state" = "notified" ] || return 0
local session_id=$(python3 -c "import json; print(json.load(open('$item')).get('opencode_session_id', ''))" 2>/dev/null)
local issue_ref=$(python3 -c "import json; print(json.load(open('$item')).get('issue_ref', ''))" 2>/dev/null)
local pid=$(python3 -c "import json; print(json.load(open('$item')).get('pid', ''))" 2>/dev/null)
if [ -n "$pid" ] && [ "$pid" != "None" ]; then
if ! kill -0 "$pid" 2>/dev/null; then
local worktree_path=$(issue_ref_to_worktree_path "$issue_ref" "$HOME/.kugetsu-worktrees")
local has_commits=false
if [ -d "$worktree_path" ] && [ -d "$worktree_path/.git" ]; then
if [ -n "$(git -C "$worktree_path" log --oneline origin/main..HEAD 2>/dev/null)" ]; then
has_commits=true
fi
fi
if [ "$has_commits" = true ]; then
update_queue_item_state "$queue_id" "completed"
echo "Task $queue_id ($issue_ref) completed — new commits found"
else
update_queue_item_state "$queue_id" "error"
echo "Task $queue_id ($issue_ref) marked error — no commits found after session ended"
fi
release_lock "$issue_ref"
fi
else
if [ -n "$session_id" ] && ! opencode session list 2>/dev/null | grep -q "$session_id"; then
local worktree_path=$(issue_ref_to_worktree_path "$issue_ref" "$HOME/.kugetsu-worktrees")
local has_commits=false
if [ -d "$worktree_path" ] && [ -d "$worktree_path/.git" ]; then
if [ -n "$(git -C "$worktree_path" log --oneline origin/main..HEAD 2>/dev/null)" ]; then
has_commits=true
fi
fi
if [ "$has_commits" = true ]; then
update_queue_item_state "$queue_id" "completed"
echo "Task $queue_id ($issue_ref) completed — new commits found"
else
update_queue_item_state "$queue_id" "error"
echo "Task $queue_id ($issue_ref) marked error — no commits found after session ended"
fi
release_lock "$issue_ref"
fi
fi
}
get_session_id_for_issue() {
local issue_ref="$1"
local session_file=$(issue_ref_to_filename "$issue_ref")
local session_path="$SESSIONS_DIR/$session_file"
if [ -f "$session_path" ]; then
python3 -c "import json; print(json.load(open('$session_path')).get('opencode_session_id', ''))" 2>/dev/null || echo ""
else
echo ""
fi
}
process_task() {
local item="$1"
local queue_id=$(basename "$item" .json)
local issue_ref=$(python3 -c "import json; print(json.load(open('$item')).get('issue_ref', ''))" 2>/dev/null)
local message=$(python3 -c "import json; print(json.load(open('$item')).get('message', ''))" 2>/dev/null)
if ! acquire_lock "$issue_ref"; then
echo "Task $queue_id ($issue_ref) skipped — another process is handling it"
return
fi
source "$SCRIPT_DIR/kugetsu-session.sh"
if worktree_exists "$issue_ref" "$HOME/.kugetsu-worktrees" || [ -f "$SESSIONS_DIR/$(issue_ref_to_filename "$issue_ref").json" ]; then
log_file="$LOGS_DIR/delegate-$(date +%s).log"
if cmd_continue "$issue_ref" "$message" >> "$log_file" 2>&1; then
sleep 1
local session_id=$(get_session_id_for_issue "$issue_ref")
update_queue_item_state "$queue_id" "notified" "$session_id" ""
echo "Task $queue_id continued for $issue_ref"
else
update_queue_item_state "$queue_id" "error"
echo "Task $queue_id ($issue_ref) failed to continue"
fi
else
log_file="$LOGS_DIR/delegate-$(date +%s).log"
if cmd_start "$issue_ref" "$message" >> "$log_file" 2>&1; then
sleep 1
local session_id=$(get_session_id_for_issue "$issue_ref")
update_queue_item_state "$queue_id" "notified" "$session_id" ""
echo "Task $queue_id started for $issue_ref"
else
update_queue_item_state "$queue_id" "error"
echo "Task $queue_id ($issue_ref) failed to start"
fi
fi
release_lock "$issue_ref"
}
while true; do while true; do
if [ -d "$QUEUE_ITEMS_DIR" ]; then if [ -d "$QUEUE_ITEMS_DIR" ]; then
for item in "$QUEUE_ITEMS_DIR"/*.json; do
[ -f "$item" ] || continue
check_task_completion "$item"
done
for item in "$QUEUE_ITEMS_DIR"/*.json; do for item in "$QUEUE_ITEMS_DIR"/*.json; do
[ -f "$item" ] || continue [ -f "$item" ] || continue
state=$(python3 -c "import json; print(json.load(open('$item')).get('state', ''))" 2>/dev/null) state=$(python3 -c "import json; print(json.load(open('$item')).get('state', ''))" 2>/dev/null)
if [ "$state" = "pending" ]; then if [ "$state" = "pending" ]; then
queue_id=$(basename "$item" .json) process_task "$item"
issue_ref=$(python3 -c "import json; print(json.load(open('$item')).get('issue_ref', ''))" 2>/dev/null)
message=$(python3 -c "import json; print(json.load(open('$item')).get('message', ''))" 2>/dev/null)
pm_session=$(get_pm_agent_session_id)
if [ -n "$pm_session" ] && [ "$pm_session" != "null" ]; then
log_file="$LOGS_DIR/delegate-$(date +%s).log"
GITEA_TOKEN="${GITEA_TOKEN:-}" nohup sh -c "opencode run '$message' --continue --session '$pm_session' >> '$log_file' 2>&1" > /dev/null 2>&1 &
pid=$!
update_queue_item_state "$queue_id" "notified" "$pm_session" "$pid"
fi
fi fi
done done
fi fi

View File

@@ -1,6 +1,13 @@
#!/bin/bash #!/bin/bash
set -euo pipefail set -euo pipefail
# Source required modules for session management functions
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
source "$SCRIPT_DIR/kugetsu-config.sh"
source "$SCRIPT_DIR/kugetsu-index.sh"
source "$SCRIPT_DIR/kugetsu-worktree.sh"
source "$SCRIPT_DIR/kugetsu-log.sh"
count_active_dev_sessions() { count_active_dev_sessions() {
local count=0 local count=0
if [ -d "$SESSIONS_DIR" ]; then if [ -d "$SESSIONS_DIR" ]; then
@@ -153,10 +160,12 @@ cmd_delegate() {
local issue_ref=$(extract_issue_ref_from_message "$message") local issue_ref=$(extract_issue_ref_from_message "$message")
if [ -n "$issue_ref" ] && [[ "$issue_ref" =~ \#[0-9]+$ ]]; then if [ -n "$issue_ref" ] && [[ "$issue_ref" =~ \#[0-9]+$ ]]; then
cmd_start "$issue_ref" "$message" # Enqueue for daemon to process via cmd_start/cmd_continue
enqueue_task "$issue_ref" "$message"
return return
fi fi
# No issue ref detected — delegate directly to PM agent (legacy path)
local pm_session=$(get_pm_agent_session_id) local pm_session=$(get_pm_agent_session_id)
if [ -z "$pm_session" ] || [ "$pm_session" = "null" ] || [ "$pm_session" = "None" ]; then if [ -z "$pm_session" ] || [ "$pm_session" = "null" ] || [ "$pm_session" = "None" ]; then
echo "Error: PM agent session not found. Run 'kugetsu init' first." >&2 echo "Error: PM agent session not found. Run 'kugetsu init' first." >&2
@@ -165,7 +174,7 @@ cmd_delegate() {
mkdir -p "$LOGS_DIR" mkdir -p "$LOGS_DIR"
local log_file="$LOGS_DIR/delegate-$(date +%s).log" local log_file="$LOGS_DIR/delegate-$(date +%s).log"
nohup sh -c "GITEA_TOKEN='${GITEA_TOKEN:-}' opencode run '$message' --continue --session '$pm_session' >> '$log_file' 2>&1" > /dev/null 2>&1 & nohup sh -c "GITEA_TOKEN='***' opencode run '$message' --continue --session '$pm_session' >> '$log_file' 2>&1" > /dev/null 2>&1 &
disown disown
echo "Delegated to PM agent (logged to $(basename "$log_file"))" echo "Delegated to PM agent (logged to $(basename "$log_file"))"
} }

View File

@@ -7,6 +7,8 @@
set -euo pipefail set -euo pipefail
KUGETSU="./skills/kugetsu/scripts/kugetsu" KUGETSU="./skills/kugetsu/scripts/kugetsu"
TEST_KUGETSU_DIR="/tmp/test-kugetsu-$$"
export KUGETSU_DIR="$TEST_KUGETSU_DIR"
TEST_ISSUE_REF="github.com/shoko/kugetsu#14" TEST_ISSUE_REF="github.com/shoko/kugetsu#14"
TEST_DISCUSS_REF="github.com/shoko/kugetsu#-discuss" TEST_DISCUSS_REF="github.com/shoko/kugetsu#-discuss"
TEST_BASE_SESSION_ID="ses_test_base_123" TEST_BASE_SESSION_ID="ses_test_base_123"
@@ -18,28 +20,28 @@ PASS=0
FAIL=0 FAIL=0
cleanup() { cleanup() {
rm -rf ~/.kugetsu/sessions/* ~/.kugetsu/worktrees/* ~/.kugetsu/index.json 2>/dev/null || true rm -rf "$TEST_KUGETSU_DIR" 2>/dev/null || true
} }
setup_mock_base() { setup_mock_base() {
mkdir -p ~/.kugetsu/sessions ~/.kugetsu/worktrees mkdir -p "$TEST_KUGETSU_DIR/sessions" "$TEST_KUGETSU_DIR/worktrees"
cat > ~/.kugetsu/index.json << EOF cat > "$TEST_KUGETSU_DIR/index.json" << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": "$TEST_PM_AGENT_SESSION_ID", "pm_agent": "$TEST_PM_AGENT_SESSION_ID",
"issues": {} "issues": {}
} }
EOF EOF
cat > ~/.kugetsu/sessions/$TEST_BASE_SESSION_FILE << EOF cat > "$TEST_KUGETSU_DIR/sessions/$TEST_BASE_SESSION_FILE" << EOF
{"type": "base", "opencode_session_id": "$TEST_BASE_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"} {"type": "base", "opencode_session_id": "$TEST_BASE_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}
EOF EOF
cat > ~/.kugetsu/sessions/$TEST_PM_AGENT_SESSION_FILE << EOF cat > "$TEST_KUGETSU_DIR/sessions/$TEST_PM_AGENT_SESSION_FILE" << EOF
{"type": "pm_agent", "opencode_session_id": "$TEST_PM_AGENT_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"} {"type": "pm_agent", "opencode_session_id": "$TEST_PM_AGENT_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}
EOF EOF
} }
setup_mock_forked() { setup_mock_forked() {
cat > ~/.kugetsu/index.json << EOF cat > "$TEST_KUGETSU_DIR/index.json" << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": "$TEST_PM_AGENT_SESSION_ID", "pm_agent": "$TEST_PM_AGENT_SESSION_ID",
@@ -48,7 +50,7 @@ setup_mock_forked() {
} }
} }
EOF EOF
cat > ~/.kugetsu/sessions/$TEST_FORKED_SESSION_FILE << EOF cat > "$TEST_KUGETSU_DIR/sessions/$TEST_FORKED_SESSION_FILE" << EOF
{"type": "forked", "issue_ref": "$TEST_ISSUE_REF", "opencode_session_id": "ses_forked_789", "worktree_path": "/tmp/test-worktree", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"} {"type": "forked", "issue_ref": "$TEST_ISSUE_REF", "opencode_session_id": "ses_forked_789", "worktree_path": "/tmp/test-worktree", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}
EOF EOF
} }
@@ -112,16 +114,16 @@ echo ""
# Test 3b: start fails without pm-agent # Test 3b: start fails without pm-agent
echo "--- Test: start without pm-agent session ---" echo "--- Test: start without pm-agent session ---"
rm -f ~/.kugetsu/index.json ~/.kugetsu/sessions/* rm -f $TEST_KUGETSU_DIR/index.json $TEST_KUGETSU_DIR/sessions/*
mkdir -p ~/.kugetsu/sessions mkdir -p $TEST_KUGETSU_DIR/sessions
cat > ~/.kugetsu/index.json << EOF cat > $TEST_KUGETSU_DIR/index.json << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": null, "pm_agent": null,
"issues": {} "issues": {}
} }
EOF EOF
cat > ~/.kugetsu/sessions/$TEST_BASE_SESSION_FILE << EOF cat > $TEST_KUGETSU_DIR/sessions/$TEST_BASE_SESSION_FILE << EOF
{"type": "base", "opencode_session_id": "$TEST_BASE_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"} {"type": "base", "opencode_session_id": "$TEST_BASE_SESSION_ID", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}
EOF EOF
OUTPUT=$($KUGETSU start github.com/shoko/kugetsu#14 "test" 2>&1 || true) OUTPUT=$($KUGETSU start github.com/shoko/kugetsu#14 "test" 2>&1 || true)
@@ -176,7 +178,7 @@ echo ""
# Test 6c: index.json has pm_agent field # Test 6c: index.json has pm_agent field
echo "--- Test: index.json has pm_agent field ---" echo "--- Test: index.json has pm_agent field ---"
if grep -q '"pm_agent"' ~/.kugetsu/index.json; then if grep -q '"pm_agent"' $TEST_KUGETSU_DIR/index.json; then
pass "index.json has pm_agent field" pass "index.json has pm_agent field"
else else
fail "index.json missing pm_agent field" fail "index.json missing pm_agent field"
@@ -227,12 +229,12 @@ echo ""
echo "--- Test: destroy --pm-agent -y ---" echo "--- Test: destroy --pm-agent -y ---"
setup_mock_base setup_mock_base
OUTPUT=$($KUGETSU destroy --pm-agent -y 2>&1 || true) OUTPUT=$($KUGETSU destroy --pm-agent -y 2>&1 || true)
if [ -f ~/.kugetsu/sessions/$TEST_PM_AGENT_SESSION_FILE ]; then if [ -f $TEST_KUGETSU_DIR/sessions/$TEST_PM_AGENT_SESSION_FILE ]; then
fail "destroy --pm-agent -y removes pm-agent file" fail "destroy --pm-agent -y removes pm-agent file"
else else
pass "destroy --pm-agent -y removes pm-agent file" pass "destroy --pm-agent -y removes pm-agent file"
fi fi
if grep -q '"pm_agent": null' ~/.kugetsu/index.json; then if grep -q '"pm_agent": null' $TEST_KUGETSU_DIR/index.json; then
pass "destroy --pm-agent -y sets pm_agent to null in index" pass "destroy --pm-agent -y sets pm_agent to null in index"
else else
fail "destroy --pm-agent -y should set pm_agent to null" fail "destroy --pm-agent -y should set pm_agent to null"
@@ -243,7 +245,7 @@ echo ""
echo "--- Test: destroy --base -y ---" echo "--- Test: destroy --base -y ---"
setup_mock_base setup_mock_base
OUTPUT=$($KUGETSU destroy --base -y 2>&1 || true) OUTPUT=$($KUGETSU destroy --base -y 2>&1 || true)
if [ -f ~/.kugetsu/sessions/$TEST_BASE_SESSION_FILE ]; then if [ -f $TEST_KUGETSU_DIR/sessions/$TEST_BASE_SESSION_FILE ]; then
fail "destroy --base -y removes base file" fail "destroy --base -y removes base file"
else else
pass "destroy --base -y removes base file" pass "destroy --base -y removes base file"
@@ -292,7 +294,7 @@ echo ""
# Test 15: worktree path in session file # Test 15: worktree path in session file
echo "--- Test: worktree_path in session file ---" echo "--- Test: worktree_path in session file ---"
if grep -q "worktree_path" ~/.kugetsu/sessions/$TEST_FORKED_SESSION_FILE; then if grep -q "worktree_path" $TEST_KUGETSU_DIR/sessions/$TEST_FORKED_SESSION_FILE; then
pass "session file contains worktree_path" pass "session file contains worktree_path"
else else
fail "session file missing worktree_path" fail "session file missing worktree_path"
@@ -303,7 +305,7 @@ echo ""
echo "--- Test: prune with orphaned worktree ---" echo "--- Test: prune with orphaned worktree ---"
cleanup cleanup
setup_mock_base setup_mock_base
mkdir -p ~/.kugetsu/worktrees/orphaned-worktree mkdir -p $TEST_KUGETSU_DIR/worktrees/orphaned-worktree
OUTPUT=$($KUGETSU prune 2>&1 || true) OUTPUT=$($KUGETSU prune 2>&1 || true)
if echo "$OUTPUT" | grep -q "orphaned worktree"; then if echo "$OUTPUT" | grep -q "orphaned worktree"; then
pass "prune detects orphaned worktree" pass "prune detects orphaned worktree"
@@ -315,7 +317,7 @@ echo ""
# Test 17: prune --force removes orphaned worktrees # Test 17: prune --force removes orphaned worktrees
echo "--- Test: prune --force removes orphaned worktrees ---" echo "--- Test: prune --force removes orphaned worktrees ---"
OUTPUT=$($KUGETSU prune --force 2>&1 || true) OUTPUT=$($KUGETSU prune --force 2>&1 || true)
if [ -d ~/.kugetsu/worktrees/orphaned-worktree ]; then if [ -d $TEST_KUGETSU_DIR/worktrees/orphaned-worktree ]; then
fail "prune --force should remove orphaned worktree" fail "prune --force should remove orphaned worktree"
else else
pass "prune --force removes orphaned worktree" pass "prune --force removes orphaned worktree"
@@ -332,10 +334,10 @@ echo ""
echo "--- Test: destroy removes worktree ---" echo "--- Test: destroy removes worktree ---"
cleanup cleanup
setup_mock_forked setup_mock_forked
# remove_worktree_for_issue derives path from issue ref: ~/.kugetsu/worktrees/github.com-shoko-kugetsu-14 # remove_worktree_for_issue derives path from issue ref: $TEST_KUGETSU_DIR/worktrees/github.com-shoko-kugetsu-14
mkdir -p ~/.kugetsu/worktrees/github.com-shoko-kugetsu-14 mkdir -p $TEST_KUGETSU_DIR/worktrees/github.com-shoko-kugetsu-14
OUTPUT=$($KUGETSU destroy github.com/shoko/kugetsu#14 -y 2>&1 || true) OUTPUT=$($KUGETSU destroy github.com/shoko/kugetsu#14 -y 2>&1 || true)
if [ -d ~/.kugetsu/worktrees/github.com-shoko-kugetsu-14 ]; then if [ -d $TEST_KUGETSU_DIR/worktrees/github.com-shoko-kugetsu-14 ]; then
fail "destroy should remove worktree" fail "destroy should remove worktree"
else else
pass "destroy removes worktree" pass "destroy removes worktree"
@@ -345,7 +347,7 @@ echo ""
# Test 20: session file properly formatted for v2.2 # Test 20: session file properly formatted for v2.2
echo "--- Test: session file format v2.2 ---" echo "--- Test: session file format v2.2 ---"
setup_mock_forked setup_mock_forked
SESSION_CONTENT=$(cat ~/.kugetsu/sessions/$TEST_FORKED_SESSION_FILE) SESSION_CONTENT=$(cat $TEST_KUGETSU_DIR/sessions/$TEST_FORKED_SESSION_FILE)
if echo "$SESSION_CONTENT" | grep -q '"type": "forked"' && \ if echo "$SESSION_CONTENT" | grep -q '"type": "forked"' && \
echo "$SESSION_CONTENT" | grep -q '"worktree_path"'; then echo "$SESSION_CONTENT" | grep -q '"worktree_path"'; then
pass "session file has v2.2 format" pass "session file has v2.2 format"
@@ -367,8 +369,8 @@ echo ""
# Test 22: status when base missing # Test 22: status when base missing
echo "--- Test: status (base missing) ---" echo "--- Test: status (base missing) ---"
mkdir -p ~/.kugetsu/sessions mkdir -p $TEST_KUGETSU_DIR/sessions
cat > ~/.kugetsu/index.json << EOF cat > $TEST_KUGETSU_DIR/index.json << EOF
{ {
"base": null, "base": null,
"pm_agent": "$TEST_PM_AGENT_SESSION_ID", "pm_agent": "$TEST_PM_AGENT_SESSION_ID",
@@ -385,7 +387,7 @@ echo ""
# Test 23: status when pm-agent missing # Test 23: status when pm-agent missing
echo "--- Test: status (pm-agent missing) ---" echo "--- Test: status (pm-agent missing) ---"
cat > ~/.kugetsu/index.json << EOF cat > $TEST_KUGETSU_DIR/index.json << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": null, "pm_agent": null,
@@ -402,7 +404,7 @@ echo ""
# Test 24: status when pm-agent is "None" (Python None output) # Test 24: status when pm-agent is "None" (Python None output)
echo "--- Test: status (pm-agent is Python None) ---" echo "--- Test: status (pm-agent is Python None) ---"
cat > ~/.kugetsu/index.json << EOF cat > $TEST_KUGETSU_DIR/index.json << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": "None", "pm_agent": "None",
@@ -445,8 +447,8 @@ echo ""
# Test 27: delegate when pm-agent missing # Test 27: delegate when pm-agent missing
echo "--- Test: delegate (pm-agent missing) ---" echo "--- Test: delegate (pm-agent missing) ---"
cleanup cleanup
mkdir -p ~/.kugetsu/sessions ~/.kugetsu/worktrees mkdir -p $TEST_KUGETSU_DIR/sessions $TEST_KUGETSU_DIR/worktrees
cat > ~/.kugetsu/index.json << EOF cat > $TEST_KUGETSU_DIR/index.json << EOF
{ {
"base": "$TEST_BASE_SESSION_ID", "base": "$TEST_BASE_SESSION_ID",
"pm_agent": null, "pm_agent": null,
@@ -508,7 +510,7 @@ echo ""
# Test 32: delegate is fire-and-forget (returns immediately) # Test 32: delegate is fire-and-forget (returns immediately)
echo "--- Test: delegate is fire-and-forget ---" echo "--- Test: delegate is fire-and-forget ---"
setup_mock_base setup_mock_base
mkdir -p ~/.kugetsu/logs mkdir -p $TEST_KUGETSU_DIR/logs
START=$(date +%s) START=$(date +%s)
OUTPUT=$($KUGETSU delegate "test fire-and-forget" 2>&1 || true) OUTPUT=$($KUGETSU delegate "test fire-and-forget" 2>&1 || true)
END=$(date +%s) END=$(date +%s)
@@ -527,10 +529,10 @@ echo ""
# Test 33: delegate creates log file # Test 33: delegate creates log file
echo "--- Test: delegate creates log file ---" echo "--- Test: delegate creates log file ---"
setup_mock_base setup_mock_base
LOG_COUNT_BEFORE=$(ls ~/.kugetsu/logs/*.log 2>/dev/null | wc -l) LOG_COUNT_BEFORE=$(ls $TEST_KUGETSU_DIR/logs/*.log 2>/dev/null | wc -l)
$KUGETSU delegate "test log file" 2>&1 || true $KUGETSU delegate "test log file" 2>&1 || true
sleep 1 sleep 1
LOG_COUNT_AFTER=$(ls ~/.kugetsu/logs/*.log 2>/dev/null | wc -l) LOG_COUNT_AFTER=$(ls $TEST_KUGETSU_DIR/logs/*.log 2>/dev/null | wc -l)
if [ $LOG_COUNT_AFTER -gt $LOG_COUNT_BEFORE ]; then if [ $LOG_COUNT_AFTER -gt $LOG_COUNT_BEFORE ]; then
pass "delegate creates log file" pass "delegate creates log file"
else else
@@ -558,10 +560,10 @@ echo ""
# Test E2: env set creates file # Test E2: env set creates file
echo "--- Test: env set creates env file ---" echo "--- Test: env set creates env file ---"
mkdir -p ~/.kugetsu/env mkdir -p $TEST_KUGETSU_DIR/env
rm -f ~/.kugetsu/env/pm-agent.env rm -f $TEST_KUGETSU_DIR/env/pm-agent.env
$KUGETSU env set TEST_VAR "test_value" pm-agent 2>&1 || true $KUGETSU env set TEST_VAR "test_value" pm-agent 2>&1 || true
if [ -f ~/.kugetsu/env/pm-agent.env ]; then if [ -f $TEST_KUGETSU_DIR/env/pm-agent.env ]; then
pass "env set creates pm-agent.env file" pass "env set creates pm-agent.env file"
else else
fail "env set did not create pm-agent.env" fail "env set did not create pm-agent.env"
@@ -570,7 +572,7 @@ echo ""
# Test E3: env show masks sensitive values # Test E3: env show masks sensitive values
echo "--- Test: env show masks sensitive values ---" echo "--- Test: env show masks sensitive values ---"
cat > ~/.kugetsu/env/pm-agent.env << 'ENVEOF' cat > $TEST_KUGETSU_DIR/env/pm-agent.env << 'ENVEOF'
export GITEA_TOKEN="secret_token_123" export GITEA_TOKEN="secret_token_123"
export MY_VAR="visible_value" export MY_VAR="visible_value"
ENVEOF ENVEOF
@@ -584,14 +586,14 @@ echo ""
# Test E4: Variables exported to child processes via set -a # Test E4: Variables exported to child processes via set -a
echo "--- Test: set -a exports variables to children ---" echo "--- Test: set -a exports variables to children ---"
mkdir -p ~/.kugetsu/env mkdir -p $TEST_KUGETSU_DIR/env
cat > ~/.kugetsu/env/test.env << 'ENVEOF' cat > $TEST_KUGETSU_DIR/env/test.env << 'ENVEOF'
export EXPORT_TEST="exported_value" export EXPORT_TEST="exported_value"
SIMPLE_TEST="not_exported" SIMPLE_TEST="not_exported"
ENVEOF ENVEOF
# Simulate what cmd_delegate does # Simulate what cmd_delegate does
ENV_FILE="~/.kugetsu/env/test.env" ENV_FILE="$TEST_KUGETSU_DIR/env/test.env"
env_sh="set -a; source '$ENV_FILE'; set +a; " env_sh="set -a; source '$ENV_FILE'; set +a; "
result=$(bash -c "${env_sh}bash -c 'echo \$EXPORT_TEST'") result=$(bash -c "${env_sh}bash -c 'echo \$EXPORT_TEST'")
@@ -604,11 +606,11 @@ echo ""
# Test E5: pm-agent.env takes precedence # Test E5: pm-agent.env takes precedence
echo "--- Test: pm-agent.env takes precedence over default ---" echo "--- Test: pm-agent.env takes precedence over default ---"
mkdir -p ~/.kugetsu/env mkdir -p $TEST_KUGETSU_DIR/env
cat > ~/.kugetsu/env/default.env << 'ENVEOF' cat > $TEST_KUGETSU_DIR/env/default.env << 'ENVEOF'
export GITEA_TOKEN="default_token" export GITEA_TOKEN="default_token"
ENVEOF ENVEOF
cat > ~/.kugetsu/env/pm-agent.env << 'ENVEOF' cat > $TEST_KUGETSU_DIR/env/pm-agent.env << 'ENVEOF'
export GITEA_TOKEN="pm_agent_token" export GITEA_TOKEN="pm_agent_token"
ENVEOF ENVEOF
@@ -644,7 +646,7 @@ fi
echo "" echo ""
# Cleanup env files # Cleanup env files
rm -rf ~/.kugetsu/env 2>/dev/null || true rm -rf $TEST_KUGETSU_DIR/env 2>/dev/null || true
# Test E7: fix_session_permissions function exists # Test E7: fix_session_permissions function exists
echo "--- Test: fix_session_permissions function exists ---" echo "--- Test: fix_session_permissions function exists ---"
@@ -736,7 +738,7 @@ PASS=0
FAIL=0 FAIL=0
test_cleanup() { test_cleanup() {
rm -rf ~/.kugetsu/sessions/* ~/.kugetsu/worktrees/* ~/.kugetsu/index.json ~/.kugetsu/logs/* ~/.kugetsu/.agent_count ~/.kugetsu/.agent_lock 2>/dev/null || true rm -rf $TEST_KUGETSU_DIR/sessions/* $TEST_KUGETSU_DIR/worktrees/* $TEST_KUGETSU_DIR/index.json $TEST_KUGETSU_DIR/logs/* $TEST_KUGETSU_DIR/.agent_count $TEST_KUGETSU_DIR/.agent_lock 2>/dev/null || true
} }
pass() { pass() {
@@ -750,25 +752,25 @@ fail() {
} }
setup_mock_sessions() { setup_mock_sessions() {
mkdir -p ~/.kugetsu/sessions ~/.kugetsu/worktrees ~/.kugetsu/logs mkdir -p $TEST_KUGETSU_DIR/sessions $TEST_KUGETSU_DIR/worktrees $TEST_KUGETSU_DIR/logs
cat > ~/.kugetsu/index.json << INDEX cat > $TEST_KUGETSU_DIR/index.json << INDEX
{ {
"base": "ses_test_base_123", "base": "ses_test_base_123",
"pm_agent": "ses_test_pm_456", "pm_agent": "ses_test_pm_456",
"issues": {} "issues": {}
} }
INDEX INDEX
echo '{"type": "base", "opencode_session_id": "ses_test_base_123", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}' > ~/.kugetsu/sessions/base.json echo '{"type": "base", "opencode_session_id": "ses_test_base_123", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}' > $TEST_KUGETSU_DIR/sessions/base.json
echo '{"type": "pm_agent", "opencode_session_id": "ses_test_pm_456", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}' > ~/.kugetsu/sessions/pm-agent.json echo '{"type": "pm_agent", "opencode_session_id": "ses_test_pm_456", "created_at": "2026-03-29T18:00:00+02:00", "state": "idle"}' > $TEST_KUGETSU_DIR/sessions/pm-agent.json
} }
# Test C1: Agent count file is initialized to 0 # Test C1: Agent count file is initialized to 0
echo "--- Test: agent count file initialized ---" echo "--- Test: agent count file initialized ---"
test_cleanup test_cleanup
mkdir -p ~/.kugetsu/sessions ~/.kugetsu/worktrees mkdir -p $TEST_KUGETSU_DIR/sessions $TEST_KUGETSU_DIR/worktrees
$KUGETSU list > /dev/null 2>&1 || true $KUGETSU list > /dev/null 2>&1 || true
if [ -f ~/.kugetsu/.agent_count ]; then if [ -f $TEST_KUGETSU_DIR/.agent_count ]; then
COUNT=$(cat ~/.kugetsu/.agent_count) COUNT=$(cat $TEST_KUGETSU_DIR/.agent_count)
if [ "$COUNT" = "0" ]; then if [ "$COUNT" = "0" ]; then
pass "agent count file initialized to 0" pass "agent count file initialized to 0"
else else
@@ -795,10 +797,10 @@ test_cleanup
setup_mock_sessions setup_mock_sessions
# Initialize count to 0 # Initialize count to 0
echo 0 > ~/.kugetsu/.agent_count echo 0 > $TEST_KUGETSU_DIR/.agent_count
# Verify initial state # Verify initial state
INITIAL=$(cat ~/.kugetsu/.agent_count) INITIAL=$(cat $TEST_KUGETSU_DIR/.agent_count)
if [ "$INITIAL" = "0" ]; then if [ "$INITIAL" = "0" ]; then
pass "agent count starts at 0" pass "agent count starts at 0"
else else
@@ -809,7 +811,7 @@ fi
$KUGETSU list > /dev/null 2>&1 $KUGETSU list > /dev/null 2>&1
# Verify count is still 0 (no slot leak) # Verify count is still 0 (no slot leak)
AFTER=$(cat ~/.kugetsu/.agent_count) AFTER=$(cat $TEST_KUGETSU_DIR/.agent_count)
if [ "$AFTER" = "0" ]; then if [ "$AFTER" = "0" ]; then
pass "agent count stays 0 after list (no leak)" pass "agent count stays 0 after list (no leak)"
else else