shoko/kugetsu
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix: validate sessions in cmd_status + use isolated test environment #153

Closed
shoko wants to merge 0 commits from fix/issue-148-test-suite-index-corruption into main
pull from: fix/issue-148-test-suite-index-corruption
merge into: shoko:main
Conversation 0 Commits - Files Changed -
shoko commented 2026-04-05 14:11:13 +02:00
Owner
Copy Link

Summary

Fixes issue #148 - Test suite overwrites index.json with fake session IDs.

Changes

  1. cmd_status now validates sessions against opencode

    • Reports error: base session X not found in opencode if base session missing
    • Reports error: pm_agent session X not found in opencode if pm_agent missing
    • Prevents system from appearing to work when sessions are actually broken

  2. Test suite uses isolated environment

    • All tests now use KUGETSU_DIR=/tmp/test-kugetsu-$$ instead of ~/.kugetsu
    • Prevents test suite from corrupting real user data
    • Cleanup removes test directory entirely

Impact

  • kugetsu status will now detect and report when sessions registered in index.json do not actually exist in opencode
  • Test suite no longer affects real ~/.kugetsu directory

Fixes #148

## Summary Fixes issue #148 - Test suite overwrites index.json with fake session IDs. ### Changes 1. **cmd_status now validates sessions against opencode** - Reports `error: base session X not found in opencode` if base session missing - Reports `error: pm_agent session X not found in opencode` if pm_agent missing - Prevents system from appearing to work when sessions are actually broken 2. **Test suite uses isolated environment** - All tests now use `KUGETSU_DIR=/tmp/test-kugetsu-$$` instead of `~/.kugetsu` - Prevents test suite from corrupting real user data - Cleanup removes test directory entirely ### Impact - `kugetsu status` will now detect and report when sessions registered in index.json do not actually exist in opencode - Test suite no longer affects real `~/.kugetsu` directory Fixes #148
shoko added 1 commit 2026-04-05 14:11:14 +02:00
fix: validate sessions in cmd_status + use isolated test environment fd7a98b263 
1. cmd_status now validates session IDs against opencode session list
   - Reports 'error: base session X not found in opencode' if missing
   - Reports 'error: pm_agent session X not found in opencode' if missing

2. Test suite now uses isolated KUGETSU_DIR=/tmp/test-kugetsu-$$
   - All tests use separate test directory instead of ~/.kugetsu
   - Prevents test suite from corrupting real user data
   - Cleanup removes test directory entirely

Fixes #148
shoko added 1 commit 2026-04-05 14:24:12 +02:00
Merge origin/main into fix/issue-148-test-suite-index-corruption (fix CONTRIBUTING.md conflict) 9bb8afe8c5
shoko closed this pull request 2026-04-05 14:25:16 +02:00
shoko deleted branch fix/issue-148-test-suite-index-corruption 2026-04-05 14:25:16 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
0.2.x-only
Available only in 0.2.x, not backportable
 0.3.x-only
Available only in 0.3.x, not backportable
 backport
Backport compatible - can merge to 0.1.x
 blocked
Issue needs clarification/discussion before it can be worked on
 bug
Bug report
 critical
Critical - blocking parallel work
 feature
New feature
 foundation
Foundation work for 0.2.x
 high
High priority - workflow improvements
 meta
Meta issue tracking multiple issues
 need-review
PR needs review before merge
 parallelization
Issues related to parallelization
 ready
Issue is clear and ready to be implemented/delegated
 ready-to-merge
PR approved and ready to merge
 task-delegation
Issues related to task-delegation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#153
Delete Branch "fix/issue-148-test-suite-index-corruption"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?