shoko/kugetsu
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix: remove obsolete slot mechanism (fixes #44) #68

Closed
shoko wants to merge 0 commits from fix/issue-44-remove-obsolete-slot-mechanism into main
pull from: fix/issue-44-remove-obsolete-slot-mechanism
merge into: shoko:main
Conversation 1 Commits - Files Changed -
shoko commented 2026-04-01 09:05:17 +02:00
Owner
Copy Link

Summary

Removed obsolete slot-based concurrency mechanism since session-counting (PR #65) handles the limit properly.

Changes

  1. Removed obsolete slot mechanism:

    • acquire_agent_slot() function
    • release_agent_slot() function
    • AGENT_COUNT_FILE and AGENT_LOCK_FILE variables
    • run_with_limit() function (unused)
    • release-slot.sh script

  2. Updated cmd_delegate: Now uses fire-and-forget without slot management

  3. Consistent concurrency: Both cmd_start and cmd_delegate use count_active_dev_sessions() for session counting

Why

The slot mechanism was a temporary workaround that never worked properly. Session-counting (PR #65) is the proper solution - it counts actual session files and enforces the MAX_CONCURRENT_AGENTS limit reliably.

Fixes #44

## Summary Removed obsolete slot-based concurrency mechanism since session-counting (PR #65) handles the limit properly. ## Changes 1. **Removed obsolete slot mechanism:** - `acquire_agent_slot()` function - `release_agent_slot()` function - `AGENT_COUNT_FILE` and `AGENT_LOCK_FILE` variables - `run_with_limit()` function (unused) - `release-slot.sh` script 2. **Updated `cmd_delegate`:** Now uses fire-and-forget without slot management 3. **Consistent concurrency:** Both `cmd_start` and `cmd_delegate` use `count_active_dev_sessions()` for session counting ## Why The slot mechanism was a temporary workaround that never worked properly. Session-counting (PR #65) is the proper solution - it counts actual session files and enforces the MAX_CONCURRENT_AGENTS limit reliably. Fixes #44
shoko added 1 commit 2026-04-01 09:05:17 +02:00
fix: remove obsolete slot-based concurrency mechanism 4d3205de86 
The session-counting approach (PR #65) now properly handles agent
concurrency limits. Remove the broken slot-based mechanism:

- Remove acquire_agent_slot() and release_agent_slot() functions
- Remove AGENT_COUNT_FILE and AGENT_LOCK_FILE variables
- Remove unused run_with_limit() function
- Remove release-slot.sh script
- Update cmd_delegate to use fire-and-forget without slot management

Both cmd_start and cmd_delegate now use count_active_dev_sessions()
for concurrency checking.
han approved these changes 2026-04-01 09:17:59 +02:00
han left a comment
First-time contributor
Copy Link

lgtm

lgtm
shoko closed this pull request 2026-04-01 10:04:43 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
0.2.x-only
Available only in 0.2.x, not backportable
 0.3.x-only
Available only in 0.3.x, not backportable
 backport
Backport compatible - can merge to 0.1.x
 blocked
Issue needs clarification/discussion before it can be worked on
 bug
Bug report
 critical
Critical - blocking parallel work
 feature
New feature
 foundation
Foundation work for 0.2.x
 high
High priority - workflow improvements
 meta
Meta issue tracking multiple issues
 need-review
PR needs review before merge
 parallelization
Issues related to parallelization
 ready
Issue is clear and ready to be implemented/delegated
 ready-to-merge
PR approved and ready to merge
 task-delegation
Issues related to task-delegation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/kugetsu#68
Delete Branch "fix/issue-44-remove-obsolete-slot-mechanism"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?