shoko/math-notes
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Review: textbook-ch-1-5 - Chapters 1-5 (WIP) #1

Open
shoko wants to merge 3 commits from textbook-ch-1-5 into main
pull from: textbook-ch-1-5
merge into: shoko:main
Conversation 2 Commits 3 Files Changed 26 +56
shoko commented 2026-03-15 18:13:14 +01:00
Owner
Copy Link

Review Comments

Structure: Good

  • textbooks/elliptic-curves-prasma/ with chapter files following ch##, ch##_##, ch##_##_## pattern ✓
  • index.md with proper frontmatter (title, author, year) ✓

Chapter 1: Looks solid

  • Clear intro explaining the gap this textbook fills (ML vs elliptic curves math)
  • Self-contained, rigorous, elementary approach promised
  • Good: avoids Galois theory/algebraic geometry — appropriate for engineers

Suggestions for Ch1

  1. Add brief outline of what chapters 2-5 cover so readers know the roadmap
  2. Consider adding a ## References section if the chapter grows

Notes

  • Chapters 2-5 are currently empty placeholders (expected for WIP)
  • Format is clean and consistent

Review by Shoko

## Review Comments ### Structure: Good - `textbooks/elliptic-curves-prasma/` with chapter files following `ch##`, `ch##_##`, `ch##_##_##` pattern ✓ - `index.md` with proper frontmatter (title, author, year) ✓ ### Chapter 1: Looks solid - Clear intro explaining the gap this textbook fills (ML vs elliptic curves math) - Self-contained, rigorous, elementary approach promised - Good: avoids Galois theory/algebraic geometry — appropriate for engineers ### Suggestions for Ch1 1. Add brief outline of what chapters 2-5 cover so readers know the roadmap 2. Consider adding a ## References section if the chapter grows ### Notes - Chapters 2-5 are currently empty placeholders (expected for WIP) - Format is clean and consistent --- *Review by Shoko*
shoko added 1 commit 2026-03-15 18:13:15 +01:00
feat: add elliptic curve ch01 6f15d54a5c
han commented 2026-03-15 18:15:28 +01:00
Collaborator
Copy Link

@shoko can you assign me in this PR as assignees? and assign yourself as reviewer. I will start working on the rest of chapters, then fix your review

@shoko can you assign me in this PR as assignees? and assign yourself as reviewer. I will start working on the rest of chapters, then fix your review
shoko commented 2026-03-15 18:16:45 +01:00
Author
Owner
Copy Link

Done! Assigned han as assignee.

I cannot request myself as reviewer (Gitea wont let the PR author review their own PR), but I will keep an eye on it. Just ping me when you want me to re-review.

Good luck with chapters 2-5! 🚀

Done! Assigned han as assignee. I cannot request myself as reviewer (Gitea wont let the PR author review their own PR), but I will keep an eye on it. Just ping me when you want me to re-review. Good luck with chapters 2-5! 🚀
shoko added 1 commit 2026-03-15 18:46:12 +01:00
Add ch02_01 Set Theory (sample conversion from PDF) 510417ef30
shoko added 1 commit 2026-03-18 19:04:22 +01:00
Add preface with motivation and resources dcd26a7f09
This pull request has changes conflicting with the target branch.
  • preface.md
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin textbook-ch-1-5:textbook-ch-1-5
git checkout textbook-ch-1-5
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
han shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/math-notes#1
Delete Branch "textbook-ch-1-5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?