shoko/randebu
1
0
Fork 0
Code Issues 6 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: consolidate AveCloudClient to single implementation #37

Merged
shoko merged 1 commits from fix/issue-29 into main 2026-04-09 12:11:59 +02:00
Conversation 1 Commits 1 Files Changed 4 +18 -72
shoko commented 2026-04-09 12:07:00 +02:00
Owner
Copy Link

Summary

  • Consolidate duplicate AveCloudClient class into single location at services/ave/client.py
  • Add missing get_token_price method to full implementation
  • Update both simulate and backtest engines to import from correct location

Changes

  1. Added get_token_price method to services/ave/client.py
  2. Updated services/simulate/engine.py to import from ..ave.client
  3. Updated services/backtest/engine.py to import from ..ave.client
  4. Deleted services/backtest/ave_client.py (duplicate)

Acceptance Criteria

  • Single AveCloudClient class exists in services/ave/client.py
  • All methods needed by backtest and simulate engines are available
  • Simulate engine imports from correct location
  • services/backtest/ave_client.py is deleted

Fixes #29

## Summary - Consolidate duplicate AveCloudClient class into single location at services/ave/client.py - Add missing get_token_price method to full implementation - Update both simulate and backtest engines to import from correct location ## Changes 1. Added get_token_price method to services/ave/client.py 2. Updated services/simulate/engine.py to import from ..ave.client 3. Updated services/backtest/engine.py to import from ..ave.client 4. Deleted services/backtest/ave_client.py (duplicate) ## Acceptance Criteria - [x] Single AveCloudClient class exists in services/ave/client.py - [x] All methods needed by backtest and simulate engines are available - [x] Simulate engine imports from correct location - [x] services/backtest/ave_client.py is deleted --- Fixes #29
shoko added 1 commit 2026-04-09 12:07:01 +02:00
fix: consolidate AveCloudClient to single implementation in services/ave/client.py 405b35c3ba
han approved these changes 2026-04-09 12:10:54 +02:00
han left a comment
First-time contributor
Copy Link

lgtm

lgtm
shoko merged commit 6adad0701d into main 2026-04-09 12:11:59 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
han
Labels
Clear labels
AI/ML
AI or ML related tasks
 backend
Backend related tasks
 enhancement
Feature or enhancement
 frontend
Frontend related tasks
 infrastructure
Infrastructure or deployment
 meta
Meta issue for tracking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shoko
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shoko/randebu#37
Delete Branch "fix/issue-29"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?