• Joined on 2026-03-13
shoko commented on pull request shoko/jigaido#20 2026-04-03 01:58:39 +02:00
Add core/ports.py - Storage interfaces

Addressed all feedback:

1. PersonalStorage removed

You are right - PersonalStorage was redundant. RoomStorage handles both group and personal bounties via room_id:

  • Negative room_id =…
shoko pushed to feat/issue-6-storage-ports at shoko/jigaido 2026-04-03 01:57:57 +02:00
43603659de Address PR #20 feedback:
shoko created pull request shoko/jigaido#20 2026-04-03 00:40:26 +02:00
Add core/ports.py - Storage interfaces
shoko created branch feat/issue-6-storage-ports in shoko/jigaido 2026-04-03 00:40:18 +02:00
shoko pushed to feat/issue-6-storage-ports at shoko/jigaido 2026-04-03 00:40:18 +02:00
5450d12400 Add core/ports.py - Storage interfaces
shoko pushed to main at shoko/jigaido 2026-04-03 00:37:31 +02:00
ddd44cb593 Merge pull request 'feat(core): implement domain dataclasses for issue #5' (#19) from feat/issue-5-core-models into main
b2854393ae Address PR #19 review feedback round 3:
330203e6ef Address PR #19 review feedback round 2:
f1ef33451c Address PR #19 review feedback: simplify models
db09a518d1 feat(core): implement domain dataclasses for issue #5
Compare 5 commits »
shoko merged pull request shoko/jigaido#19 2026-04-03 00:37:30 +02:00
feat(core): implement domain dataclasses for issue #5
shoko closed issue shoko/jigaido#5 2026-04-03 00:37:30 +02:00
[Phase 1] Task 1: Create core/models.py — Domain dataclasses
shoko commented on pull request shoko/jigaido#19 2026-04-03 00:34:38 +02:00
feat(core): implement domain dataclasses for issue #5

Addressed latest feedback:

  1. TrackingData.group_id renamed to room_id - now works for both group (negative) and DM (positive) contexts

  2. Removed room_id from TrackedBounty - it is now…

shoko pushed to feat/issue-5-core-models at shoko/jigaido 2026-04-03 00:34:26 +02:00
b2854393ae Address PR #19 review feedback round 3:
shoko commented on pull request shoko/jigaido#19 2026-04-03 00:24:30 +02:00
feat(core): implement domain dataclasses for issue #5

Addressed remaining feedback:

  1. Bounty.created_by_user_id is now non-optional - always required, indicates who created the bounty (not group vs personal)

  2. **RoomData no longer has…

shoko pushed to feat/issue-5-core-models at shoko/jigaido 2026-04-03 00:24:18 +02:00
330203e6ef Address PR #19 review feedback round 2:
shoko commented on pull request shoko/jigaido#19 2026-04-02 23:48:04 +02:00
feat(core): implement domain dataclasses for issue #5

Addressed all review feedback:

  1. Removed GroupBounty/PersonalBounty subclasses - now using Bounty with optional created_by_user_id field. If set, it is a group bounty; if None, it is a…
shoko pushed to feat/issue-5-core-models at shoko/jigaido 2026-04-02 23:47:34 +02:00
f1ef33451c Address PR #19 review feedback: simplify models
shoko merged pull request shoko/jigaido#18 2026-04-02 23:43:57 +02:00
feat(config): implement configuration management
shoko closed issue shoko/jigaido#7 2026-04-02 23:43:57 +02:00
[Phase 1] Task 3: Create config.py — Configuration management
shoko pushed to main at shoko/jigaido 2026-04-02 23:43:57 +02:00
5aebb5a814 Merge pull request 'feat(config): implement configuration management' (#18) from feat/issue-7-config into main
9b8b15414f feat(config): implement configuration management for issue #7
Compare 2 commits »
shoko commented on pull request shoko/jigaido#19 2026-04-02 23:28:34 +02:00
feat(core): implement domain dataclasses for issue #5

Test results for feat/issue-5-core-models:

============================= test session starts ==============================
platform linux -- Python 3.14.3, pytest-8.3.5, pluggy-1.6.0
plugins:…
shoko commented on pull request shoko/jigaido#18 2026-04-02 23:04:22 +02:00
feat(config): implement configuration management

Test results for feat/issue-7-config:

============================= test session starts ==============================
platform linux -- Python 3.14.3, pytest-8.3.5, pluggy-1.6.0
plugins:…
shoko created pull request shoko/jigaido#19 2026-04-02 22:45:25 +02:00
feat(core): implement domain dataclasses for issue #5