• Joined on 2026-03-13
shoko closed issue shoko/jigaido#9 2026-04-03 10:26:18 +02:00
[Phase 1] Task 5: Create adapters/storage/json_file.py — JSON file adapter
shoko pushed to feat/issue-8-services at shoko/jigaido 2026-04-03 10:26:11 +02:00
932bbc5b63 fix(core): update services to match issue #8 requirements
shoko closed pull request shoko/jigaido#23 2026-04-03 10:21:35 +02:00
feat(core): implement services for issue #8
shoko closed pull request shoko/jigaido#22 2026-04-03 10:21:34 +02:00
feat(adapter): implement JSON file storage adapter for issue #9
shoko created pull request shoko/jigaido#23 2026-04-03 10:09:49 +02:00
feat(core): implement services for issue #8
shoko created pull request shoko/jigaido#22 2026-04-03 10:08:37 +02:00
feat(adapter): implement JSON file storage adapter for issue #9
shoko created branch feat/issue-9-json-storage in shoko/jigaido 2026-04-03 10:08:23 +02:00
shoko pushed to feat/issue-9-json-storage at shoko/jigaido 2026-04-03 10:08:23 +02:00
shoko pushed to feat/issue-6-storage-ports at shoko/jigaido 2026-04-03 10:07:08 +02:00
af8eb90563 feat(adapter): implement JSON file storage adapter
shoko closed pull request shoko/jigaido#21 2026-04-03 09:47:39 +02:00
feat(core): implement services for issue #8
shoko created pull request shoko/jigaido#21 2026-04-03 09:39:16 +02:00
feat(core): implement services for issue #8
shoko created branch feat/issue-8-services in shoko/jigaido 2026-04-03 09:39:06 +02:00
shoko pushed to feat/issue-8-services at shoko/jigaido 2026-04-03 09:39:06 +02:00
c3634c5edb feat(core): implement services for issue #8
shoko closed issue shoko/jigaido#1 2026-04-03 09:03:54 +02:00
Clarifying Questions — Pre-implementation Review
shoko merged pull request shoko/jigaido#20 2026-04-03 08:58:30 +02:00
Add core/ports.py - Storage interfaces
shoko closed issue shoko/jigaido#6 2026-04-03 08:58:30 +02:00
[Phase 1] Task 2: Create core/ports.py — Storage interfaces
shoko pushed to main at shoko/jigaido 2026-04-03 08:58:30 +02:00
8aebb763ee Merge pull request 'Add core/ports.py - Storage interfaces' (#20) from feat/issue-6-storage-ports into main
a237810dd2 Remove ensure_room/ensure_tracking from Protocol - tests prove not needed
43603659de Address PR #20 feedback:
5450d12400 Add core/ports.py - Storage interfaces
Compare 4 commits »
shoko commented on pull request shoko/jigaido#20 2026-04-03 08:54:38 +02:00
Add core/ports.py - Storage interfaces

Confirmed - ensure_room() and ensure_tracking() have already been removed from the Protocol definitions in the previous commit.

Current Protocols:

RoomStorage: load, save, add_bounty,…

shoko commented on pull request shoko/jigaido#20 2026-04-03 08:49:24 +02:00
Add core/ports.py - Storage interfaces

Added tests with SimpleRoomStorage and SimpleTrackingStorage (no ensure_* methods):

Test Result: 20 passed, 1 warning

Key findings:

  • SimpleRoomStorage (without ensure_room()) -…
shoko pushed to feat/issue-6-storage-ports at shoko/jigaido 2026-04-03 08:49:01 +02:00
a237810dd2 Remove ensure_room/ensure_tracking from Protocol - tests prove not needed