Compare commits
34 Commits
fix/issue-
...
fix/issue-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6a933742cb | ||
| b554a81979 | |||
|
|
350ecbf867 | ||
| 28241eaf61 | |||
|
|
8db5ba0ba4 | ||
| a727751978 | |||
|
|
90b0b564c2 | ||
| 003c570cfb | |||
|
|
bac6830fc3 | ||
| 2dd11a8b48 | |||
|
|
2617d17e28 | ||
| b091153f10 | |||
|
|
ce864d9fdc | ||
| e805a6428a | |||
|
|
6da16e752b | ||
| e3b813661d | |||
| bdb0f3cd8b | |||
|
|
649b1ffbd3 | ||
|
|
b8f6b98836 | ||
|
|
c005ee341a | ||
| 922858a81a | |||
|
|
f521a682c5 | ||
| 015df15bd5 | |||
|
|
eed3ab33ae | ||
| bd2627efe9 | |||
|
|
8069ed6465 | ||
|
|
d38d47fb79 | ||
|
|
a06e1327fb | ||
|
|
780cba6301 | ||
| 42ed551554 | |||
|
|
af7774ef03 | ||
| 0a64b4f310 | |||
|
|
ed0d31bc04 | ||
| d413f6ce13 |
@@ -140,6 +140,35 @@ class JsonFileRoomStorage:
|
|||||||
|
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
|
"""List all non-deleted bounties in a room.
|
||||||
|
|
||||||
|
This is the default method for normal queries - soft-deleted bounties
|
||||||
|
are excluded from results.
|
||||||
|
"""
|
||||||
|
room_data = self.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return []
|
||||||
|
return [b for b in room_data.bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
def list_all_bounties(
|
||||||
|
self, room_id: int, include_deleted: bool = True
|
||||||
|
) -> list[Bounty]:
|
||||||
|
"""List all bounties including or excluding soft-deleted.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
room_id: The room ID
|
||||||
|
include_deleted: If True, return all bounties including soft-deleted.
|
||||||
|
If False, return only non-deleted bounties.
|
||||||
|
Defaults to True for /recover functionality.
|
||||||
|
"""
|
||||||
|
room_data = self.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return []
|
||||||
|
if include_deleted:
|
||||||
|
return room_data.bounties
|
||||||
|
return [b for b in room_data.bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
|
||||||
class JsonFileTrackingStorage:
|
class JsonFileTrackingStorage:
|
||||||
"""TrackingStorage implementation using JSON files.
|
"""TrackingStorage implementation using JSON files.
|
||||||
|
|||||||
@@ -8,12 +8,16 @@ from telegram.ext import Application, CommandHandler, MessageHandler, filters
|
|||||||
|
|
||||||
from commands import (
|
from commands import (
|
||||||
cmd_add,
|
cmd_add,
|
||||||
|
cmd_admin,
|
||||||
cmd_bounty,
|
cmd_bounty,
|
||||||
cmd_delete,
|
cmd_delete,
|
||||||
cmd_edit,
|
cmd_edit,
|
||||||
cmd_help,
|
cmd_help,
|
||||||
cmd_my,
|
cmd_my,
|
||||||
|
cmd_recover,
|
||||||
|
cmd_show,
|
||||||
cmd_start,
|
cmd_start,
|
||||||
|
cmd_timezone,
|
||||||
cmd_track,
|
cmd_track,
|
||||||
cmd_untrack,
|
cmd_untrack,
|
||||||
cmd_update,
|
cmd_update,
|
||||||
@@ -41,6 +45,10 @@ def build_app() -> Application:
|
|||||||
app.add_handler(CommandHandler("delete", cmd_delete))
|
app.add_handler(CommandHandler("delete", cmd_delete))
|
||||||
app.add_handler(CommandHandler("track", cmd_track))
|
app.add_handler(CommandHandler("track", cmd_track))
|
||||||
app.add_handler(CommandHandler("untrack", cmd_untrack))
|
app.add_handler(CommandHandler("untrack", cmd_untrack))
|
||||||
|
app.add_handler(CommandHandler("show", cmd_show))
|
||||||
|
app.add_handler(CommandHandler("timezone", cmd_timezone))
|
||||||
|
app.add_handler(CommandHandler("admin", cmd_admin))
|
||||||
|
app.add_handler(CommandHandler("recover", cmd_recover))
|
||||||
|
|
||||||
app.add_handler(MessageHandler(filters.COMMAND, cmd_help))
|
app.add_handler(MessageHandler(filters.COMMAND, cmd_help))
|
||||||
|
|
||||||
@@ -56,6 +64,10 @@ async def post_init(app: Application) -> None:
|
|||||||
("edit", "Edit a bounty"),
|
("edit", "Edit a bounty"),
|
||||||
("track", "Track a bounty"),
|
("track", "Track a bounty"),
|
||||||
("untrack", "Stop tracking"),
|
("untrack", "Stop tracking"),
|
||||||
|
("show", "Show bounty details"),
|
||||||
|
("timezone", "Get/set room timezone"),
|
||||||
|
("admin", "Manage admins"),
|
||||||
|
("recover", "Recover deleted bounties"),
|
||||||
("help", "Show help"),
|
("help", "Show help"),
|
||||||
]
|
]
|
||||||
)
|
)
|
||||||
|
|||||||
@@ -1,8 +1,10 @@
|
|||||||
"""Telegram command handlers for JIGAIDO - Thin wrappers around core services."""
|
"""Telegram command handlers for JIGAIDO - Thin wrappers around core services."""
|
||||||
|
|
||||||
import time
|
import time
|
||||||
|
from datetime import datetime, timezone
|
||||||
from functools import wraps
|
from functools import wraps
|
||||||
from typing import Optional
|
from typing import Optional
|
||||||
|
from zoneinfo import ZoneInfo, ZoneInfoNotFoundError
|
||||||
|
|
||||||
import dateparser
|
import dateparser
|
||||||
from telegram import Update
|
from telegram import Update
|
||||||
@@ -19,6 +21,34 @@ TRACKING_SERVICE = TrackingService(TRACKING_STORAGE, ROOM_STORAGE)
|
|||||||
TELEGRAM_BOT_USERNAME = "your_bot_username"
|
TELEGRAM_BOT_USERNAME = "your_bot_username"
|
||||||
|
|
||||||
|
|
||||||
|
def format_due_date(due_date_ts: int | None, timezone_str: str) -> str:
|
||||||
|
"""Format due date as human-readable with timezone.
|
||||||
|
|
||||||
|
Examples:
|
||||||
|
No due date: (none shown)
|
||||||
|
Date only: 4 April 2026
|
||||||
|
Date + time: 4 April 2026 14:30
|
||||||
|
With timezone: 4 April 2026 14:30 (Asia/Jakarta)
|
||||||
|
"""
|
||||||
|
if not due_date_ts:
|
||||||
|
return ""
|
||||||
|
|
||||||
|
try:
|
||||||
|
tz = ZoneInfo(timezone_str)
|
||||||
|
except (KeyError, ZoneInfoNotFoundError):
|
||||||
|
tz = ZoneInfo("UTC")
|
||||||
|
|
||||||
|
dt = datetime.fromtimestamp(due_date_ts, tz=tz)
|
||||||
|
|
||||||
|
date_str = dt.strftime("%-d %B %Y")
|
||||||
|
|
||||||
|
if dt.hour != 0 or dt.minute != 0:
|
||||||
|
date_str += f" {dt.strftime('%H:%M')}"
|
||||||
|
date_str += f" ({timezone_str})"
|
||||||
|
|
||||||
|
return date_str
|
||||||
|
|
||||||
|
|
||||||
def extract_args(text: str) -> list[str]:
|
def extract_args(text: str) -> list[str]:
|
||||||
if not text:
|
if not text:
|
||||||
return []
|
return []
|
||||||
@@ -26,47 +56,84 @@ def extract_args(text: str) -> list[str]:
|
|||||||
return tokens[1:] if len(tokens) > 1 else []
|
return tokens[1:] if len(tokens) > 1 else []
|
||||||
|
|
||||||
|
|
||||||
def parse_args(args: list[str]) -> tuple[Optional[str], Optional[str], Optional[int]]:
|
def parse_args(
|
||||||
|
args: list[str],
|
||||||
|
) -> tuple[Optional[str], Optional[str], Optional[int], bool, bool]:
|
||||||
text = None
|
text = None
|
||||||
link = None
|
link = None
|
||||||
due_date_ts = None
|
due_date_ts = None
|
||||||
|
clear_link = False
|
||||||
|
clear_date = False
|
||||||
|
|
||||||
remaining = []
|
i = 0
|
||||||
for arg in args:
|
while i < len(args):
|
||||||
if not link and (arg.startswith("http://") or arg.startswith("https://")):
|
arg = args[i]
|
||||||
|
|
||||||
|
if arg == "-link":
|
||||||
|
if i + 1 < len(args) and (
|
||||||
|
args[i + 1].startswith("http://") or args[i + 1].startswith("https://")
|
||||||
|
):
|
||||||
|
link = args[i + 1]
|
||||||
|
i += 2
|
||||||
|
else:
|
||||||
|
clear_link = True
|
||||||
|
i += 1
|
||||||
|
elif arg == "-date":
|
||||||
|
if i + 1 < len(args):
|
||||||
|
parsed = dateparser.parse(args[i + 1])
|
||||||
|
if parsed:
|
||||||
|
due_date_ts = int(parsed.timestamp())
|
||||||
|
i += 2
|
||||||
|
else:
|
||||||
|
clear_date = True
|
||||||
|
i += 1
|
||||||
|
else:
|
||||||
|
clear_date = True
|
||||||
|
i += 1
|
||||||
|
elif not link and (arg.startswith("http://") or arg.startswith("https://")):
|
||||||
link = arg
|
link = arg
|
||||||
|
i += 1
|
||||||
elif due_date_ts is None:
|
elif due_date_ts is None:
|
||||||
parsed = dateparser.parse(arg)
|
parsed = dateparser.parse(arg)
|
||||||
if parsed:
|
if parsed:
|
||||||
due_date_ts = int(parsed.timestamp())
|
due_date_ts = int(parsed.timestamp())
|
||||||
|
i += 1
|
||||||
else:
|
else:
|
||||||
remaining.append(arg)
|
i += 1
|
||||||
|
if text is None:
|
||||||
|
text = arg
|
||||||
else:
|
else:
|
||||||
remaining.append(arg)
|
text = text + " " + arg
|
||||||
|
else:
|
||||||
|
i += 1
|
||||||
|
if text is None:
|
||||||
|
text = arg
|
||||||
|
else:
|
||||||
|
text = text + " " + arg
|
||||||
|
|
||||||
text = " ".join(remaining) if remaining else None
|
return text, link, due_date_ts, clear_link, clear_date
|
||||||
return text, link, due_date_ts
|
|
||||||
|
|
||||||
|
|
||||||
def format_bounty(b, show_id: bool = True) -> str:
|
def format_bounty(b, show_id: bool = True, slice_length: int = 0) -> str:
|
||||||
parts = []
|
parts = []
|
||||||
if show_id:
|
if show_id:
|
||||||
parts.append(f"[#{b.id}]")
|
parts.append(f"[#{b.id}]")
|
||||||
if b.text:
|
if b.text:
|
||||||
parts.append(b.text)
|
text = b.text
|
||||||
|
if slice_length > 0 and len(text) > slice_length:
|
||||||
|
text = text[:slice_length] + "..."
|
||||||
|
parts.append(text)
|
||||||
if b.link:
|
if b.link:
|
||||||
parts.append(f"🔗 {b.link}")
|
parts.append(f"🔗 {b.link}")
|
||||||
if b.due_date_ts:
|
if b.due_date_ts:
|
||||||
due_str = time.strftime("%Y-%m-%d", time.localtime(b.due_date_ts))
|
due_str = time.strftime("%d %b %Y", time.localtime(b.due_date_ts))
|
||||||
days_left = (b.due_date_ts - int(time.time())) // 86400
|
days_left = (b.due_date_ts - int(time.time())) // 86400
|
||||||
if days_left < 0:
|
if days_left < 0:
|
||||||
parts.append(f"⏰ {due_str} (OVERDUE)")
|
parts.append(f"⏰ {due_str} (OVERDUE)")
|
||||||
elif days_left == 0:
|
elif days_left == 0:
|
||||||
parts.append(f"⏰ {due_str} (TODAY)")
|
parts.append(f"⏰ Today (OVERDUE)")
|
||||||
else:
|
else:
|
||||||
parts.append(f"⏰ {due_str} ({days_left}d)")
|
parts.append(f"⏰ {due_str} ({days_left}d)")
|
||||||
if b.created_by_user_id:
|
|
||||||
parts.append(f"by {b.created_by_user_id}")
|
|
||||||
return " | ".join(parts)
|
return " | ".join(parts)
|
||||||
|
|
||||||
|
|
||||||
@@ -95,13 +162,58 @@ def get_room_id(update: Update) -> int:
|
|||||||
|
|
||||||
async def cmd_bounty(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_bounty(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
args = extract_args(update.message.text)
|
||||||
|
|
||||||
if not bounties:
|
show_all = "all" in args
|
||||||
|
args = [a for a in args if a != "all"]
|
||||||
|
|
||||||
|
try:
|
||||||
|
limit = int(args[0]) if args else 5
|
||||||
|
except (ValueError, IndexError):
|
||||||
|
limit = 5
|
||||||
|
|
||||||
|
now = int(time.time())
|
||||||
|
cutoff_24h = now - 86400
|
||||||
|
|
||||||
|
all_bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
||||||
|
|
||||||
|
def is_expired(b) -> bool:
|
||||||
|
return b.due_date_ts is not None and b.due_date_ts < cutoff_24h
|
||||||
|
|
||||||
|
def sort_key(b):
|
||||||
|
if b.due_date_ts is not None:
|
||||||
|
return (0, b.due_date_ts)
|
||||||
|
return (1, b.created_at)
|
||||||
|
|
||||||
|
filtered_bounties = [b for b in all_bounties if not is_expired(b) or show_all]
|
||||||
|
filtered_bounties.sort(key=sort_key)
|
||||||
|
|
||||||
|
total_count = len(filtered_bounties)
|
||||||
|
displayed_bounties = filtered_bounties[:limit]
|
||||||
|
|
||||||
|
if not displayed_bounties:
|
||||||
|
if show_all:
|
||||||
await update.message.reply_text("No bounties yet.")
|
await update.message.reply_text("No bounties yet.")
|
||||||
|
else:
|
||||||
|
await update.message.reply_text(
|
||||||
|
"No active bounties. Use /bounty all to show expired."
|
||||||
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
lines = [format_bounty(b, show_id=True) for b in bounties]
|
lines = []
|
||||||
|
if limit < total_count:
|
||||||
|
lines.append(f"Showing {limit} of {total_count} bounties:")
|
||||||
|
slice_length = 40
|
||||||
|
elif show_all and total_count > limit:
|
||||||
|
lines.append(f"Showing {limit} of {total_count} bounties (including expired):")
|
||||||
|
slice_length = 40
|
||||||
|
else:
|
||||||
|
lines.append(f"Showing {total_count} bounties:")
|
||||||
|
slice_length = 0
|
||||||
|
|
||||||
|
for b in displayed_bounties:
|
||||||
|
lines.append(format_bounty(b, show_id=True, slice_length=slice_length))
|
||||||
|
|
||||||
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
||||||
|
|
||||||
|
|
||||||
@@ -111,6 +223,7 @@ async def cmd_my(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
if is_group(update):
|
if is_group(update):
|
||||||
group_id = get_group_id(update)
|
group_id = get_group_id(update)
|
||||||
bounties = TRACKING_SERVICE.get_tracked_bounties(group_id, user_id)
|
bounties = TRACKING_SERVICE.get_tracked_bounties(group_id, user_id)
|
||||||
|
room_id = group_id
|
||||||
else:
|
else:
|
||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
||||||
@@ -137,7 +250,7 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
)
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
text, link, due_date_ts = parse_args(args)
|
text, link, due_date_ts, _, _ = parse_args(args)
|
||||||
if not text and not link:
|
if not text and not link:
|
||||||
await update.message.reply_text("A bounty needs at least text or a link.")
|
await update.message.reply_text("A bounty needs at least text or a link.")
|
||||||
return
|
return
|
||||||
@@ -145,6 +258,7 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
user_id = get_user_id(update)
|
user_id = get_user_id(update)
|
||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
|
|
||||||
|
try:
|
||||||
bounty = BOUNTY_SERVICE.add_bounty(
|
bounty = BOUNTY_SERVICE.add_bounty(
|
||||||
room_id=room_id,
|
room_id=room_id,
|
||||||
user_id=user_id,
|
user_id=user_id,
|
||||||
@@ -152,11 +266,17 @@ async def cmd_add(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
link=link,
|
link=link,
|
||||||
due_date_ts=due_date_ts,
|
due_date_ts=due_date_ts,
|
||||||
)
|
)
|
||||||
|
except PermissionError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
return
|
||||||
|
except ValueError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
return
|
||||||
|
|
||||||
due_str = ""
|
due_str = ""
|
||||||
if due_date_ts:
|
if due_date_ts:
|
||||||
due_str = f" | Due: {time.strftime('%Y-%m-%d', time.localtime(due_date_ts))}"
|
timezone_str = BOUNTY_SERVICE.get_timezone(room_id)
|
||||||
|
due_str = f" | Due: {format_due_date(due_date_ts, timezone_str)}"
|
||||||
await update.message.reply_text(
|
await update.message.reply_text(
|
||||||
f"✅ Bounty added (#{bounty.id}){due_str}",
|
f"✅ Bounty added (#{bounty.id}){due_str}",
|
||||||
disable_web_page_preview=True,
|
disable_web_page_preview=True,
|
||||||
@@ -167,7 +287,14 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
args = extract_args(update.message.text)
|
args = extract_args(update.message.text)
|
||||||
if len(args) < 1:
|
if len(args) < 1:
|
||||||
await update.message.reply_text(
|
await update.message.reply_text(
|
||||||
"Usage: /update <bounty_id> [text] [link] [due_date]"
|
"Usage: /update <bounty_id> [text] [link] [due_date]\n"
|
||||||
|
" /update <bounty_id> -link [<url>] - clear or set link\n"
|
||||||
|
" /update <bounty_id> -date [<date>] - clear or set date\n"
|
||||||
|
"Examples:\n"
|
||||||
|
" /update 1 new text - update text only\n"
|
||||||
|
" /update 1 -link - clear link\n"
|
||||||
|
" /update 1 -link https://... - set link\n"
|
||||||
|
" /update 1 -link -date - clear both link and date"
|
||||||
)
|
)
|
||||||
return
|
return
|
||||||
|
|
||||||
@@ -177,8 +304,14 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
await update.message.reply_text("Invalid bounty ID.")
|
await update.message.reply_text("Invalid bounty ID.")
|
||||||
return
|
return
|
||||||
|
|
||||||
text, link, due_date_ts = parse_args(args[1:])
|
text, link, due_date_ts, clear_link, clear_date = parse_args(args[1:])
|
||||||
if not text and not link and due_date_ts is None:
|
if (
|
||||||
|
not text
|
||||||
|
and not link
|
||||||
|
and due_date_ts is None
|
||||||
|
and not clear_link
|
||||||
|
and not clear_date
|
||||||
|
):
|
||||||
await update.message.reply_text("Nothing to update.")
|
await update.message.reply_text("Nothing to update.")
|
||||||
return
|
return
|
||||||
|
|
||||||
@@ -193,10 +326,15 @@ async def cmd_update(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
text=text,
|
text=text,
|
||||||
link=link,
|
link=link,
|
||||||
due_date_ts=due_date_ts,
|
due_date_ts=due_date_ts,
|
||||||
|
clear_link=clear_link,
|
||||||
|
clear_due=clear_date,
|
||||||
)
|
)
|
||||||
except PermissionError as e:
|
except PermissionError as e:
|
||||||
await update.message.reply_text(f"⛔ {e}")
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
return
|
return
|
||||||
|
except ValueError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
return
|
||||||
|
|
||||||
if success:
|
if success:
|
||||||
await update.message.reply_text(f"✅ Bounty #{bounty_id} updated.")
|
await update.message.reply_text(f"✅ Bounty #{bounty_id} updated.")
|
||||||
@@ -210,11 +348,11 @@ cmd_edit = cmd_update
|
|||||||
async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
args = extract_args(update.message.text)
|
args = extract_args(update.message.text)
|
||||||
if not args:
|
if not args:
|
||||||
await update.message.reply_text("Usage: /delete <bounty_id>")
|
await update.message.reply_text("Usage: /delete <bounty_id> [bounty_id ...]")
|
||||||
return
|
return
|
||||||
|
|
||||||
try:
|
try:
|
||||||
bounty_id = int(args[0])
|
bounty_ids = [int(arg) for arg in args]
|
||||||
except ValueError:
|
except ValueError:
|
||||||
await update.message.reply_text("Invalid bounty ID.")
|
await update.message.reply_text("Invalid bounty ID.")
|
||||||
return
|
return
|
||||||
@@ -223,19 +361,25 @@ async def cmd_delete(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
room_id = get_room_id(update)
|
room_id = get_room_id(update)
|
||||||
|
|
||||||
try:
|
try:
|
||||||
success = BOUNTY_SERVICE.delete_bounty(
|
results = BOUNTY_SERVICE.delete_bounties(
|
||||||
room_id=room_id,
|
room_id=room_id,
|
||||||
bounty_id=bounty_id,
|
bounty_ids=bounty_ids,
|
||||||
user_id=user_id,
|
user_id=user_id,
|
||||||
)
|
)
|
||||||
except PermissionError as e:
|
except PermissionError as e:
|
||||||
await update.message.reply_text(f"⛔ {e}")
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
return
|
return
|
||||||
|
|
||||||
if success:
|
response_lines = []
|
||||||
await update.message.reply_text(f"✅ Bounty #{bounty_id} deleted.")
|
for bounty_id, result in results.items():
|
||||||
else:
|
if result == "deleted":
|
||||||
await update.message.reply_text("Bounty not found.")
|
response_lines.append(f"✅ Bounty #{bounty_id} deleted.")
|
||||||
|
elif result == "not_found":
|
||||||
|
response_lines.append(f"⛔ Bounty #{bounty_id} not found.")
|
||||||
|
elif result == "permission_denied":
|
||||||
|
response_lines.append(f"⛔ Bounty #{bounty_id} permission denied.")
|
||||||
|
|
||||||
|
await update.message.reply_text("\n".join(response_lines))
|
||||||
|
|
||||||
|
|
||||||
async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_track(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
@@ -311,16 +455,241 @@ async def cmd_start(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
async def cmd_show(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
|
args = extract_args(update.message.text)
|
||||||
|
if not args:
|
||||||
|
await update.message.reply_text("Usage: /show <bounty_id>")
|
||||||
|
return
|
||||||
|
|
||||||
|
try:
|
||||||
|
bounty_id = int(args[0])
|
||||||
|
except ValueError:
|
||||||
|
await update.message.reply_text("Invalid bounty ID.")
|
||||||
|
return
|
||||||
|
|
||||||
|
room_id = get_room_id(update)
|
||||||
|
bounty = BOUNTY_SERVICE.get_bounty(room_id, bounty_id)
|
||||||
|
|
||||||
|
if not bounty:
|
||||||
|
await update.message.reply_text("Bounty not found.")
|
||||||
|
return
|
||||||
|
|
||||||
|
timezone = BOUNTY_SERVICE.get_timezone(room_id)
|
||||||
|
|
||||||
|
lines = []
|
||||||
|
|
||||||
|
title = bounty.text or "(no text)"
|
||||||
|
lines.append(f"[#{bounty.id}] {title}")
|
||||||
|
|
||||||
|
if bounty.link:
|
||||||
|
lines.append(f"🔗 {bounty.link}")
|
||||||
|
|
||||||
|
if bounty.due_date_ts:
|
||||||
|
due_str = time.strftime("%d %B %Y %H:%M", time.localtime(bounty.due_date_ts))
|
||||||
|
lines.append(f"📅 {due_str} ({timezone})")
|
||||||
|
|
||||||
|
username = bounty.created_by_username or f"user#{bounty.created_by_user_id}"
|
||||||
|
lines.append(f"👤 @{username}")
|
||||||
|
|
||||||
|
created_str = time.strftime("%Y-%m-%d %H:%M", time.localtime(bounty.created_at))
|
||||||
|
lines.append(f"📌 Created: {created_str}")
|
||||||
|
|
||||||
|
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
||||||
|
|
||||||
|
|
||||||
|
async def cmd_timezone(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
|
args = extract_args(update.message.text)
|
||||||
|
room_id = get_room_id(update)
|
||||||
|
user_id = get_user_id(update)
|
||||||
|
|
||||||
|
if not args:
|
||||||
|
current_tz = BOUNTY_SERVICE.get_timezone(room_id)
|
||||||
|
await update.message.reply_text(f"Current timezone: {current_tz}")
|
||||||
|
return
|
||||||
|
|
||||||
|
timezone_str = args[0]
|
||||||
|
|
||||||
|
try:
|
||||||
|
ZoneInfo(timezone_str)
|
||||||
|
except (KeyError, ZoneInfoNotFoundError):
|
||||||
|
await update.message.reply_text(
|
||||||
|
"⛔ Invalid timezone. Use IANA format (e.g., Asia/Jakarta)"
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
|
try:
|
||||||
|
BOUNTY_SERVICE.set_timezone(room_id, timezone_str, user_id)
|
||||||
|
except PermissionError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
return
|
||||||
|
|
||||||
|
await update.message.reply_text(f"✅ Timezone set to {timezone_str}.")
|
||||||
|
|
||||||
|
|
||||||
|
async def cmd_recover(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
|
args = extract_args(update.message.text)
|
||||||
|
room_id = get_room_id(update)
|
||||||
|
user_id = get_user_id(update)
|
||||||
|
|
||||||
|
if not BOUNTY_SERVICE.is_admin(room_id, user_id):
|
||||||
|
await update.message.reply_text("⛔ Only admins can perform this action.")
|
||||||
|
return
|
||||||
|
|
||||||
|
if not args:
|
||||||
|
deleted_bounties = BOUNTY_SERVICE.list_deleted_bounties(room_id)
|
||||||
|
if not deleted_bounties:
|
||||||
|
await update.message.reply_text("No recoverable bounties.")
|
||||||
|
return
|
||||||
|
|
||||||
|
deleted_bounties.sort(key=lambda b: b.deleted_at or 0, reverse=True)
|
||||||
|
|
||||||
|
lines = ["Recoverable bounties:"]
|
||||||
|
for b in deleted_bounties[:10]:
|
||||||
|
text = (
|
||||||
|
b.text[:40] + "..."
|
||||||
|
if b.text and len(b.text) > 40
|
||||||
|
else (b.text or "(no text)")
|
||||||
|
)
|
||||||
|
link_str = f" | 🔗 {b.link}" if b.link else ""
|
||||||
|
deleted_str = (
|
||||||
|
time.strftime("%d %b %Y", time.localtime(b.deleted_at))
|
||||||
|
if b.deleted_at
|
||||||
|
else "unknown"
|
||||||
|
)
|
||||||
|
lines.append(f"[#{b.id}] {text}{link_str} | 🗑️ Deleted {deleted_str}")
|
||||||
|
|
||||||
|
await update.message.reply_text("\n".join(lines), disable_web_page_preview=True)
|
||||||
|
return
|
||||||
|
|
||||||
|
try:
|
||||||
|
bounty_ids = [int(arg) for arg in args]
|
||||||
|
except ValueError:
|
||||||
|
await update.message.reply_text("Invalid bounty ID.")
|
||||||
|
return
|
||||||
|
|
||||||
|
results = BOUNTY_SERVICE.recover_bounties(room_id, bounty_ids, user_id)
|
||||||
|
|
||||||
|
response_lines = []
|
||||||
|
for bounty_id, result in results.items():
|
||||||
|
if result == "recovered":
|
||||||
|
response_lines.append(f"✅ Recovered bounty #{bounty_id}.")
|
||||||
|
elif result == "not_found":
|
||||||
|
response_lines.append(f"⛔ Bounty #{bounty_id} not found.")
|
||||||
|
elif result == "not_deleted":
|
||||||
|
response_lines.append(f"⛔ Bounty #{bounty_id} is not deleted.")
|
||||||
|
elif result == "permission_denied":
|
||||||
|
response_lines.append(f"⛔ Bounty #{bounty_id} permission denied.")
|
||||||
|
|
||||||
|
await update.message.reply_text("\n".join(response_lines))
|
||||||
|
|
||||||
|
|
||||||
|
def _find_user_id_by_username(room_id: int, username: str) -> int | None:
|
||||||
|
"""Find user_id by username from bounty creators in the room."""
|
||||||
|
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
||||||
|
for bounty in bounties:
|
||||||
|
if (
|
||||||
|
bounty.created_by_username
|
||||||
|
and bounty.created_by_username.lower() == username.lower()
|
||||||
|
):
|
||||||
|
return bounty.created_by_user_id
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
def _find_username_by_user_id(room_id: int, user_id: int) -> str | None:
|
||||||
|
"""Find username by user_id from bounty creators in the room."""
|
||||||
|
bounties = BOUNTY_SERVICE.list_bounties(room_id)
|
||||||
|
for bounty in bounties:
|
||||||
|
if bounty.created_by_user_id == user_id:
|
||||||
|
return bounty.created_by_username
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
|
async def cmd_admin(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
|
args = extract_args(update.message.text)
|
||||||
|
if not args:
|
||||||
|
admins = BOUNTY_SERVICE.list_admins(get_room_id(update))
|
||||||
|
if not admins:
|
||||||
|
await update.message.reply_text("No admins in this room.")
|
||||||
|
return
|
||||||
|
admin_mentions = []
|
||||||
|
for admin_id in admins:
|
||||||
|
username = _find_username_by_user_id(get_room_id(update), admin_id)
|
||||||
|
if username:
|
||||||
|
admin_mentions.append(f"@{username}")
|
||||||
|
else:
|
||||||
|
admin_mentions.append(f"user#{admin_id}")
|
||||||
|
await update.message.reply_text(
|
||||||
|
f"Room Admins:\n" + "\n".join(f"- {m}" for m in admin_mentions)
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
|
if args[0] not in ("add", "remove"):
|
||||||
|
await update.message.reply_text(
|
||||||
|
"Usage:\n"
|
||||||
|
"/admin — list admins\n"
|
||||||
|
"/admin add @username — add admin\n"
|
||||||
|
"/admin remove @username — remove admin"
|
||||||
|
)
|
||||||
|
return
|
||||||
|
|
||||||
|
subcommand = args[0]
|
||||||
|
|
||||||
|
if len(args) < 2:
|
||||||
|
await update.message.reply_text(f"Usage: /admin {subcommand} @username")
|
||||||
|
return
|
||||||
|
|
||||||
|
raw_username = args[1]
|
||||||
|
if not raw_username.startswith("@"):
|
||||||
|
await update.message.reply_text(f"Usage: /admin {subcommand} @username")
|
||||||
|
return
|
||||||
|
|
||||||
|
username = raw_username[1:]
|
||||||
|
|
||||||
|
user_id = get_user_id(update)
|
||||||
|
room_id = get_room_id(update)
|
||||||
|
|
||||||
|
if not BOUNTY_SERVICE.is_admin(room_id, user_id):
|
||||||
|
await update.message.reply_text("⛔ Only admins can perform this action.")
|
||||||
|
return
|
||||||
|
|
||||||
|
target_user_id = _find_user_id_by_username(room_id, username)
|
||||||
|
|
||||||
|
if target_user_id is None:
|
||||||
|
await update.message.reply_text(f"⛔ User @{username} not found.")
|
||||||
|
return
|
||||||
|
|
||||||
|
try:
|
||||||
|
if subcommand == "add":
|
||||||
|
BOUNTY_SERVICE.add_admin(room_id, target_user_id, user_id)
|
||||||
|
await update.message.reply_text(f"✅ @{username} is now an admin.")
|
||||||
|
elif subcommand == "remove":
|
||||||
|
BOUNTY_SERVICE.remove_admin(room_id, target_user_id, user_id)
|
||||||
|
await update.message.reply_text(f"✅ @{username} is no longer an admin.")
|
||||||
|
except PermissionError as e:
|
||||||
|
await update.message.reply_text(f"⛔ {e}")
|
||||||
|
|
||||||
|
|
||||||
async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
async def cmd_help(update: Update, ctx: ContextTypes.DEFAULT_TYPE) -> None:
|
||||||
await update.message.reply_text(
|
await update.message.reply_text(
|
||||||
"👻 JIGAIDO Commands:\n\n"
|
"👻 JIGAIDO Commands:\n\n"
|
||||||
"/bounty — list all bounties\n"
|
"/bounty — list all bounties\n"
|
||||||
"/my — bounties you're tracking\n"
|
"/my — bounties you're tracking\n"
|
||||||
"/add <text> [link] [due] — add bounty\n"
|
"/add <text> [link] [due] — add bounty (admin only)\n"
|
||||||
"/update <id> [text> [link] [due] — update bounty\n"
|
"/update <id> [text> [link] [due] — update bounty (admin only)\n"
|
||||||
"/delete <id> — delete bounty\n"
|
"/edit <id> [text> [link] [due] — edit bounty (same as update)\n"
|
||||||
|
" /edit <id> -link [<url>] — clear or set link\n"
|
||||||
|
" /edit <id> -date [<date>] — clear or set date\n"
|
||||||
|
"/delete <id> [<id>...] — delete bounty (admin only)\n"
|
||||||
"/track <id> — track a bounty (groups only)\n"
|
"/track <id> — track a bounty (groups only)\n"
|
||||||
"/untrack <id> — stop tracking (groups only)\n"
|
"/untrack <id> — stop tracking (groups only)\n"
|
||||||
|
"/show <id> — show bounty details\n"
|
||||||
|
"/admin — list admins\n"
|
||||||
|
"/admin add @username — add admin (admin only)\n"
|
||||||
|
"/admin remove @username — remove admin (admin only)\n"
|
||||||
|
"/timezone — get room timezone\n"
|
||||||
|
"/timezone <tz> — set room timezone (admin only)\n"
|
||||||
|
"/recover — list recoverable bounties (admin only)\n"
|
||||||
|
"/recover <id> [<id>...] — recover bounty (admin only)\n"
|
||||||
"/start — re-initialize\n"
|
"/start — re-initialize\n"
|
||||||
"/help — this message",
|
"/help — this message",
|
||||||
disable_web_page_preview=True,
|
disable_web_page_preview=True,
|
||||||
|
|||||||
28
apps/telegram-bot/run_bot.py
Normal file
28
apps/telegram-bot/run_bot.py
Normal file
@@ -0,0 +1,28 @@
|
|||||||
|
#!/usr/bin/env python3
|
||||||
|
import asyncio
|
||||||
|
import os
|
||||||
|
import sys
|
||||||
|
|
||||||
|
# Run from the telegram-bot directory so local imports work
|
||||||
|
os.chdir("/home/shoko/repositories/jigaido/apps/telegram-bot")
|
||||||
|
sys.path.insert(0, "/home/shoko/repositories/jigaido")
|
||||||
|
|
||||||
|
# Import main from the local bot module
|
||||||
|
import bot as bot_module
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
if not bot_module.BOT_TOKEN:
|
||||||
|
bot_module.log.error("JIGAIDO_BOT_TOKEN environment variable not set.")
|
||||||
|
sys.exit(1)
|
||||||
|
|
||||||
|
app = bot_module.build_app()
|
||||||
|
app.post_init = bot_module.post_init
|
||||||
|
bot_module.log.info("JIGAIDO starting...")
|
||||||
|
|
||||||
|
# PTB v20+ app.run_polling() is async - use asyncio.get_event_loop() + run_until_complete
|
||||||
|
loop = asyncio.new_event_loop()
|
||||||
|
asyncio.set_event_loop(loop)
|
||||||
|
try:
|
||||||
|
loop.run_until_complete(app.run_polling(drop_pending_updates=True))
|
||||||
|
finally:
|
||||||
|
loop.close()
|
||||||
@@ -40,6 +40,25 @@ class RoomStorage(Protocol):
|
|||||||
"""Get a specific bounty from a room by ID."""
|
"""Get a specific bounty from a room by ID."""
|
||||||
...
|
...
|
||||||
|
|
||||||
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
|
"""List all non-deleted bounties in a room.
|
||||||
|
|
||||||
|
Soft-deleted bounties (where deleted_at is not None) are excluded.
|
||||||
|
"""
|
||||||
|
...
|
||||||
|
|
||||||
|
def list_all_bounties(
|
||||||
|
self, room_id: int, include_deleted: bool = True
|
||||||
|
) -> list[Bounty]:
|
||||||
|
"""List all bounties including or excluding soft-deleted.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
room_id: The room ID
|
||||||
|
include_deleted: If True, return all bounties including soft-deleted.
|
||||||
|
If False, return only non-deleted bounties.
|
||||||
|
"""
|
||||||
|
...
|
||||||
|
|
||||||
|
|
||||||
@runtime_checkable
|
@runtime_checkable
|
||||||
class TrackingStorage(Protocol):
|
class TrackingStorage(Protocol):
|
||||||
|
|||||||
203
core/services.py
203
core/services.py
@@ -15,11 +15,103 @@ class BountyService:
|
|||||||
- Positive room_id: DM/personal context (user's Telegram ID)
|
- Positive room_id: DM/personal context (user's Telegram ID)
|
||||||
|
|
||||||
This service handles both group and personal bounties through room_id.
|
This service handles both group and personal bounties through room_id.
|
||||||
|
|
||||||
|
Permissions:
|
||||||
|
- /add, /edit, /delete: admin only
|
||||||
|
- /admin, /admin add, /admin remove: admin only
|
||||||
|
- /bounty, /show, /track, /untrack, /my: everyone
|
||||||
"""
|
"""
|
||||||
|
|
||||||
def __init__(self, storage: RoomStorage):
|
def __init__(self, storage: RoomStorage):
|
||||||
self._storage = storage
|
self._storage = storage
|
||||||
|
|
||||||
|
def is_admin(self, room_id: int, user_id: int) -> bool:
|
||||||
|
"""Check if user is admin in a room."""
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return False
|
||||||
|
return user_id in (room_data.admin_user_ids or [])
|
||||||
|
|
||||||
|
def add_admin(
|
||||||
|
self, room_id: int, admin_user_id: int, requesting_user_id: int
|
||||||
|
) -> None:
|
||||||
|
"""Add an admin to a room. Requires admin permission."""
|
||||||
|
if not self.is_admin(room_id, requesting_user_id):
|
||||||
|
raise PermissionError("Only admins can add admins.")
|
||||||
|
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
room_data = RoomData(
|
||||||
|
room_id=room_id, bounties=[], next_id=1, admin_user_ids=[]
|
||||||
|
)
|
||||||
|
|
||||||
|
if admin_user_id not in (room_data.admin_user_ids or []):
|
||||||
|
(room_data.admin_user_ids or []).append(admin_user_id)
|
||||||
|
self._storage.save(room_data)
|
||||||
|
|
||||||
|
def remove_admin(
|
||||||
|
self, room_id: int, admin_user_id: int, requesting_user_id: int
|
||||||
|
) -> None:
|
||||||
|
"""Remove an admin from a room. Requires admin permission."""
|
||||||
|
if not self.is_admin(room_id, requesting_user_id):
|
||||||
|
raise PermissionError("Only admins can remove admins.")
|
||||||
|
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return
|
||||||
|
|
||||||
|
if admin_user_id in (room_data.admin_user_ids or []):
|
||||||
|
(room_data.admin_user_ids or []).remove(admin_user_id)
|
||||||
|
self._storage.save(room_data)
|
||||||
|
|
||||||
|
def list_admins(self, room_id: int) -> list[int]:
|
||||||
|
"""List all admin user IDs in a room."""
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return []
|
||||||
|
return list(room_data.admin_user_ids or [])
|
||||||
|
|
||||||
|
def set_timezone(
|
||||||
|
self, room_id: int, timezone: str, requesting_user_id: int
|
||||||
|
) -> None:
|
||||||
|
"""Set the timezone for a room. Requires admin permission."""
|
||||||
|
if not self.is_admin(room_id, requesting_user_id):
|
||||||
|
raise PermissionError("Only admins can set timezone.")
|
||||||
|
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
room_data = RoomData(
|
||||||
|
room_id=room_id, bounties=[], next_id=1, admin_user_ids=[]
|
||||||
|
)
|
||||||
|
|
||||||
|
room_data.timezone = timezone
|
||||||
|
self._storage.save(room_data)
|
||||||
|
|
||||||
|
def get_timezone(self, room_id: int) -> str:
|
||||||
|
"""Get the timezone for a room. Returns UTC+0 if not set."""
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return "UTC+0"
|
||||||
|
return room_data.timezone or "UTC+0"
|
||||||
|
|
||||||
|
def check_link_unique(
|
||||||
|
self, room_id: int, link: str | None, exclude_bounty_id: int | None = None
|
||||||
|
) -> bool:
|
||||||
|
"""Check if a link is unique within a room (not used by another bounty)."""
|
||||||
|
if not link:
|
||||||
|
return True
|
||||||
|
|
||||||
|
room_data = self._storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
return True
|
||||||
|
|
||||||
|
for bounty in room_data.bounties:
|
||||||
|
if bounty.deleted_at is not None:
|
||||||
|
continue
|
||||||
|
if bounty.link == link and bounty.id != exclude_bounty_id:
|
||||||
|
return False
|
||||||
|
return True
|
||||||
|
|
||||||
def add_bounty(
|
def add_bounty(
|
||||||
self,
|
self,
|
||||||
room_id: int,
|
room_id: int,
|
||||||
@@ -28,7 +120,13 @@ class BountyService:
|
|||||||
link: Optional[str] = None,
|
link: Optional[str] = None,
|
||||||
due_date_ts: Optional[int] = None,
|
due_date_ts: Optional[int] = None,
|
||||||
) -> Bounty:
|
) -> Bounty:
|
||||||
"""Add a new bounty to the room."""
|
"""Add a new bounty to the room. Requires admin permission."""
|
||||||
|
if not self.is_admin(room_id, user_id):
|
||||||
|
raise PermissionError("Only admins can add bounties.")
|
||||||
|
|
||||||
|
if not self.check_link_unique(room_id, link):
|
||||||
|
raise ValueError("A bounty with this link already exists in this room.")
|
||||||
|
|
||||||
room_data = self._storage.load(room_id)
|
room_data = self._storage.load(room_id)
|
||||||
if room_data is None:
|
if room_data is None:
|
||||||
room_data = RoomData(room_id=room_id, bounties=[], next_id=1)
|
room_data = RoomData(room_id=room_id, bounties=[], next_id=1)
|
||||||
@@ -47,15 +145,58 @@ class BountyService:
|
|||||||
return bounty
|
return bounty
|
||||||
|
|
||||||
def list_bounties(self, room_id: int) -> list[Bounty]:
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
"""List all bounties in a room."""
|
"""List all non-deleted bounties in a room."""
|
||||||
room_data = self._storage.load(room_id)
|
return self._storage.list_bounties(room_id)
|
||||||
if room_data is None:
|
|
||||||
return []
|
def list_deleted_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
return room_data.bounties
|
"""List all soft-deleted bounties in a room. For /recover functionality."""
|
||||||
|
all_bounties = self._storage.list_all_bounties(room_id, include_deleted=True)
|
||||||
|
return [b for b in all_bounties if b.deleted_at is not None]
|
||||||
|
|
||||||
|
def get_deleted_bounty(self, room_id: int, bounty_id: int) -> Bounty | None:
|
||||||
|
"""Get a specific soft-deleted bounty by ID."""
|
||||||
|
all_bounties = self._storage.list_all_bounties(room_id, include_deleted=True)
|
||||||
|
for b in all_bounties:
|
||||||
|
if b.id == bounty_id and b.deleted_at is not None:
|
||||||
|
return b
|
||||||
|
return None
|
||||||
|
|
||||||
|
def recover_bounty(self, room_id: int, bounty_id: int, user_id: int) -> str:
|
||||||
|
"""Recover a soft-deleted bounty. Admin only.
|
||||||
|
|
||||||
|
Returns: 'recovered', 'not_found', 'not_deleted', 'permission_denied'
|
||||||
|
"""
|
||||||
|
if not self.is_admin(room_id, user_id):
|
||||||
|
return "permission_denied"
|
||||||
|
|
||||||
|
bounty = self.get_deleted_bounty(room_id, bounty_id)
|
||||||
|
if not bounty:
|
||||||
|
return "not_found"
|
||||||
|
if bounty.deleted_at is None:
|
||||||
|
return "not_deleted"
|
||||||
|
|
||||||
|
bounty.deleted_at = None
|
||||||
|
self._storage.update_bounty(room_id, bounty)
|
||||||
|
return "recovered"
|
||||||
|
|
||||||
|
def recover_bounties(
|
||||||
|
self, room_id: int, bounty_ids: list[int], user_id: int
|
||||||
|
) -> dict[int, str]:
|
||||||
|
"""Recover multiple soft-deleted bounties. Admin only.
|
||||||
|
|
||||||
|
Returns dict of bounty_id -> result ('recovered', 'not_found', 'not_deleted', 'permission_denied')
|
||||||
|
"""
|
||||||
|
results = {}
|
||||||
|
for bounty_id in bounty_ids:
|
||||||
|
results[bounty_id] = self.recover_bounty(room_id, bounty_id, user_id)
|
||||||
|
return results
|
||||||
|
|
||||||
def get_bounty(self, room_id: int, bounty_id: int) -> Bounty | None:
|
def get_bounty(self, room_id: int, bounty_id: int) -> Bounty | None:
|
||||||
"""Get a specific bounty by ID."""
|
"""Get a specific bounty by ID. Excludes soft-deleted bounties."""
|
||||||
return self._storage.get_bounty(room_id, bounty_id)
|
bounty = self._storage.get_bounty(room_id, bounty_id)
|
||||||
|
if bounty and bounty.deleted_at is not None:
|
||||||
|
return None
|
||||||
|
return bounty
|
||||||
|
|
||||||
def update_bounty(
|
def update_bounty(
|
||||||
self,
|
self,
|
||||||
@@ -68,12 +209,17 @@ class BountyService:
|
|||||||
clear_link: bool = False,
|
clear_link: bool = False,
|
||||||
clear_due: bool = False,
|
clear_due: bool = False,
|
||||||
) -> bool:
|
) -> bool:
|
||||||
"""Update a bounty. Only creator can update."""
|
"""Update a bounty. Only admins can update."""
|
||||||
bounty = self._storage.get_bounty(room_id, bounty_id)
|
bounty = self._storage.get_bounty(room_id, bounty_id)
|
||||||
if not bounty:
|
if not bounty:
|
||||||
return False
|
return False
|
||||||
if bounty.created_by_user_id != user_id:
|
if not self.is_admin(room_id, user_id):
|
||||||
raise PermissionError("Only the creator can edit this bounty.")
|
raise PermissionError("Only admins can edit bounties.")
|
||||||
|
|
||||||
|
if link and not self.check_link_unique(
|
||||||
|
room_id, link, exclude_bounty_id=bounty_id
|
||||||
|
):
|
||||||
|
raise ValueError("A bounty with this link already exists in this room.")
|
||||||
|
|
||||||
updated = Bounty(
|
updated = Bounty(
|
||||||
id=bounty.id,
|
id=bounty.id,
|
||||||
@@ -84,21 +230,46 @@ class BountyService:
|
|||||||
if clear_due
|
if clear_due
|
||||||
else (due_date_ts if due_date_ts is not None else bounty.due_date_ts),
|
else (due_date_ts if due_date_ts is not None else bounty.due_date_ts),
|
||||||
created_at=bounty.created_at,
|
created_at=bounty.created_at,
|
||||||
|
deleted_at=bounty.deleted_at,
|
||||||
|
created_by_username=bounty.created_by_username,
|
||||||
)
|
)
|
||||||
self._storage.update_bounty(room_id, updated)
|
self._storage.update_bounty(room_id, updated)
|
||||||
return True
|
return True
|
||||||
|
|
||||||
def delete_bounty(self, room_id: int, bounty_id: int, user_id: int) -> bool:
|
def delete_bounty(self, room_id: int, bounty_id: int, user_id: int) -> bool:
|
||||||
"""Delete a bounty. Only creator can delete."""
|
"""Soft delete a bounty. Only admins can delete."""
|
||||||
bounty = self._storage.get_bounty(room_id, bounty_id)
|
bounty = self._storage.get_bounty(room_id, bounty_id)
|
||||||
if not bounty:
|
if not bounty:
|
||||||
return False
|
return False
|
||||||
if bounty.created_by_user_id != user_id:
|
if not self.is_admin(room_id, user_id):
|
||||||
raise PermissionError("Only the creator can delete this bounty.")
|
raise PermissionError("Only admins can delete bounties.")
|
||||||
|
|
||||||
self._storage.delete_bounty(room_id, bounty_id)
|
bounty.deleted_at = int(time.time())
|
||||||
|
self._storage.update_bounty(room_id, bounty)
|
||||||
return True
|
return True
|
||||||
|
|
||||||
|
def delete_bounties(
|
||||||
|
self, room_id: int, bounty_ids: list[int], user_id: int
|
||||||
|
) -> dict[int, str]:
|
||||||
|
"""Soft delete multiple bounties. Returns dict of bounty_id -> result.
|
||||||
|
|
||||||
|
Results can be: 'deleted', 'not_found', 'permission_denied'
|
||||||
|
"""
|
||||||
|
results = {}
|
||||||
|
for bounty_id in bounty_ids:
|
||||||
|
bounty = self._storage.get_bounty(room_id, bounty_id)
|
||||||
|
if not bounty:
|
||||||
|
results[bounty_id] = "not_found"
|
||||||
|
continue
|
||||||
|
if not self.is_admin(room_id, user_id):
|
||||||
|
results[bounty_id] = "permission_denied"
|
||||||
|
continue
|
||||||
|
|
||||||
|
bounty.deleted_at = int(time.time())
|
||||||
|
self._storage.update_bounty(room_id, bounty)
|
||||||
|
results[bounty_id] = "deleted"
|
||||||
|
return results
|
||||||
|
|
||||||
|
|
||||||
class TrackingService:
|
class TrackingService:
|
||||||
"""Service for tracking bounty operations."""
|
"""Service for tracking bounty operations."""
|
||||||
@@ -147,7 +318,7 @@ class TrackingService:
|
|||||||
if room_data is None:
|
if room_data is None:
|
||||||
return []
|
return []
|
||||||
|
|
||||||
bounty_map = {b.id: b for b in room_data.bounties}
|
bounty_map = {b.id: b for b in room_data.bounties if b.deleted_at is None}
|
||||||
return [
|
return [
|
||||||
bounty_map[t.bounty_id]
|
bounty_map[t.bounty_id]
|
||||||
for t in tracking_data.tracked
|
for t in tracking_data.tracked
|
||||||
|
|||||||
@@ -48,6 +48,20 @@ class SimpleRoomStorage:
|
|||||||
return b
|
return b
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
|
if room_id not in self._rooms:
|
||||||
|
return []
|
||||||
|
return [b for b in self._rooms[room_id].bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
def list_all_bounties(
|
||||||
|
self, room_id: int, include_deleted: bool = True
|
||||||
|
) -> list[Bounty]:
|
||||||
|
if room_id not in self._rooms:
|
||||||
|
return []
|
||||||
|
if include_deleted:
|
||||||
|
return self._rooms[room_id].bounties
|
||||||
|
return [b for b in self._rooms[room_id].bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
|
||||||
class SimpleTrackingStorage:
|
class SimpleTrackingStorage:
|
||||||
"""Minimal mock without ensure_tracking - tests if track_bounty works without it.
|
"""Minimal mock without ensure_tracking - tests if track_bounty works without it.
|
||||||
@@ -119,6 +133,20 @@ class MockRoomStorage:
|
|||||||
return b
|
return b
|
||||||
return None
|
return None
|
||||||
|
|
||||||
|
def list_bounties(self, room_id: int) -> list[Bounty]:
|
||||||
|
if room_id not in self._rooms:
|
||||||
|
return []
|
||||||
|
return [b for b in self._rooms[room_id].bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
def list_all_bounties(
|
||||||
|
self, room_id: int, include_deleted: bool = True
|
||||||
|
) -> list[Bounty]:
|
||||||
|
if room_id not in self._rooms:
|
||||||
|
return []
|
||||||
|
if include_deleted:
|
||||||
|
return self._rooms[room_id].bounties
|
||||||
|
return [b for b in self._rooms[room_id].bounties if b.deleted_at is None]
|
||||||
|
|
||||||
|
|
||||||
class MockTrackingStorage:
|
class MockTrackingStorage:
|
||||||
"""Mock implementation of TrackingStorage for testing."""
|
"""Mock implementation of TrackingStorage for testing."""
|
||||||
|
|||||||
@@ -15,18 +15,32 @@ class TestBountyService:
|
|||||||
"""Set up fresh storage and service for each test."""
|
"""Set up fresh storage and service for each test."""
|
||||||
self.storage = MockRoomStorage()
|
self.storage = MockRoomStorage()
|
||||||
self.service = BountyService(self.storage)
|
self.service = BountyService(self.storage)
|
||||||
|
self.admin_user_id = 123
|
||||||
|
self._make_admin(-1001, self.admin_user_id)
|
||||||
|
|
||||||
|
def _make_admin(self, room_id: int, user_id: int):
|
||||||
|
"""Helper to set up a room with an admin user."""
|
||||||
|
room_data = self.storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
room_data = RoomData(
|
||||||
|
room_id=room_id, bounties=[], next_id=0, admin_user_ids=[]
|
||||||
|
)
|
||||||
|
if user_id not in (room_data.admin_user_ids or []):
|
||||||
|
room_data.admin_user_ids = room_data.admin_user_ids or []
|
||||||
|
room_data.admin_user_ids.append(user_id)
|
||||||
|
self.storage.save(room_data)
|
||||||
|
|
||||||
def test_add_bounty_creates_room_if_not_exists(self):
|
def test_add_bounty_creates_room_if_not_exists(self):
|
||||||
"""Test that add_bounty creates a new room if it doesn't exist."""
|
"""Test that add_bounty creates a new room if it doesn't exist."""
|
||||||
bounty = self.service.add_bounty(
|
bounty = self.service.add_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Fix bug",
|
text="Fix bug",
|
||||||
link="https://github.com/issue/1",
|
link="https://github.com/issue/1",
|
||||||
)
|
)
|
||||||
assert bounty.id == 1
|
assert bounty.id == 1
|
||||||
assert bounty.text == "Fix bug"
|
assert bounty.text == "Fix bug"
|
||||||
assert bounty.created_by_user_id == 123
|
assert bounty.created_by_user_id == self.admin_user_id
|
||||||
|
|
||||||
room = self.storage.load(-1001)
|
room = self.storage.load(-1001)
|
||||||
assert room is not None
|
assert room is not None
|
||||||
@@ -34,14 +48,25 @@ class TestBountyService:
|
|||||||
|
|
||||||
def test_add_bounty_increments_id(self):
|
def test_add_bounty_increments_id(self):
|
||||||
"""Test that add_bounty increments bounty ID for each new bounty."""
|
"""Test that add_bounty increments bounty ID for each new bounty."""
|
||||||
b1 = self.service.add_bounty(room_id=-1001, user_id=123, text="First")
|
b1 = self.service.add_bounty(
|
||||||
b2 = self.service.add_bounty(room_id=-1001, user_id=123, text="Second")
|
room_id=-1001, user_id=self.admin_user_id, text="First"
|
||||||
b3 = self.service.add_bounty(room_id=-1001, user_id=123, text="Third")
|
)
|
||||||
|
b2 = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
||||||
|
)
|
||||||
|
b3 = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="Third"
|
||||||
|
)
|
||||||
|
|
||||||
assert b1.id == 1
|
assert b1.id == 1
|
||||||
assert b2.id == 2
|
assert b2.id == 2
|
||||||
assert b3.id == 3
|
assert b3.id == 3
|
||||||
|
|
||||||
|
def test_add_bounty_requires_admin(self):
|
||||||
|
"""Test that add_bounty raises PermissionError when non-admin tries to add."""
|
||||||
|
with pytest.raises(PermissionError, match="Only admins can add bounties"):
|
||||||
|
self.service.add_bounty(room_id=-1001, user_id=999, text="Not admin")
|
||||||
|
|
||||||
def test_list_bounties_empty_room(self):
|
def test_list_bounties_empty_room(self):
|
||||||
"""Test list_bounties returns empty list for non-existent room."""
|
"""Test list_bounties returns empty list for non-existent room."""
|
||||||
bounties = self.service.list_bounties(-1001)
|
bounties = self.service.list_bounties(-1001)
|
||||||
@@ -49,9 +74,15 @@ class TestBountyService:
|
|||||||
|
|
||||||
def test_list_bounties_returns_all_bounties(self):
|
def test_list_bounties_returns_all_bounties(self):
|
||||||
"""Test list_bounties returns all bounties in a room."""
|
"""Test list_bounties returns all bounties in a room."""
|
||||||
self.service.add_bounty(room_id=-1001, user_id=123, text="First")
|
self.service.add_bounty(room_id=-1001, user_id=self.admin_user_id, text="First")
|
||||||
self.service.add_bounty(room_id=-1001, user_id=123, text="Second")
|
self.service.add_bounty(
|
||||||
self.service.add_bounty(room_id=-999, user_id=123, text="Other room")
|
room_id=-1001, user_id=self.admin_user_id, text="Second"
|
||||||
|
)
|
||||||
|
# Add bounty to different room to verify isolation
|
||||||
|
self._make_admin(-999, self.admin_user_id)
|
||||||
|
self.service.add_bounty(
|
||||||
|
room_id=-999, user_id=self.admin_user_id, text="Other room"
|
||||||
|
)
|
||||||
|
|
||||||
bounties = self.service.list_bounties(-1001)
|
bounties = self.service.list_bounties(-1001)
|
||||||
assert len(bounties) == 2
|
assert len(bounties) == 2
|
||||||
@@ -59,7 +90,9 @@ class TestBountyService:
|
|||||||
|
|
||||||
def test_get_bounty_found(self):
|
def test_get_bounty_found(self):
|
||||||
"""Test get_bounty returns bounty when it exists."""
|
"""Test get_bounty returns bounty when it exists."""
|
||||||
created = self.service.add_bounty(room_id=-1001, user_id=123, text="Test")
|
created = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="Test"
|
||||||
|
)
|
||||||
found = self.service.get_bounty(-1001, created.id)
|
found = self.service.get_bounty(-1001, created.id)
|
||||||
assert found is not None
|
assert found is not None
|
||||||
assert found.text == "Test"
|
assert found.text == "Test"
|
||||||
@@ -71,31 +104,35 @@ class TestBountyService:
|
|||||||
|
|
||||||
def test_get_bounty_wrong_room(self):
|
def test_get_bounty_wrong_room(self):
|
||||||
"""Test get_bounty returns None when bounty is in different room."""
|
"""Test get_bounty returns None when bounty is in different room."""
|
||||||
self.service.add_bounty(room_id=-1001, user_id=123, text="Test")
|
self.service.add_bounty(room_id=-1001, user_id=self.admin_user_id, text="Test")
|
||||||
found = self.service.get_bounty(-999, 1) # room -999 doesn't have bounty 1
|
found = self.service.get_bounty(-999, 1) # room -999 doesn't have bounty 1
|
||||||
assert found is None
|
assert found is None
|
||||||
|
|
||||||
def test_update_bounty_success(self):
|
def test_update_bounty_success(self):
|
||||||
"""Test update_bounty succeeds when creator updates their bounty."""
|
"""Test update_bounty succeeds when admin updates their bounty."""
|
||||||
bounty = self.service.add_bounty(room_id=-1001, user_id=123, text="Original")
|
bounty = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="Original"
|
||||||
|
)
|
||||||
result = self.service.update_bounty(
|
result = self.service.update_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
bounty_id=bounty.id,
|
bounty_id=bounty.id,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Updated",
|
text="Updated",
|
||||||
)
|
)
|
||||||
assert result is True
|
assert result is True
|
||||||
updated = self.service.get_bounty(-1001, bounty.id)
|
updated = self.service.get_bounty(-1001, bounty.id)
|
||||||
assert updated.text == "Updated"
|
assert updated.text == "Updated"
|
||||||
|
|
||||||
def test_update_bounty_not_creator_raises_permission_error(self):
|
def test_update_bounty_not_admin_raises_permission_error(self):
|
||||||
"""Test update_bounty raises PermissionError when non-creator tries to update."""
|
"""Test update_bounty raises PermissionError when non-admin tries to update."""
|
||||||
bounty = self.service.add_bounty(room_id=-1001, user_id=123, text="Original")
|
bounty = self.service.add_bounty(
|
||||||
with pytest.raises(PermissionError, match="Only the creator can edit"):
|
room_id=-1001, user_id=self.admin_user_id, text="Original"
|
||||||
|
)
|
||||||
|
with pytest.raises(PermissionError, match="Only admins can edit bounties"):
|
||||||
self.service.update_bounty(
|
self.service.update_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
bounty_id=bounty.id,
|
bounty_id=bounty.id,
|
||||||
user_id=999, # different user
|
user_id=999, # different user, not admin
|
||||||
text="Hacked",
|
text="Hacked",
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -104,7 +141,7 @@ class TestBountyService:
|
|||||||
result = self.service.update_bounty(
|
result = self.service.update_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
bounty_id=999,
|
bounty_id=999,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Updated",
|
text="Updated",
|
||||||
)
|
)
|
||||||
assert result is False
|
assert result is False
|
||||||
@@ -113,14 +150,14 @@ class TestBountyService:
|
|||||||
"""Test update_bounty only updates provided fields."""
|
"""Test update_bounty only updates provided fields."""
|
||||||
bounty = self.service.add_bounty(
|
bounty = self.service.add_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Original",
|
text="Original",
|
||||||
link="https://original.link",
|
link="https://original.link",
|
||||||
)
|
)
|
||||||
self.service.update_bounty(
|
self.service.update_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
bounty_id=bounty.id,
|
bounty_id=bounty.id,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Updated only text",
|
text="Updated only text",
|
||||||
)
|
)
|
||||||
updated = self.service.get_bounty(-1001, bounty.id)
|
updated = self.service.get_bounty(-1001, bounty.id)
|
||||||
@@ -131,37 +168,88 @@ class TestBountyService:
|
|||||||
"""Test update_bounty can clear link."""
|
"""Test update_bounty can clear link."""
|
||||||
bounty = self.service.add_bounty(
|
bounty = self.service.add_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
text="Test",
|
text="Test",
|
||||||
link="https://original.link",
|
link="https://original.link",
|
||||||
)
|
)
|
||||||
self.service.update_bounty(
|
self.service.update_bounty(
|
||||||
room_id=-1001,
|
room_id=-1001,
|
||||||
bounty_id=bounty.id,
|
bounty_id=bounty.id,
|
||||||
user_id=123,
|
user_id=self.admin_user_id,
|
||||||
clear_link=True,
|
clear_link=True,
|
||||||
)
|
)
|
||||||
updated = self.service.get_bounty(-1001, bounty.id)
|
updated = self.service.get_bounty(-1001, bounty.id)
|
||||||
assert updated.link is None
|
assert updated.link is None
|
||||||
|
|
||||||
def test_delete_bounty_success(self):
|
def test_delete_bounty_success(self):
|
||||||
"""Test delete_bounty succeeds when creator deletes their bounty."""
|
"""Test delete_bounty soft deletes when admin deletes their bounty."""
|
||||||
bounty = self.service.add_bounty(room_id=-1001, user_id=123, text="To delete")
|
bounty = self.service.add_bounty(
|
||||||
result = self.service.delete_bounty(-1001, bounty.id, 123)
|
room_id=-1001, user_id=self.admin_user_id, text="To delete"
|
||||||
|
)
|
||||||
|
result = self.service.delete_bounty(-1001, bounty.id, self.admin_user_id)
|
||||||
assert result is True
|
assert result is True
|
||||||
|
# Soft delete - bounty should not be found via get_bounty
|
||||||
assert self.service.get_bounty(-1001, bounty.id) is None
|
assert self.service.get_bounty(-1001, bounty.id) is None
|
||||||
|
# But still exists in list_deleted_bounties
|
||||||
|
deleted = self.service.list_deleted_bounties(-1001)
|
||||||
|
assert len(deleted) == 1
|
||||||
|
assert deleted[0].id == bounty.id
|
||||||
|
|
||||||
def test_delete_bounty_not_creator_raises_permission_error(self):
|
def test_delete_bounty_not_admin_raises_permission_error(self):
|
||||||
"""Test delete_bounty raises PermissionError when non-creator tries to delete."""
|
"""Test delete_bounty raises PermissionError when non-admin tries to delete."""
|
||||||
bounty = self.service.add_bounty(room_id=-1001, user_id=123, text="To delete")
|
bounty = self.service.add_bounty(
|
||||||
with pytest.raises(PermissionError, match="Only the creator can delete"):
|
room_id=-1001, user_id=self.admin_user_id, text="To delete"
|
||||||
self.service.delete_bounty(-1001, bounty.id, 999) # different user
|
)
|
||||||
|
with pytest.raises(PermissionError, match="Only admins can delete bounties"):
|
||||||
|
self.service.delete_bounty(
|
||||||
|
-1001, bounty.id, 999
|
||||||
|
) # different user, not admin
|
||||||
|
|
||||||
def test_delete_bounty_not_found(self):
|
def test_delete_bounty_not_found(self):
|
||||||
"""Test delete_bounty returns False when bounty doesn't exist."""
|
"""Test delete_bounty returns False when bounty doesn't exist."""
|
||||||
result = self.service.delete_bounty(-1001, 999, 123)
|
result = self.service.delete_bounty(-1001, 999, self.admin_user_id)
|
||||||
assert result is False
|
assert result is False
|
||||||
|
|
||||||
|
def test_delete_bounties_multi_id_success(self):
|
||||||
|
"""Test delete_bounties returns individual results for multiple bounties."""
|
||||||
|
bounty1 = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="To delete 1"
|
||||||
|
)
|
||||||
|
bounty2 = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="To delete 2"
|
||||||
|
)
|
||||||
|
results = self.service.delete_bounties(
|
||||||
|
-1001, [bounty1.id, bounty2.id], self.admin_user_id
|
||||||
|
)
|
||||||
|
assert results == {bounty1.id: "deleted", bounty2.id: "deleted"}
|
||||||
|
# Verify both are soft deleted
|
||||||
|
assert self.service.get_bounty(-1001, bounty1.id) is None
|
||||||
|
assert self.service.get_bounty(-1001, bounty2.id) is None
|
||||||
|
|
||||||
|
def test_delete_bounties_mixed_results(self):
|
||||||
|
"""Test delete_bounties returns not_found for non-existent bounties."""
|
||||||
|
bounty = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="To delete"
|
||||||
|
)
|
||||||
|
results = self.service.delete_bounties(
|
||||||
|
-1001, [bounty.id, 999, 888], self.admin_user_id
|
||||||
|
)
|
||||||
|
assert results == {bounty.id: "deleted", 999: "not_found", 888: "not_found"}
|
||||||
|
|
||||||
|
def test_delete_bounties_permission_denied(self):
|
||||||
|
"""Test delete_bounties returns permission_denied for non-admin users."""
|
||||||
|
bounty = self.service.add_bounty(
|
||||||
|
room_id=-1001, user_id=self.admin_user_id, text="To delete"
|
||||||
|
)
|
||||||
|
results = self.service.delete_bounties(
|
||||||
|
-1001,
|
||||||
|
[bounty.id],
|
||||||
|
999, # non-admin user
|
||||||
|
)
|
||||||
|
assert results == {bounty.id: "permission_denied"}
|
||||||
|
# Verify bounty was NOT deleted
|
||||||
|
assert self.service.get_bounty(-1001, bounty.id) is not None
|
||||||
|
|
||||||
|
|
||||||
class TestTrackingService:
|
class TestTrackingService:
|
||||||
"""Unit tests for TrackingService."""
|
"""Unit tests for TrackingService."""
|
||||||
@@ -171,9 +259,27 @@ class TestTrackingService:
|
|||||||
self.room_storage = MockRoomStorage()
|
self.room_storage = MockRoomStorage()
|
||||||
self.tracking_storage = MockTrackingStorage()
|
self.tracking_storage = MockTrackingStorage()
|
||||||
self.service = TrackingService(self.tracking_storage, self.room_storage)
|
self.service = TrackingService(self.tracking_storage, self.room_storage)
|
||||||
|
self.admin_user_id = 123
|
||||||
|
self._make_admin(-1001, self.admin_user_id)
|
||||||
|
|
||||||
|
def _make_admin(self, room_id: int, user_id: int):
|
||||||
|
"""Helper to set up a room with an admin user."""
|
||||||
|
room_data = self.room_storage.load(room_id)
|
||||||
|
if room_data is None:
|
||||||
|
room_data = RoomData(
|
||||||
|
room_id=room_id, bounties=[], next_id=0, admin_user_ids=[]
|
||||||
|
)
|
||||||
|
if user_id not in (room_data.admin_user_ids or []):
|
||||||
|
room_data.admin_user_ids = room_data.admin_user_ids or []
|
||||||
|
room_data.admin_user_ids.append(user_id)
|
||||||
|
self.room_storage.save(room_data)
|
||||||
|
|
||||||
def _add_bounty(self, room_id=-1001, user_id=123, text="Test bounty"):
|
def _add_bounty(self, room_id=-1001, user_id=123, text="Test bounty"):
|
||||||
"""Helper to add a bounty for tracking tests."""
|
"""Helper to add a bounty for tracking tests."""
|
||||||
|
if self.room_storage.load(room_id) is None or user_id not in (
|
||||||
|
self.room_storage.load(room_id).admin_user_ids or []
|
||||||
|
):
|
||||||
|
self._make_admin(room_id, user_id)
|
||||||
bounty_service = BountyService(self.room_storage)
|
bounty_service = BountyService(self.room_storage)
|
||||||
return bounty_service.add_bounty(room_id=room_id, user_id=user_id, text=text)
|
return bounty_service.add_bounty(room_id=room_id, user_id=user_id, text=text)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user