- Test E7: verify fix_session_permissions function exists
- Test E8: verify cmd_doctor --fix-permissions flag is recognized
- Test E9: verify permission JSON is valid JSON
- Test E10: verify SQL UPDATE syntax works correctly
These tests verify the fix without requiring actual opencode installation.
- Add test E7: verify fix_session_permissions function exists
- Add test E8: verify cmd_doctor --fix-permissions flag is recognized
- Add fix_session_permissions call to cmd_init to set permissions
when initializing new sessions
Add --fix-permissions flag to cmd_doctor:
kugetsu doctor --fix-permissions
The fix_session_permissions() function:
- Updates base session and PM agent session permissions in SQLite
- Sets external_directory pattern to '*' with action 'allow'
- This fixes the issue where PM agent cannot access external directories
This addresses issue #36 where PM agent external_directory permission fails.
Fixes#36
Export KUGETSU_TEMP_DIR in cmd_delegate so subagents can use it
instead of /tmp which may be blocked by opencode.
Default: ~/.local/share/opencode/tool-output
This allows agents to write temp files in an allowed directory
instead of /tmp which is blocked in headless mode.
Fixes#73
Add tests for env pass-through feature:
- Test env command exists and lists files
- Test env set creates env file
- Test env show masks sensitive values (GITEA_TOKEN)
- Test set -a exports variables to child processes
- Test pm-agent.env takes precedence over default.env
- Test cmd_init creates env template files
These tests ensure the env pass-through mechanism works correctly
and that variables are properly exported to subagents.
The issue: variables sourced in cmd_delegate were not being passed
to child processes (subagents) because 'source' doesn't automatically
export variables to child processes.
Fix:
1. Use 'set -a' before sourcing to auto-export all variables
2. Use 'set +a' after sourcing to disable auto-export
3. Updated template comments to recommend 'export' prefix
Also added unit test to verify env pass-through works.
Verified with tests that child processes now see the exported variables.
Add section on Environment Variables for Agents:
- Explain env files (default.env, pm-agent.env)
- Document kugetsu env commands (list, show, set, get, rm)
- Show example usage for GITEA_TOKEN
- Note sensitive value masking
- Explain delegation usage
This ensures agents know to use kugetsu env instead of manually
injecting variables on each command.
Update cmd_init to create:
- ~/.kugetsu/env/ directory
- ~/.kugetsu/env/default.env (template)
- ~/.kugetsu/env/pm-agent.env (template)
Users can then edit these files to add their tokens/secrets.
Add environment variable management for delegating to agents.
Features:
- Add ENV_DIR constant (\~/.kugetsu/env)
- Add mask_sensitive_vars() to hide sensitive values in logs
- Add load_agent_env() to load agent-specific env files
- Add cmd_env command for managing env files:
- list: List all env files
- show [agent]: Show env file contents (masked)
- set <key> <value> [agent]: Set key=value
- get <key> [agent]: Get value for key
- rm <key> [agent]: Remove key
- Update cmd_delegate to load pm-agent.env or default.env before running
Example usage:
kugetsu env set GITEA_TOKEN xxx pm-agent
kugetsu delegate "post comment on #69"
Fixes#76
- Remove hardcoded git.fbrns.co server (users should add their own)
- Add comment about how to add servers
- Support --force flag in cmd_init to regenerate config file
This addresses han's review feedback:
1. Removed git.fbrns.co from default config
2. Config file can now be regenerated with --force flag
3. We continue using the existing config file (not separate file)
Document findings from database investigation:
- Session table schema with all fields explained
- Session ID format and generation (unique, no duplicates)
- Parent-child relationships for forked sessions
- Session detection logic used by kugetsu
- Permission structure and common issues
- SQL queries for debugging session problems
- Known issues and solutions (from #81, #36)
This document helps future debugging of session-related issues
without having to investigate opencode internals directly.
Replace string-based session comparison with array-based approach:
- Store before_sessions in an array instead of pipe-delimited string
- This is more robust against word-splitting issues in bash
- Skip base_session_id and pm_agent_session_id explicitly
- Compare each after-session against the before array
This approach is more reliable when multiple agents fork concurrently
because it properly compares each session ID individually rather than
relying on regex matching in a string.
Fixes#81
When cmd_start forks a new session, the session detection logic now
excludes both base_session_id AND pm_agent_session_id to prevent
forked sessions from being misidentified as the pm-agent session.
This addresses issue #81 where forked sessions were showing the same
session ID as the pm-agent.
Add 'kugetsu server' command for managing git server configurations:
- kugetsu server list List all configured git servers
- kugetsu server add <name> <url> Add a new git server
- kugetsu server remove <name> Remove a git server
- kugetsu server default [<name>] Get or set default server
- kugetsu server get [<name>] Get URL for a server
Update get_repo_url() to use GIT_SERVERS config:
- First checks repos.json for direct mapping
- Then checks GIT_SERVERS for matching hostname
- Falls back to DEFAULT_GIT_SERVER
- Falls back to github.com as last resort
Update cmd_init to create config with default git servers:
- github.com -> https://github.com
- git.fbrns.co -> https://git.fbrns.coFixes#78
Set GIT_EDITOR and EDITOR to 'cat' in kugetsu init to prevent
vim from opening during git operations in headless mode.
This fixes issues where git rebase --continue would hang waiting
for vim TTY input in opencode sessions.
Fixes#70
- Source ~/.kugetsu/config on each command call
- Allows user to override defaults (e.g., MAX_CONCURRENT_AGENTS)
- Changes take effect immediately, no re-init needed
Fixes#67
The session-counting approach (PR #65) now properly handles agent
concurrency limits. Remove the broken slot-based mechanism:
- Remove acquire_agent_slot() and release_agent_slot() functions
- Remove AGENT_COUNT_FILE and AGENT_LOCK_FILE variables
- Remove unused run_with_limit() function
- Remove release-slot.sh script
- Update cmd_delegate to use fire-and-forget without slot management
Both cmd_start and cmd_delegate now use count_active_dev_sessions()
for concurrency checking.
Replaced broken slot-based mechanism with session-counting:
- Added count_active_dev_sessions() function that counts actual
session files in ~/.kugetsu/sessions/, excluding base.json and pm-agent.json
- Modified cmd_start() to check session count before creating new session:
- If count >= MAX_CONCURRENT_AGENTS, reject with error
- Otherwise allow new session creation
- Removed wait since --fork returns immediately
- cmd_continue() no longer counts toward limit (existing sessions
can always continue via --continue)
This properly enforces MAX_CONCURRENT_AGENTS while preserving --fork
functionality. The slot mechanism didn't work because opencode run
--fork returns immediately after forking, not after child completes.
- Fixed cmd_start() and cmd_continue() to wait for forked child
- Capture child PID with $! and wait before release_agent_slot
- This ensures slot is only released after child process completes
Issue #57: worktree creation was creating bare repos instead of
proper worktrees, breaking parallel agent workflow.
The --bare flag created repos with no working directory, making them
useless for development. Changed to regular clone.
PR #54 fixed opencode arg order in cmd_delegate and cmd_start,
but kugetsu init function still had message AFTER flags.
Fixed in:
- kugetsu_init function: message before --fork --session
- Similar patterns in session creation code
Closes related to #53
Replace hardcoded git.fbrns.co/shoko/kugetsu with dynamic
<domain>/<user>/<repo> format pulled from git remote and config.
Makes PM skill usable with github.com, gitlab.com, or any git server.
- PM can ONLY write to ~/.kugetsu/queue.json and ~/.kugetsu/logs/* (was entire ~/.kugetsu/)
- Update delegation format to git.fbrns.co/shoko/kugetsu#<issue>
- PM must not write new kugetsu scripts - delegate via issue/PR workflow
- Update examples and violation cases to reflect stricter boundaries
Issue #52: PM violated NEVER write code constraint by writing directly to
repo files (SKILL.md) instead of delegating to a dev agent.
Added explicit Write Permissions section defining:
- PM can ONLY write to ~/.kugetsu/
- PM can NEVER write to repositories/*, skills/*, or any dir outside ~/.kugetsu/
- If asked to write outside ~/.kugetsu/, must delegate via kugetsu start
opencode CLI requires: opencode run "message" --session sid --workdir /path
But kugetsu was placing message AFTER flags, causing all commands to fail.
Fixed in:
- cmd_delegate: nohup sh -c with message first
- cmd_start: --fork --session with message first
- fork_session_for_issue: --continue --session with message first
Closes#53
