• Joined on 2025-01-01
han commented on pull request shoko/jujutsu-skills#33 2026-03-27 02:05:45 +01:00
security(polymarket-browse): validate --detail argument and show error if out of range

I don't understand the issue. can you provide me like the case example what was happened before the patch and what will happen after the patch? I think we should verify that with unit test cases…

han commented on pull request shoko/jujutsu-skills#31 2026-03-27 02:00:27 +01:00
fix(polymarket-browse): add --timezone CLI argument for display timezone

lets keep UTC+7 format

han commented on pull request shoko/jujutsu-skills#31 2026-03-27 01:55:26 +01:00
fix(polymarket-browse): add --timezone CLI argument for display timezone

I have a question, is it better to use UTC+7 format or is it better to use Asia/Jakarta format. what are the tradeoff?

han commented on pull request shoko/jujutsu-skills#30 2026-03-27 01:36:35 +01:00
feat(polymarket-browse): add --starts-before filter for match events

closes #29

han approved shoko/jujutsu-skills#26 2026-03-26 18:21:03 +01:00
Add parallel fetching, caching, and max_total parameter

lgtm, lets merge it

han commented on issue shoko/jujutsu-skills#25 2026-03-26 17:17:56 +01:00
[Analysis] API Efficiency Issues and Optimization Opportunities

yes lets proceed

han commented on issue shoko/jujutsu-skills#25 2026-03-26 17:13:49 +01:00
[Analysis] API Efficiency Issues and Optimization Opportunities

Parallel Page Fetches

yes I think going with min(5, total_pages) is good for now. we'll see later if we need further enchantment or not

Smarter Early Exit

I think once we got…

han commented on issue shoko/jujutsu-skills#25 2026-03-26 17:03:24 +01:00
[Analysis] API Efficiency Issues and Optimization Opportunities

Parallel Page Fetches

for parallelization, how much parallel should we do in a single process? I meant for example if there is 50 pages. should we just run 50 parallelization? or we will…

han approved shoko/jujutsu-skills#24 2026-03-26 16:42:31 +01:00
Fix line lengths in browse.py

lgtm

han approved shoko/jujutsu-skills#23 2026-03-26 16:40:56 +01:00
Add type hints to browse.py

lgtm

han commented on pull request shoko/jujutsu-skills#20 2026-03-25 13:13:08 +01:00
Fix #5: HTML injection in Telegram messages

lgtm

han commented on pull request shoko/jujutsu-skills#20 2026-03-25 12:58:29 +01:00
Fix #5: HTML injection in Telegram messages

I think its also possible that the HTML injection come from either of outcomes or sportsMarketType, since we render both of these values to telegram, no? what do you think about it?

han commented on pull request shoko/jujutsu-skills#20 2026-03-25 12:58:12 +01:00
Fix #5: HTML injection in Telegram messages

does escape_html remove the symbols when sending it to telegram? or is it keeping the symbol with different format? can you also make a test run by sending it to my telegram?

han commented on pull request shoko/jujutsu-skills#20 2026-03-25 12:57:57 +01:00
Fix #5: HTML injection in Telegram messages

is this stdlib or user need to install this package before running this script?